From: Felipe Balbi <balbi@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
Linux ARM Kernel Mailing List
<linux-arm-kernel@lists.infradead.org>,
Felipe Balbi <balbi@ti.com>
Subject: [RFT/RFC/PATCH 27/31] arm: omap: irq: drop omap_pending_irq()
Date: Wed, 20 Nov 2013 12:09:14 -0600 [thread overview]
Message-ID: <1384970958-4118-28-git-send-email-balbi@ti.com> (raw)
In-Reply-To: <1384970958-4118-1-git-send-email-balbi@ti.com>
We already ack pending IRQs during suspend,
which renders the check for pending IRQs
quite unnecessary.
Signed-off-by: Felipe Balbi <balbi@ti.com>
---
arch/arm/mach-omap2/common.h | 1 -
arch/arm/mach-omap2/cpuidle34xx.c | 2 +-
arch/arm/mach-omap2/irq.c | 11 -----------
arch/arm/mach-omap2/pm24xx.c | 11 -----------
arch/arm/mach-omap2/pm34xx.c | 3 ---
5 files changed, 1 insertion(+), 27 deletions(-)
diff --git a/arch/arm/mach-omap2/common.h b/arch/arm/mach-omap2/common.h
index 427160b..f44a410 100644
--- a/arch/arm/mach-omap2/common.h
+++ b/arch/arm/mach-omap2/common.h
@@ -198,7 +198,6 @@ extern struct device *omap4_get_dsp_device(void);
void omap2_init_irq(void);
void omap3_init_irq(void);
void ti81xx_init_irq(void);
-extern int omap_irq_pending(void);
void omap_gic_of_init(void);
#ifdef CONFIG_CACHE_L2X0
diff --git a/arch/arm/mach-omap2/cpuidle34xx.c b/arch/arm/mach-omap2/cpuidle34xx.c
index e18709d..96cced3 100644
--- a/arch/arm/mach-omap2/cpuidle34xx.c
+++ b/arch/arm/mach-omap2/cpuidle34xx.c
@@ -112,7 +112,7 @@ static int omap3_enter_idle(struct cpuidle_device *dev,
{
struct omap3_idle_statedata *cx = &omap3_idle_data[index];
- if (omap_irq_pending() || need_resched())
+ if (need_resched())
goto return_sleep_time;
/* Deny idle for C1 */
diff --git a/arch/arm/mach-omap2/irq.c b/arch/arm/mach-omap2/irq.c
index 5425258..397157a 100644
--- a/arch/arm/mach-omap2/irq.c
+++ b/arch/arm/mach-omap2/irq.c
@@ -186,17 +186,6 @@ static void __init omap_irq_soft_reset(void)
intc_writel(INTC_SYSCONFIG, 1 << 0);
}
-int omap_irq_pending(void)
-{
- int irq;
-
- for (irq = 0; irq < omap_nr_irqs; irq += 32)
- if (intc_readl(INTC_PENDING_IRQ0 +
- ((irq >> 5) << 5)))
- return 1;
- return 0;
-}
-
static __init void
omap_alloc_gc(void __iomem *base, unsigned int irq_start, unsigned int num)
{
diff --git a/arch/arm/mach-omap2/pm24xx.c b/arch/arm/mach-omap2/pm24xx.c
index 8c07594..33ea27c 100644
--- a/arch/arm/mach-omap2/pm24xx.c
+++ b/arch/arm/mach-omap2/pm24xx.c
@@ -88,17 +88,11 @@ static int omap2_enter_full_retention(void)
omap2_gpio_prepare_for_idle(0);
- /* One last check for pending IRQs to avoid extra latency due
- * to sleeping unnecessarily. */
- if (omap_irq_pending())
- goto no_sleep;
-
/* Jump to SRAM suspend code */
omap2_sram_suspend(sdrc_read_reg(SDRC_DLLA_CTRL),
OMAP_SDRC_REGADDR(SDRC_DLLA_CTRL),
OMAP_SDRC_REGADDR(SDRC_POWER));
-no_sleep:
omap2_gpio_resume_after_idle();
clk_enable(osc_ck);
@@ -181,15 +175,10 @@ static int omap2_can_sleep(void)
static void omap2_pm_idle(void)
{
if (!omap2_can_sleep()) {
- if (omap_irq_pending())
- return;
omap2_enter_mpu_retention();
return;
}
- if (omap_irq_pending())
- return;
-
omap2_enter_full_retention();
}
diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
index 2764796..7c43fa0 100644
--- a/arch/arm/mach-omap2/pm34xx.c
+++ b/arch/arm/mach-omap2/pm34xx.c
@@ -338,9 +338,6 @@ void omap_sram_idle(void)
static void omap3_pm_idle(void)
{
- if (omap_irq_pending())
- return;
-
trace_cpu_idle(1, smp_processor_id());
omap_sram_idle();
--
1.8.4.GIT
next prev parent reply other threads:[~2013-11-20 18:10 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-20 18:08 [RFT/RFC/PATCH 00/31] arm: omap: irq: cleanup INTC driver Felipe Balbi
2013-11-20 18:08 ` [RFT/RFC/PATCH 01/31] arm: omap: irq: make omap_irq_base global Felipe Balbi
2013-11-20 18:08 ` [RFT/RFC/PATCH 02/31] arm: omap: irq: define INTC_ILR0 register Felipe Balbi
2013-11-20 18:08 ` [RFT/RFC/PATCH 03/31] arm: omap: irq: start to remove irq_banks array Felipe Balbi
2013-11-20 18:08 ` [RFT/RFC/PATCH 04/31] arm: omap: irq: add a global omap_nr_irqs variable Felipe Balbi
2013-11-20 18:08 ` [RFT/RFC/PATCH 05/31] arm: omap: irq: remove rest of irq_banks usage Felipe Balbi
2013-11-20 18:08 ` [RFT/RFC/PATCH 06/31] arm: omap: irq: remove unused macro Felipe Balbi
2013-11-20 18:08 ` [RFT/RFC/PATCH 07/31] arm: omap: irq: switch over to intc_readl on omap_intc_handle_irq Felipe Balbi
2013-11-20 18:08 ` [RFT/RFC/PATCH 08/31] arm: omap: irq: remove unnecessary base_addr argument Felipe Balbi
2013-11-20 18:08 ` [RFT/RFC/PATCH 09/31] arm: omap: irq: rename omap3_intc_regs Felipe Balbi
2013-11-20 18:08 ` [RFT/RFC/PATCH 10/31] arm: omap: irq: always define omap3 support Felipe Balbi
2013-11-20 18:08 ` [RFT/RFC/PATCH 11/31] arm: omap: irq: reorganize code a little bit Felipe Balbi
2013-11-20 18:08 ` [RFT/RFC/PATCH 12/31] arm: omap: irq: add suspend/resume methods Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 13/31] arm: omap: irq: remove last bits of our homebrew irqchip pm Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 14/31] arm: omap: irq: make intc_of_init static Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 15/31] arm: omap: irq: call set_handle_irq() from intc_of_init Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 16/31] arm: omap: irq: use IRQCHIP_DECLARE macro Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 17/31] arm: omap: irq: drop .handle_irq and .init_irq fields Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 18/31] arm: omap: irq: add specific compatibles for omap3 and am33xx devices Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 19/31] arm: omap: irq: use compatible flag to figure out number of IRQ lines Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 20/31] arm: boot: dts: am33xx/omap3: fix intc compatible flag Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 21/31] arm: omap: irq: drop ti,intc-size support Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 22/31] arm: boot: dts: omap2/3/am33xx: drop ti,intc-size Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 23/31] arm: omap: irq: move some more code around Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 24/31] arm: omap: irq: call set_handle_irq() from .init_irq Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 25/31] arm: omap: irq: drop omap3_intc_handle_irq() Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 26/31] arm: omap: irq: drop omap2_intc_handle_irq() Felipe Balbi
2013-11-20 18:09 ` Felipe Balbi [this message]
2013-11-20 18:09 ` [RFT/RFC/PATCH 28/31] arm: omap: irq: remove unnecessary header Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 29/31] arm: omap: irq: remove nr_irqs argument Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 30/31] arm: omap: irq: introduce omap_nr_pending Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 31/31] arm: omap: irq: get rid of ifdef hack Felipe Balbi
2013-12-19 18:48 ` [RFT/RFC/PATCH 00/31] arm: omap: irq: cleanup INTC driver Tony Lindgren
2013-12-19 23:21 ` Felipe Balbi
2013-12-21 0:53 ` Tony Lindgren
2013-12-23 17:34 ` Felipe Balbi
2014-01-02 22:01 ` Felipe Balbi
2014-01-03 12:12 ` Rajendra Nayak
2014-01-03 16:40 ` Felipe Balbi
2014-07-15 9:14 ` Tony Lindgren
2014-07-15 19:56 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384970958-4118-28-git-send-email-balbi@ti.com \
--to=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox