public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
	Linux ARM Kernel Mailing List
	<linux-arm-kernel@lists.infradead.org>,
	Felipe Balbi <balbi@ti.com>
Subject: [RFT/RFC/PATCH 31/31] arm: omap: irq: get rid of ifdef hack
Date: Wed, 20 Nov 2013 12:09:18 -0600	[thread overview]
Message-ID: <1384970958-4118-32-git-send-email-balbi@ti.com> (raw)
In-Reply-To: <1384970958-4118-1-git-send-email-balbi@ti.com>

we don't need the ifdef if we have omap_nr_pending
telling us how many pending registers we have
on current platform. This solves a possible
problem where we could try to handle bogus
interrupts on OMAP2 and OMAP3 if using single
zImage kernel, because we would end up reading
the following pending FIQ register.

Signed-off-by: Felipe Balbi <balbi@ti.com>
---
 arch/arm/mach-omap2/irq.c | 22 +++++++---------------
 1 file changed, 7 insertions(+), 15 deletions(-)

diff --git a/arch/arm/mach-omap2/irq.c b/arch/arm/mach-omap2/irq.c
index 1b2266a..35669c1 100644
--- a/arch/arm/mach-omap2/irq.c
+++ b/arch/arm/mach-omap2/irq.c
@@ -234,23 +234,15 @@ static void __init omap_init_irq(u32 base, struct device_node *node)
 static asmlinkage void __exception_irq_entry
 omap_intc_handle_irq(struct pt_regs *regs)
 {
-	u32 irqnr;
+	u32 irqnr = 0;
+	int i;
 
 	do {
-		irqnr = intc_readl(INTC_PENDING_IRQ0);
-		if (irqnr)
-			goto out;
-
-		irqnr = intc_readl(INTC_PENDING_IRQ1);
-		if (irqnr)
-			goto out;
-
-		irqnr = intc_readl(INTC_PENDING_IRQ2);
-#if IS_ENABLED(CONFIG_SOC_TI81XX) || IS_ENABLED(CONFIG_SOC_AM33XX)
-		if (irqnr)
-			goto out;
-		irqnr = intc_readl(INTC_PENDING_IRQ3);
-#endif
+		for (i = 0; i < omap_nr_pending; i++) {
+			irqnr = intc_readl(INTC_PENDING_IRQ0 + (0x20 * i));
+			if (irqnr)
+				goto out;
+		}
 
 out:
 		if (!irqnr)
-- 
1.8.4.GIT


  parent reply	other threads:[~2013-11-20 18:10 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-20 18:08 [RFT/RFC/PATCH 00/31] arm: omap: irq: cleanup INTC driver Felipe Balbi
2013-11-20 18:08 ` [RFT/RFC/PATCH 01/31] arm: omap: irq: make omap_irq_base global Felipe Balbi
2013-11-20 18:08 ` [RFT/RFC/PATCH 02/31] arm: omap: irq: define INTC_ILR0 register Felipe Balbi
2013-11-20 18:08 ` [RFT/RFC/PATCH 03/31] arm: omap: irq: start to remove irq_banks array Felipe Balbi
2013-11-20 18:08 ` [RFT/RFC/PATCH 04/31] arm: omap: irq: add a global omap_nr_irqs variable Felipe Balbi
2013-11-20 18:08 ` [RFT/RFC/PATCH 05/31] arm: omap: irq: remove rest of irq_banks usage Felipe Balbi
2013-11-20 18:08 ` [RFT/RFC/PATCH 06/31] arm: omap: irq: remove unused macro Felipe Balbi
2013-11-20 18:08 ` [RFT/RFC/PATCH 07/31] arm: omap: irq: switch over to intc_readl on omap_intc_handle_irq Felipe Balbi
2013-11-20 18:08 ` [RFT/RFC/PATCH 08/31] arm: omap: irq: remove unnecessary base_addr argument Felipe Balbi
2013-11-20 18:08 ` [RFT/RFC/PATCH 09/31] arm: omap: irq: rename omap3_intc_regs Felipe Balbi
2013-11-20 18:08 ` [RFT/RFC/PATCH 10/31] arm: omap: irq: always define omap3 support Felipe Balbi
2013-11-20 18:08 ` [RFT/RFC/PATCH 11/31] arm: omap: irq: reorganize code a little bit Felipe Balbi
2013-11-20 18:08 ` [RFT/RFC/PATCH 12/31] arm: omap: irq: add suspend/resume methods Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 13/31] arm: omap: irq: remove last bits of our homebrew irqchip pm Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 14/31] arm: omap: irq: make intc_of_init static Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 15/31] arm: omap: irq: call set_handle_irq() from intc_of_init Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 16/31] arm: omap: irq: use IRQCHIP_DECLARE macro Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 17/31] arm: omap: irq: drop .handle_irq and .init_irq fields Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 18/31] arm: omap: irq: add specific compatibles for omap3 and am33xx devices Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 19/31] arm: omap: irq: use compatible flag to figure out number of IRQ lines Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 20/31] arm: boot: dts: am33xx/omap3: fix intc compatible flag Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 21/31] arm: omap: irq: drop ti,intc-size support Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 22/31] arm: boot: dts: omap2/3/am33xx: drop ti,intc-size Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 23/31] arm: omap: irq: move some more code around Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 24/31] arm: omap: irq: call set_handle_irq() from .init_irq Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 25/31] arm: omap: irq: drop omap3_intc_handle_irq() Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 26/31] arm: omap: irq: drop omap2_intc_handle_irq() Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 27/31] arm: omap: irq: drop omap_pending_irq() Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 28/31] arm: omap: irq: remove unnecessary header Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 29/31] arm: omap: irq: remove nr_irqs argument Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 30/31] arm: omap: irq: introduce omap_nr_pending Felipe Balbi
2013-11-20 18:09 ` Felipe Balbi [this message]
2013-12-19 18:48 ` [RFT/RFC/PATCH 00/31] arm: omap: irq: cleanup INTC driver Tony Lindgren
2013-12-19 23:21   ` Felipe Balbi
2013-12-21  0:53     ` Tony Lindgren
2013-12-23 17:34       ` Felipe Balbi
2014-01-02 22:01         ` Felipe Balbi
2014-01-03 12:12           ` Rajendra Nayak
2014-01-03 16:40             ` Felipe Balbi
2014-07-15  9:14               ` Tony Lindgren
2014-07-15 19:56                 ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1384970958-4118-32-git-send-email-balbi@ti.com \
    --to=balbi@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox