* [PATCH 65/86] usb/dwc3: comment update [not found] <1427635734-24786-1-git-send-email-mst@redhat.com> @ 2015-03-29 13:42 ` Michael S. Tsirkin [not found] ` <1427635734-24786-1-git-send-email-mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 1 sibling, 0 replies; 6+ messages in thread From: Michael S. Tsirkin @ 2015-03-29 13:42 UTC (permalink / raw) To: linux-kernel; +Cc: Felipe Balbi, Greg Kroah-Hartman, linux-usb, linux-omap Header moved from linux/pci_ids.h to uapi/linux/pci_ids.h, update comment to list the correct header. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- drivers/usb/dwc3/dwc3-pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c index 8d95056..4285d8f 100644 --- a/drivers/usb/dwc3/dwc3-pci.c +++ b/drivers/usb/dwc3/dwc3-pci.c @@ -24,7 +24,7 @@ #include "platform_data.h" -/* FIXME define these in <linux/pci_ids.h> */ +/* FIXME define these in <uapi/linux/pci_ids.h> */ #define PCI_VENDOR_ID_SYNOPSYS 0x16c3 #define PCI_DEVICE_ID_SYNOPSYS_HAPSUSB3 0xabcd #define PCI_DEVICE_ID_INTEL_BYT 0x0f37 -- MST ^ permalink raw reply related [flat|nested] 6+ messages in thread
[parent not found: <1427635734-24786-1-git-send-email-mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]
* [PATCH 86/86] usb/dwc3: move ids to pci_ids.h [not found] ` <1427635734-24786-1-git-send-email-mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> @ 2015-03-29 13:43 ` Michael S. Tsirkin [not found] ` <1427635734-24786-87-git-send-email-mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 0 siblings, 1 reply; 6+ messages in thread From: Michael S. Tsirkin @ 2015-03-29 13:43 UTC (permalink / raw) To: linux-kernel-u79uwXL29TY76Z2rM5mHXA Cc: Felipe Balbi, Greg Kroah-Hartman, Bjorn Helgaas, Thomas Gleixner, Andy Shevchenko, Andy Lutomirski, Peter Neubauer, Huang Rui, Jean Delvare, linux-usb-u79uwXL29TY76Z2rM5mHXA, linux-omap-u79uwXL29TY76Z2rM5mHXA, linux-api-u79uwXL29TY76Z2rM5mHXA Comment says IDs should move to pci_ids.h, let's do it. Signed-off-by: Michael S. Tsirkin <mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> --- include/uapi/linux/pci_ids.h | 8 ++++++++ drivers/usb/dwc3/dwc3-pci.c | 10 +--------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/include/uapi/linux/pci_ids.h b/include/uapi/linux/pci_ids.h index e63c02a..c10833f3 100644 --- a/include/uapi/linux/pci_ids.h +++ b/include/uapi/linux/pci_ids.h @@ -2312,6 +2312,9 @@ #define PCI_VENDOR_ID_NETCELL 0x169c #define PCI_DEVICE_ID_REVOLUTION 0x0044 +#define PCI_VENDOR_ID_SYNOPSYS 0x16c3 +#define PCI_DEVICE_ID_SYNOPSYS_HAPSUSB3 0xabcd + #define PCI_VENDOR_ID_CENATEK 0x16CA #define PCI_DEVICE_ID_CENATEK_IDE 0x0001 @@ -2567,11 +2570,13 @@ #define PCI_DEVICE_ID_INTEL_I960 0x0960 #define PCI_DEVICE_ID_INTEL_I960RM 0x0962 #define PCI_DEVICE_ID_INTEL_CENTERTON_ILB 0x0c60 +#define PCI_DEVICE_ID_INTEL_BYT 0x0f37 #define PCI_DEVICE_ID_INTEL_8257X_SOL 0x1062 #define PCI_DEVICE_ID_INTEL_82573E_SOL 0x1085 #define PCI_DEVICE_ID_INTEL_82573L_SOL 0x108F #define PCI_DEVICE_ID_INTEL_82815_MC 0x1130 #define PCI_DEVICE_ID_INTEL_82815_CGC 0x1132 +#define PCI_DEVICE_ID_INTEL_MRFLD 0x119e #define PCI_DEVICE_ID_INTEL_82092AA_0 0x1221 #define PCI_DEVICE_ID_INTEL_7505_0 0x2550 #define PCI_DEVICE_ID_INTEL_7205_0 0x255d @@ -2593,6 +2598,7 @@ #define PCI_DEVICE_ID_INTEL_PANTHERPOINT_XHCI 0x1e31 #define PCI_DEVICE_ID_INTEL_PANTHERPOINT_LPC_MIN 0x1e40 #define PCI_DEVICE_ID_INTEL_PANTHERPOINT_LPC_MAX 0x1e5f +#define PCI_DEVICE_ID_INTEL_BSW 0x22B7 #define PCI_DEVICE_ID_INTEL_DH89XXCC_LPC_MIN 0x2310 #define PCI_DEVICE_ID_INTEL_DH89XXCC_LPC_MAX 0x231f #define PCI_DEVICE_ID_INTEL_82801AA_0 0x2410 @@ -2891,6 +2897,8 @@ #define PCI_DEVICE_ID_INTEL_84460GX 0x84ea #define PCI_DEVICE_ID_INTEL_IXP4XX 0x8500 #define PCI_DEVICE_ID_INTEL_IXP2800 0x9004 +#define PCI_DEVICE_ID_INTEL_SPTLP 0x9d30 +#define PCI_DEVICE_ID_INTEL_SPTH 0xa130 #define PCI_DEVICE_ID_INTEL_S21152BB 0xb152 #define PCI_VENDOR_ID_SCALEMP 0x8686 diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c index 4285d8f..19ca7f6 100644 --- a/drivers/usb/dwc3/dwc3-pci.c +++ b/drivers/usb/dwc3/dwc3-pci.c @@ -20,19 +20,11 @@ #include <linux/module.h> #include <linux/slab.h> #include <linux/pci.h> +#include <linux/pci_ids.h> #include <linux/platform_device.h> #include "platform_data.h" -/* FIXME define these in <uapi/linux/pci_ids.h> */ -#define PCI_VENDOR_ID_SYNOPSYS 0x16c3 -#define PCI_DEVICE_ID_SYNOPSYS_HAPSUSB3 0xabcd -#define PCI_DEVICE_ID_INTEL_BYT 0x0f37 -#define PCI_DEVICE_ID_INTEL_MRFLD 0x119e -#define PCI_DEVICE_ID_INTEL_BSW 0x22B7 -#define PCI_DEVICE_ID_INTEL_SPTLP 0x9d30 -#define PCI_DEVICE_ID_INTEL_SPTH 0xa130 - static int dwc3_pci_quirks(struct pci_dev *pdev) { if (pdev->vendor == PCI_VENDOR_ID_AMD && -- MST ^ permalink raw reply related [flat|nested] 6+ messages in thread
[parent not found: <1427635734-24786-87-git-send-email-mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]
* Re: [PATCH 86/86] usb/dwc3: move ids to pci_ids.h [not found] ` <1427635734-24786-87-git-send-email-mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> @ 2015-03-29 20:42 ` Greg Kroah-Hartman [not found] ` <20150329204200.GB5902-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org> 0 siblings, 1 reply; 6+ messages in thread From: Greg Kroah-Hartman @ 2015-03-29 20:42 UTC (permalink / raw) To: Michael S. Tsirkin Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA, Felipe Balbi, Bjorn Helgaas, Thomas Gleixner, Andy Shevchenko, Andy Lutomirski, Peter Neubauer, Huang Rui, Jean Delvare, linux-usb-u79uwXL29TY76Z2rM5mHXA, linux-omap-u79uwXL29TY76Z2rM5mHXA, linux-api-u79uwXL29TY76Z2rM5mHXA On Sun, Mar 29, 2015 at 03:43:40PM +0200, Michael S. Tsirkin wrote: > Comment says IDs should move to pci_ids.h, let's do it. No, please remove the comment, it's not needed in pci_ids.h at all. ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <20150329204200.GB5902-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH 86/86] usb/dwc3: move ids to pci_ids.h [not found] ` <20150329204200.GB5902-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org> @ 2015-03-30 6:50 ` Michael S. Tsirkin 2015-03-30 6:58 ` Greg Kroah-Hartman 0 siblings, 1 reply; 6+ messages in thread From: Michael S. Tsirkin @ 2015-03-30 6:50 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA, Felipe Balbi, Bjorn Helgaas, Thomas Gleixner, Andy Shevchenko, Andy Lutomirski, Peter Neubauer, Huang Rui, Jean Delvare, linux-usb-u79uwXL29TY76Z2rM5mHXA, linux-omap-u79uwXL29TY76Z2rM5mHXA, linux-api-u79uwXL29TY76Z2rM5mHXA On Sun, Mar 29, 2015 at 10:42:00PM +0200, Greg Kroah-Hartman wrote: > On Sun, Mar 29, 2015 at 03:43:40PM +0200, Michael S. Tsirkin wrote: > > Comment says IDs should move to pci_ids.h, let's do it. > > No, please remove the comment, it's not needed in pci_ids.h at all. vendor ID does belong in pci_ids.h though, so says Documentation/PCI/pci.txt ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 86/86] usb/dwc3: move ids to pci_ids.h 2015-03-30 6:50 ` Michael S. Tsirkin @ 2015-03-30 6:58 ` Greg Kroah-Hartman [not found] ` <20150330065810.GA10508-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org> 0 siblings, 1 reply; 6+ messages in thread From: Greg Kroah-Hartman @ 2015-03-30 6:58 UTC (permalink / raw) To: Michael S. Tsirkin Cc: linux-kernel, Felipe Balbi, Bjorn Helgaas, Thomas Gleixner, Andy Shevchenko, Andy Lutomirski, Peter Neubauer, Huang Rui, Jean Delvare, linux-usb, linux-omap, linux-api On Mon, Mar 30, 2015 at 08:50:34AM +0200, Michael S. Tsirkin wrote: > On Sun, Mar 29, 2015 at 10:42:00PM +0200, Greg Kroah-Hartman wrote: > > On Sun, Mar 29, 2015 at 03:43:40PM +0200, Michael S. Tsirkin wrote: > > > Comment says IDs should move to pci_ids.h, let's do it. > > > > No, please remove the comment, it's not needed in pci_ids.h at all. > > vendor ID does belong in pci_ids.h though, so says > Documentation/PCI/pci.txt Read the top of pci_ids.h please. ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <20150330065810.GA10508-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH 86/86] usb/dwc3: move ids to pci_ids.h [not found] ` <20150330065810.GA10508-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org> @ 2015-03-30 7:16 ` Michael S. Tsirkin 0 siblings, 0 replies; 6+ messages in thread From: Michael S. Tsirkin @ 2015-03-30 7:16 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA, Felipe Balbi, Bjorn Helgaas, Thomas Gleixner, Andy Shevchenko, Andy Lutomirski, Peter Neubauer, Huang Rui, Jean Delvare, linux-usb-u79uwXL29TY76Z2rM5mHXA, linux-omap-u79uwXL29TY76Z2rM5mHXA, linux-api-u79uwXL29TY76Z2rM5mHXA On Mon, Mar 30, 2015 at 08:58:10AM +0200, Greg Kroah-Hartman wrote: > On Mon, Mar 30, 2015 at 08:50:34AM +0200, Michael S. Tsirkin wrote: > > On Sun, Mar 29, 2015 at 10:42:00PM +0200, Greg Kroah-Hartman wrote: > > > On Sun, Mar 29, 2015 at 03:43:40PM +0200, Michael S. Tsirkin wrote: > > > > Comment says IDs should move to pci_ids.h, let's do it. > > > > > > No, please remove the comment, it's not needed in pci_ids.h at all. > > > > vendor ID does belong in pci_ids.h though, so says > > Documentation/PCI/pci.txt > > Read the top of pci_ids.h please. Thanks for pointing this out, looks like Documentation/PCI/pci.txt should be improved. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-03-30 7:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1427635734-24786-1-git-send-email-mst@redhat.com>
2015-03-29 13:42 ` [PATCH 65/86] usb/dwc3: comment update Michael S. Tsirkin
[not found] ` <1427635734-24786-1-git-send-email-mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-03-29 13:43 ` [PATCH 86/86] usb/dwc3: move ids to pci_ids.h Michael S. Tsirkin
[not found] ` <1427635734-24786-87-git-send-email-mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-03-29 20:42 ` Greg Kroah-Hartman
[not found] ` <20150329204200.GB5902-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-03-30 6:50 ` Michael S. Tsirkin
2015-03-30 6:58 ` Greg Kroah-Hartman
[not found] ` <20150330065810.GA10508-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-03-30 7:16 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox