From: David Brownell <david-b@pacbell.net>
To: "Pillai, Manikandan" <mani.pillai@ti.com>
Cc: "felipe.balbi@nokia.com" <felipe.balbi@nokia.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 1/2] Put in supportframework for PR785 board.
Date: Thu, 4 Dec 2008 09:59:57 -0800 [thread overview]
Message-ID: <200812040959.57532.david-b@pacbell.net> (raw)
In-Reply-To: <19F8576C6E063C45BE387C64729E739403E90E7234@dbde02.ent.ti.com>
On Thursday 04 December 2008, Pillai, Manikandan wrote:
> > > --- a/arch/arm/mach-omap2/mmc-twl4030.c
> > > +++ b/arch/arm/mach-omap2/mmc-twl4030.c
>
> > it doesn't make sense to build this file if you don't have twl4030 in
> > the board. Better to have something like mmc-tps6235x.c or something
> > like that.
>
> [Pillai, Manikandan] This would be provided in a latter patch that
> provides support for MMC1. I have created another file mmc-pr785.c in
> this patch. I am currently testing and shall send it soon.
Note that current plans for mmc-twl4030.c include
converting it to use the regulator framework after
the current stuff get submitted for mainline.
That should be the last remnant of the twl4030-specific
support in that driver glue. Ideally there will be no
need for an mmc-pr785 ... so maybe mmc-twl4030.c should
get renamed (again!) to be generic.
Or better yet, your work for pr785 can produce that
fully genericized version. :)
- Dave
next prev parent reply other threads:[~2008-12-04 17:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-04 10:23 [PATCH 1/2] Put in supportframework for PR785 board Manikandan Pillai
2008-12-04 11:14 ` Felipe Balbi
2008-12-04 11:30 ` Pillai, Manikandan
2008-12-04 11:39 ` Felipe Balbi
2008-12-04 18:00 ` David Brownell
2008-12-04 17:59 ` David Brownell [this message]
2008-12-04 18:10 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812040959.57532.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=felipe.balbi@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=mani.pillai@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox