Re: [PATCH 1/2] Put in supportframework for PR785 board.

[David Brownell <david-b@pacbell.net>]

On Thursday 04 December 2008, Felipe Balbi wrote:
> > > --- a/drivers/mfd/Kconfig
> > > +++ b/drivers/mfd/Kconfig
> > > @@ -61,6 +61,8 @@ config UCB1400_CORE
> > >       To compile this driver as a module, choose M here: the
> > >       module will be called ucb1400_core.
> > >  
> > > +menu "Texas Instruments Power board Support"
> > > +
> > >  config TWL4030_CORE
> > >     bool "Texas Instruments TWL4030/TPS659x0 Support"
> > >     depends on I2C=y && GENERIC_HARDIRQS
> > > @@ -84,6 +86,18 @@ config TWL4030_POWER
> > >       oscillators are switched off or on or reset when a sleep, wakeup
> > >       or warm reset event occurs.
> > >  
> > > +config PR785
> > > +   bool "A Texas Instruments TPS6235X based Power Module"
> > > +   depends on I2C=y && MACH_OMAP3EVM=y && GENERIC_GPIO && (ARCH_OMAP3)
> > > +   default n
> > > +   help
> > > +   Say yes here if you are using the TPS6235x based PR785 Power Module
> > > +   for the EVM boards. This core driver provides register access and IRQ
> > > +   handling facilities, and registers devices for the various functions
> > > +   so that function-specific drivers can bind to them.
> > > +
> > > +endmenu
> > 
> > where's the driver for it ??
> > [Pillai, Manikandan] The PATCH 2/2 contains the driver file. This has only
> > the framework
> 
> so the Kconfig for that driver should be together with the driver.

IMO it'd be better to have this Kconfig go in
the arch/arm/mach-omap2/Kconfig, a direct child
of the OMAP3EVM entry ... the menu tree should be

	... other boards
	omap3evm?
		choice of power boards: 
			TWL4030/original
			PR785
	... other boards

That is, unless/until there's some way to detect
the type of board at runtime.

- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html