From: David Brownell <david-b@pacbell.net>
To: Manikandan Pillai <mani.pillai@ti.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH 1/2] Put in supportframework for PR785 board.
Date: Thu, 4 Dec 2008 10:10:30 -0800 [thread overview]
Message-ID: <200812041010.31226.david-b@pacbell.net> (raw)
In-Reply-To: <1228386206-13513-1-git-send-email-mani.pillai@ti.com>
On Thursday 04 December 2008, Manikandan Pillai wrote:
> +config PR785
> + bool "A Texas Instruments TPS6235X based Power Module"
> + depends on I2C=y && MACH_OMAP3EVM=y && GENERIC_GPIO && (ARCH_OMAP
One more comment about that symbol: as well as living in the
mach-omap2/Kconfig file, it should probably look more like
config OMAP3EVM_PR785
depends on MACH_OMAP3EVM
Having the module isn't a function of I2C, and the other dependencies
are implicit in OMAP3 EVM support. The name "PR785" should be scoped;
in this usage it's specific to that EVM. Another vendor might have a
board with the same name, let's not confuse things. :)
- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2008-12-04 18:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-04 10:23 [PATCH 1/2] Put in supportframework for PR785 board Manikandan Pillai
2008-12-04 11:14 ` Felipe Balbi
2008-12-04 11:30 ` Pillai, Manikandan
2008-12-04 11:39 ` Felipe Balbi
2008-12-04 18:00 ` David Brownell
2008-12-04 17:59 ` David Brownell
2008-12-04 18:10 ` David Brownell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812041010.31226.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=linux-omap@vger.kernel.org \
--cc=mani.pillai@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox