[PATCH RFC] usb: musb: omap: fix the error check for pm_runtime_get_sync

[PATCH RFC] usb: musb: omap: fix the error check for pm_runtime_get_sync

[Shubhrajyoti D]

pm_runtime_get_sync returns a signed integer.In case of errors
it returns a negative value.This patch fixes the error check
by making it signed instead of unsigned thus preventing register
access if get_sync_fails. Also passes the error cause to the
debug message.

Cc:  Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
---
Compile tested only

 drivers/usb/musb/omap2430.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
index 2ae0bb3..e5dd18f 100644
--- a/drivers/usb/musb/omap2430.c
+++ b/drivers/usb/musb/omap2430.c
@@ -282,7 +282,8 @@ static void musb_otg_notifier_work(struct work_struct *data_notifier_work)
 
 static int omap2430_musb_init(struct musb *musb)
 {
-	u32 l, status = 0;
+	u32 l;
+	int status = 0;
 	struct device *dev = musb->controller;
 	struct musb_hdrc_platform_data *plat = dev->platform_data;
 	struct omap_musb_board_data *data = plat->board_data;
@@ -301,7 +302,7 @@ static int omap2430_musb_init(struct musb *musb)
 
 	status = pm_runtime_get_sync(dev);
 	if (status < 0) {
-		dev_err(dev, "pm_runtime_get_sync FAILED");
+		dev_err(dev, "pm_runtime_get_sync FAILED %d \n",status);
 		goto err1;
 	}
 
-- 
1.7.1

Re: [PATCH RFC] usb: musb: omap: fix the error check for pm_runtime_get_sync

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 528 bytes --]

On Thu, Mar 22, 2012 at 12:48:06PM +0530, Shubhrajyoti D wrote:
> pm_runtime_get_sync returns a signed integer.In case of errors
> it returns a negative value.This patch fixes the error check
> by making it signed instead of unsigned thus preventing register
> access if get_sync_fails. Also passes the error cause to the
> debug message.
> 
> Cc:  Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org>
> Signed-off-by: Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org>

applied, thanks

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH RFC] usb: musb: omap: fix the error check for pm_runtime_get_sync

[Sergei Shtylyov]

Hello.

On 22-03-2012 11:18, Shubhrajyoti D wrote:

> pm_runtime_get_sync returns a signed integer.In case of errors
> it returns a negative value.This patch fixes the error check
> by making it signed instead of unsigned thus preventing register
> access if get_sync_fails. Also passes the error cause to the
> debug message.

> Cc:  Kishon Vijay Abraham I<kishon@ti.com>
> Signed-off-by: Shubhrajyoti D<shubhrajyoti@ti.com>
> ---
> Compile tested only

    You haven't run it thru scripts/checkpatch.pl either, I guess?

>   drivers/usb/musb/omap2430.c |    5 +++--
>   1 files changed, 3 insertions(+), 2 deletions(-)

> diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
> index 2ae0bb3..e5dd18f 100644
> --- a/drivers/usb/musb/omap2430.c
> +++ b/drivers/usb/musb/omap2430.c
[...]
> @@ -301,7 +302,7 @@ static int omap2430_musb_init(struct musb *musb)
>
>   	status = pm_runtime_get_sync(dev);
>   	if (status<  0) {
> -		dev_err(dev, "pm_runtime_get_sync FAILED");
> +		dev_err(dev, "pm_runtime_get_sync FAILED %d \n",status);

    If I don't mistake, scripts/checkpatch.pl should warn about unneeded 
spaces before '\n'. And also about missing spaces after commas.

WBR, Sergei

Re: [PATCH RFC] usb: musb: omap: fix the error check for pm_runtime_get_sync

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 1429 bytes --]

On Thu, Mar 22, 2012 at 04:42:21PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 22-03-2012 11:18, Shubhrajyoti D wrote:
> 
> >pm_runtime_get_sync returns a signed integer.In case of errors
> >it returns a negative value.This patch fixes the error check
> >by making it signed instead of unsigned thus preventing register
> >access if get_sync_fails. Also passes the error cause to the
> >debug message.
> 
> >Cc:  Kishon Vijay Abraham I<kishon-l0cyMroinI0@public.gmane.org>
> >Signed-off-by: Shubhrajyoti D<shubhrajyoti-l0cyMroinI0@public.gmane.org>
> >---
> >Compile tested only
> 
>    You haven't run it thru scripts/checkpatch.pl either, I guess?
> 
> >  drivers/usb/musb/omap2430.c |    5 +++--
> >  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> >diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
> >index 2ae0bb3..e5dd18f 100644
> >--- a/drivers/usb/musb/omap2430.c
> >+++ b/drivers/usb/musb/omap2430.c
> [...]
> >@@ -301,7 +302,7 @@ static int omap2430_musb_init(struct musb *musb)
> >
> >  	status = pm_runtime_get_sync(dev);
> >  	if (status<  0) {
> >-		dev_err(dev, "pm_runtime_get_sync FAILED");
> >+		dev_err(dev, "pm_runtime_get_sync FAILED %d \n",status);
> 
>    If I don't mistake, scripts/checkpatch.pl should warn about
> unneeded spaces before '\n'. And also about missing spaces after
> commas.

I fixed in my branch, thanks

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH RFC] usb: musb: omap: fix the error check for pm_runtime_get_sync

[Shubhrajyoti]

>>    You haven't run it thru scripts/checkpatch.pl either, I guess?
>>

Actually modified the patch a little afterwards.
>>>  drivers/usb/musb/omap2430.c |    5 +++--
>>>  1 files changed, 3 insertions(+), 2 deletions(-)
>>> diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
>>> index 2ae0bb3..e5dd18f 100644
>>> --- a/drivers/usb/musb/omap2430.c
>>> +++ b/drivers/usb/musb/omap2430.c
>> [...]
>>> @@ -301,7 +302,7 @@ static int omap2430_musb_init(struct musb *musb)
>>>
>>>  	status = pm_runtime_get_sync(dev);
>>>  	if (status<  0) {
>>> -		dev_err(dev, "pm_runtime_get_sync FAILED");
>>> +		dev_err(dev, "pm_runtime_get_sync FAILED %d \n",status);
>>    If I don't mistake, scripts/checkpatch.pl should warn about
>> unneeded spaces before '\n'. And also about missing spaces after
>> commas.
> I fixed in my branch, thanks
>
Thanks Felipe,
Anyways resent the patch.