From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: gregkh@linuxfoundation.org, tony@atomide.com,
eballetbo@gmail.com, javier@dowhile0.org, b-cousson@ti.com,
balbi@ti.com, linux-arm-kernel@lists.infradead.org,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH 3/5] ARM: OMAP2: MUSB: Specify omap4 has mailbox
Date: Wed, 6 Feb 2013 10:57:13 +0000 [thread overview]
Message-ID: <20130206105713.GF17852@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1360130294-5976-4-git-send-email-kishon@ti.com>
On Wed, Feb 06, 2013 at 11:28:11AM +0530, Kishon Vijay Abraham I wrote:
> Added has_mailbox to the musb platform data to specify that omap uses
> an external mailbox (in control module) to communicate with the musb
> core during device connect and disconnect.
So, I've been through your five patches looking for any other users of
"has_mailbox" and I can find none. You introduce this in this patch,
and you set it. But I don't see anything that uses it.
Write only variables are not useful.
next prev parent reply other threads:[~2013-02-06 10:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 5:58 [PATCH 0/5] ARM: OMAP: arm part of usb patches Kishon Vijay Abraham I
2013-02-06 5:58 ` [PATCH 1/5] ARM: OMAP4: remove control module address space from PHY and OTG Kishon Vijay Abraham I
2013-02-06 5:58 ` [PATCH 2/5] ARM: OMAP: devices: create device for usb part of control module Kishon Vijay Abraham I
2013-02-06 13:01 ` Sergei Shtylyov
2013-02-06 5:58 ` [PATCH 3/5] ARM: OMAP2: MUSB: Specify omap4 has mailbox Kishon Vijay Abraham I
2013-02-06 10:57 ` Russell King - ARM Linux [this message]
2013-02-06 11:03 ` Felipe Balbi
2013-02-06 11:22 ` Felipe Balbi
2013-02-06 11:36 ` Russell King - ARM Linux
2013-02-06 5:58 ` [PATCH 4/5] ARM: OMAP: USB: Add phy binding information Kishon Vijay Abraham I
2013-02-06 5:58 ` [PATCH 5/5] usb: omap_control_usb: fix compile warning Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130206105713.GF17852@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=b-cousson@ti.com \
--cc=balbi@ti.com \
--cc=eballetbo@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=javier@dowhile0.org \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox