Re: [PATCH 3/5] ARM: OMAP2: MUSB: Specify omap4 has mailbox

[Felipe Balbi <balbi@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 1245 bytes --]

Hi,

On Wed, Feb 06, 2013 at 10:57:13AM +0000, Russell King - ARM Linux wrote:
> On Wed, Feb 06, 2013 at 11:28:11AM +0530, Kishon Vijay Abraham I wrote:
> > Added has_mailbox to the musb platform data to specify that omap uses
> > an external mailbox (in control module) to communicate with the musb
> > core during device connect and disconnect.
> 
> So, I've been through your five patches looking for any other users of
> "has_mailbox" and I can find none.  You introduce this in this patch,
> and you set it.  But I don't see anything that uses it.
> 
> Write only variables are not useful.

looking back at what I sent Greg this was probably my fault. When taking
Kishon's patches (in particular $SUBJECT) I removed some of arch/arm/
code and ended up forgetting to add the include file which introduces
has_mailbox.

This means that my lack of attention has introduced a compile break on
Greg's tree. Oh well, s**t happens. In any case, the user is already in
Greg's tree and there's no way Greg will rebase his tree to amend
$SUBJECT there, so it will have to go separately.

I didn't even notice this before because I had the diff in my tree, just
forgot to git add and/or git reset. Too late now

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]