Linux on ARM based TI OMAP SoCs
 help / color / mirror / Atom feed
From: Andreas Kemnade <andreas@kemnade.info>
To: phucduc.bui@gmail.com
Cc: Mark Brown <broonie@kernel.org>, Sen Wang <sen@ti.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Jarkko Nikula <jarkko.nikula@bitmer.com>,
	linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-sound@vger.kernel.org
Subject: Re: [PATCH 09/10] ASoC: ti: omap-twl4030: Use dev_err_probe() for error handling
Date: Tue, 4 Aug 2026 19:27:16 +0200	[thread overview]
Message-ID: <20260804192716.50d277b4@kemnade.info> (raw)
In-Reply-To: <20260714120042.491712-10-phucduc.bui@gmail.com>

On Tue, 14 Jul 2026 19:00:41 +0700
phucduc.bui@gmail.com wrote:

> From: bui duc phuc <phucduc.bui@gmail.com>
> 
> Replace dev_err() with dev_err_probe() when reporting
> devm_snd_soc_register_card() failures. This suppresses
> unnecessary log messages for deferred probe errors.
> 
> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>

Reviewed-by: Andreas Kemnade <andreas@kemnade.info>

> ---
>  sound/soc/ti/omap-twl4030.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/sound/soc/ti/omap-twl4030.c b/sound/soc/ti/omap-twl4030.c
> index 2a80e44035d7..576f4d3615e8 100644
> --- a/sound/soc/ti/omap-twl4030.c
> +++ b/sound/soc/ti/omap-twl4030.c
> @@ -306,11 +306,9 @@ static int omap_twl4030_probe(struct platform_device *pdev)
>  
>  	snd_soc_card_set_drvdata(card, priv);
>  	ret = devm_snd_soc_register_card(&pdev->dev, card);
> -	if (ret) {
> -		dev_err(&pdev->dev, "devm_snd_soc_register_card() failed: %d\n",
> -			ret);
> -		return ret;
> -	}
> +	if (ret)
> +		return dev_err_probe(&pdev->dev, ret,
> +				     "devm_snd_soc_register_card() failed\n");
>  
>  	return 0;
>  }


  reply	other threads:[~2026-08-04 17:27 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-14 12:00 [PATCH 00/10] ASoC: ti: Improve probe error handling phucduc.bui
2026-07-14 12:00 ` [PATCH 01/10] ASoC: ti: ams-delta: Use dev_err_probe() for " phucduc.bui
2026-07-14 12:27   ` Christophe JAILLET
2026-07-14 23:06     ` Bui Duc Phuc
2026-07-14 12:00 ` [PATCH 02/10] ASoC: ti: davinci-evm: " phucduc.bui
2026-07-14 12:27   ` Christophe JAILLET
2026-07-14 12:29   ` Christophe JAILLET
2026-07-14 23:09     ` Bui Duc Phuc
2026-07-14 12:00 ` [PATCH 03/10] ASoC: ti: j721e-evm: Return the original error from card name parsing phucduc.bui
2026-07-14 12:00 ` [PATCH 04/10] ASoC: ti: omap-abe-twl6040: Preserve error code and drop redundant log phucduc.bui
2026-07-14 12:00 ` [PATCH 05/10] ASoC: ti: omap-abe-twl6040: Use dev_err_probe() for error handling phucduc.bui
2026-07-14 12:00 ` [PATCH 06/10] ASoC: ti: omap-dmic: " phucduc.bui
2026-07-14 12:00 ` [PATCH 07/10] ASoC: ti: omap-hdmi: " phucduc.bui
2026-07-14 12:00 ` [PATCH 08/10] ASoC: ti: omap-twl4030: Return the original error code phucduc.bui
2026-08-04 17:35   ` Andreas Kemnade
2026-08-05  3:24     ` Bui Duc Phuc
2026-07-14 12:00 ` [PATCH 09/10] ASoC: ti: omap-twl4030: Use dev_err_probe() for error handling phucduc.bui
2026-08-04 17:27   ` Andreas Kemnade [this message]
2026-07-14 12:00 ` [PATCH 10/10] ASoC: ti: rx51: " phucduc.bui
2026-08-05  7:06 ` [PATCH 00/10] ASoC: ti: Improve probe " Cezary Rojewski
2026-08-05 14:08   ` Bui Duc Phuc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260804192716.50d277b4@kemnade.info \
    --to=andreas@kemnade.info \
    --cc=broonie@kernel.org \
    --cc=jarkko.nikula@bitmer.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=phucduc.bui@gmail.com \
    --cc=sen@ti.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox