Linux on ARM based TI OMAP SoCs
 help / color / mirror / Atom feed
From: Cezary Rojewski <cezary.rojewski@intel.com>
To: <phucduc.bui@gmail.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-sound@vger.kernel.org>,
	Mark Brown <broonie@kernel.org>, Sen Wang <sen@ti.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Jarkko Nikula <jarkko.nikula@bitmer.com>,
	<linux-omap@vger.kernel.org>
Subject: Re: [PATCH 00/10] ASoC: ti: Improve probe error handling
Date: Wed, 5 Aug 2026 09:06:58 +0200	[thread overview]
Message-ID: <99bc4c85-5f5e-42bc-8799-eaa7ef5d1257@intel.com> (raw)
In-Reply-To: <20260714120042.491712-1-phucduc.bui@gmail.com>

On 7/14/2026 2:00 PM, phucduc.bui@gmail.com wrote:

> The changes fall into two categories:
>   1.Replace dev_err() with dev_err_probe() when reporting probe
>     failures. This preserves the original error code while suppressing
>     unnecessary log messages for deferred probe errors.
>   2.Preserve the original error codes returned by helper functions
>     instead of converting them to -ENODEV, and remove redundant error
>     messages where the helper already reports the failure.

> bui duc phuc (10):
>    ASoC: ti: ams-delta: Use dev_err_probe() for error handling
>    ASoC: ti: davinci-evm: Use dev_err_probe() for error handling
>    ASoC: ti: j721e-evm: Return the original error from card name parsing
>    ASoC: ti: omap-abe-twl6040: Preserve error code and drop redundant log
>    ASoC: ti: omap-abe-twl6040: Use dev_err_probe() for error handling
>    ASoC: ti: omap-dmic: Use dev_err_probe() for error handling
>    ASoC: ti: omap-hdmi: Use dev_err_probe() for error handling
>    ASoC: ti: omap-twl4030: Return the original error code
>    ASoC: ti: omap-twl4030: Use dev_err_probe() for error handling
>    ASoC: ti: rx51: Use dev_err_probe() for error handling
If there are no dependencies between the 1) and 2), have all patches 
belonging to 1) lead the series before any 2)s pop up.

Right now you have three outstanding patches in the middle of the set 
that clearly differentiate from "Use dev_err_probe() for error handling" 
pattern like if you are about to hide something.

Which obviously you do not but the impression is there nonetheless.

Kind regards,
Czarek

  parent reply	other threads:[~2026-08-05  7:07 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-14 12:00 [PATCH 00/10] ASoC: ti: Improve probe error handling phucduc.bui
2026-07-14 12:00 ` [PATCH 01/10] ASoC: ti: ams-delta: Use dev_err_probe() for " phucduc.bui
2026-07-14 12:27   ` Christophe JAILLET
2026-07-14 23:06     ` Bui Duc Phuc
2026-07-14 12:00 ` [PATCH 02/10] ASoC: ti: davinci-evm: " phucduc.bui
2026-07-14 12:27   ` Christophe JAILLET
2026-07-14 12:29   ` Christophe JAILLET
2026-07-14 23:09     ` Bui Duc Phuc
2026-07-14 12:00 ` [PATCH 03/10] ASoC: ti: j721e-evm: Return the original error from card name parsing phucduc.bui
2026-07-14 12:00 ` [PATCH 04/10] ASoC: ti: omap-abe-twl6040: Preserve error code and drop redundant log phucduc.bui
2026-07-14 12:00 ` [PATCH 05/10] ASoC: ti: omap-abe-twl6040: Use dev_err_probe() for error handling phucduc.bui
2026-07-14 12:00 ` [PATCH 06/10] ASoC: ti: omap-dmic: " phucduc.bui
2026-07-14 12:00 ` [PATCH 07/10] ASoC: ti: omap-hdmi: " phucduc.bui
2026-07-14 12:00 ` [PATCH 08/10] ASoC: ti: omap-twl4030: Return the original error code phucduc.bui
2026-08-04 17:35   ` Andreas Kemnade
2026-08-05  3:24     ` Bui Duc Phuc
2026-07-14 12:00 ` [PATCH 09/10] ASoC: ti: omap-twl4030: Use dev_err_probe() for error handling phucduc.bui
2026-08-04 17:27   ` Andreas Kemnade
2026-07-14 12:00 ` [PATCH 10/10] ASoC: ti: rx51: " phucduc.bui
2026-08-05  7:06 ` Cezary Rojewski [this message]
2026-08-05 14:08   ` [PATCH 00/10] ASoC: ti: Improve probe " Bui Duc Phuc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=99bc4c85-5f5e-42bc-8799-eaa7ef5d1257@intel.com \
    --to=cezary.rojewski@intel.com \
    --cc=broonie@kernel.org \
    --cc=jarkko.nikula@bitmer.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=phucduc.bui@gmail.com \
    --cc=sen@ti.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox