From: Nishanth Menon <menon.nishanth@gmail.com>
To: "Syed Mohammed, Khasim" <x0khasim@ti.com>,
linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] To enable I2C-2 for 2430 SDP
Date: Tue, 28 Nov 2006 01:06:44 +0530 [thread overview]
Message-ID: <456B3E4C.2060300@gmail.com> (raw)
In-Reply-To: <77C7F7CB1230A74A9D19C0C111E6EDBE01F29AD2@DLEE09.ent.ti.com>
Syed Mohammed, Khasim stated on 11/21/2006 11:31 AM:
> Hi,
>
> The attached patch enables I2C-2 support for 2430 SDP. On 2430SDP
> Triton-2 is connected through I2C bus-2.
>
> Please do let me know if you find any issues with the same.
-
- omap_cfg_reg(J15_24XX_I2C2_SCL);
- omap_cfg_reg(H19_24XX_I2C2_SDA);
+
+ if (!cpu_is_omap2430()){
+ omap_cfg_reg(J15_24XX_I2C2_SCL);
+ omap_cfg_reg(H19_24XX_I2C2_SDA);
+ }
IMHO, Bad idea... do we want to handle this carefully? is this mux
correct for all omap2 devices? it would rather be board specific than
CPU specific.. remember that the line is out on multiple pins.. this
might be a bad idea for using the silicon for other boards with a
different pin out...how about muxing it only for h4?? that sounds more
proper here... we assume at this point that all muxing was done in uboot
for 2430?? or should we not be doing it explicitly here??
Regards,
Nishanth menon
next prev parent reply other threads:[~2006-11-27 19:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-21 6:01 [PATCH] To enable I2C-2 for 2430 SDP Syed Mohammed, Khasim
2006-11-27 19:36 ` Nishanth Menon [this message]
2006-11-27 20:08 ` Syed Mohammed, Khasim
2006-11-28 2:23 ` Tony Lindgren
2006-11-28 4:11 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=456B3E4C.2060300@gmail.com \
--to=menon.nishanth@gmail.com \
--cc=linux-omap-open-source@linux.omap.com \
--cc=x0khasim@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox