[PATCH] To enable I2C-2 for 2430 SDP

[PATCH] To enable I2C-2 for 2430 SDP

[Syed Mohammed, Khasim]

[-- Attachment #1: Type: text/plain, Size: 210 bytes --]

Hi,

The attached patch enables I2C-2 support for 2430 SDP. On 2430SDP
Triton-2 is connected through I2C bus-2.

Please do let me know if you find any issues with the same.

Thanks & Regards,
Khasim


[-- Attachment #2: 2430I2C2_mach-omap2.patch --]
[-- Type: application/octet-stream, Size: 1016 bytes --]

This patch enables I2C-2 support for 2430 SDP.

Signed-off-by: Syed Mohammed Khasim  <x0khasim@ti.com>

Files Changed:
 devices.c |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)

=============================================================================
diff -purN linux-omap/arch/arm/mach-omap2/devices.c my_linux_devpt/arch/arm/mach-omap2/devices.c
--- linux-omap/arch/arm/mach-omap2/devices.c	2006-11-20 21:54:01.000000000 -0600
+++ my_linux_devpt/arch/arm/mach-omap2/devices.c	2006-11-20 23:11:56.000000000 -0600
@@ -52,11 +52,13 @@ static struct platform_device omap_i2c_d
 static void omap_init_i2c(void)
 {
 	/* REVISIT: Second I2C not in use on H4? */
-	if (machine_is_omap_h4() || machine_is_omap_2430sdp())
+	if (machine_is_omap_h4())
 		return;
-
-	omap_cfg_reg(J15_24XX_I2C2_SCL);
-	omap_cfg_reg(H19_24XX_I2C2_SDA);
+	
+	if (!cpu_is_omap2430()){
+		omap_cfg_reg(J15_24XX_I2C2_SCL);
+		omap_cfg_reg(H19_24XX_I2C2_SDA);
+	}
 	(void) platform_device_register(&omap_i2c_device2);
 }
 

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]

Re: [PATCH] To enable I2C-2 for 2430 SDP

[Nishanth Menon]

Syed Mohammed, Khasim stated on 11/21/2006 11:31 AM:
> Hi,
> 
> The attached patch enables I2C-2 support for 2430 SDP. On 2430SDP
> Triton-2 is connected through I2C bus-2.
> 
> Please do let me know if you find any issues with the same.


-
-	omap_cfg_reg(J15_24XX_I2C2_SCL);
-	omap_cfg_reg(H19_24XX_I2C2_SDA);
+	
+	if (!cpu_is_omap2430()){
+		omap_cfg_reg(J15_24XX_I2C2_SCL);
+		omap_cfg_reg(H19_24XX_I2C2_SDA);
+	}

IMHO, Bad idea... do we want to handle this carefully? is this mux
correct for all omap2 devices? it would rather be board specific than
CPU specific.. remember that the line is out on multiple pins.. this
might be a bad idea for using the silicon for other boards with a
different pin out...how about muxing it only for h4?? that sounds more
proper here... we assume at this point that all muxing was done in uboot
for 2430?? or should we not be doing it explicitly here??

Regards,
Nishanth menon

RE: [PATCH] To enable I2C-2 for 2430 SDP

[Syed Mohammed, Khasim]

My logic was to keep the existing implementation as is. I don't know if
other boards were using this too (can't be). I wanted to isolate 2430
with other OMAP2 boards (if any). If H4 is the only user, then we can
put "machine_is_omap_h4" instead of "cpu_is_omap2430"

Regards,
Khasim

-----Original Message-----
From: Nishanth Menon [mailto:menon.nishanth@gmail.com] 
Sent: Monday, November 27, 2006 1:37 PM
To: Syed Mohammed, Khasim; linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] To enable I2C-2 for 2430 SDP

Syed Mohammed, Khasim stated on 11/21/2006 11:31 AM:
> Hi,
> 
> The attached patch enables I2C-2 support for 2430 SDP. On 2430SDP
> Triton-2 is connected through I2C bus-2.
> 
> Please do let me know if you find any issues with the same.


-
-	omap_cfg_reg(J15_24XX_I2C2_SCL);
-	omap_cfg_reg(H19_24XX_I2C2_SDA);
+	
+	if (!cpu_is_omap2430()){
+		omap_cfg_reg(J15_24XX_I2C2_SCL);
+		omap_cfg_reg(H19_24XX_I2C2_SDA);
+	}

IMHO, Bad idea... do we want to handle this carefully? is this mux
correct for all omap2 devices? it would rather be board specific than
CPU specific.. remember that the line is out on multiple pins.. this
might be a bad idea for using the silicon for other boards with a
different pin out...how about muxing it only for h4?? that sounds more
proper here... we assume at this point that all muxing was done in uboot
for 2430?? or should we not be doing it explicitly here??

Regards,
Nishanth menon

Re: [PATCH] To enable I2C-2 for 2430 SDP

[Tony Lindgren]

* Syed Mohammed, Khasim <x0khasim@ti.com> [061127 20:10]:
> My logic was to keep the existing implementation as is. I don't know if
> other boards were using this too (can't be). I wanted to isolate 2430
> with other OMAP2 boards (if any). If H4 is the only user, then we can
> put "machine_is_omap_h4" instead of "cpu_is_omap2430"

Yeah I guess in some cases it could be board specific config not to use
I2C. Pushing this patch as we were already doing the muxing :)

Regards,

Tony

Re: [PATCH] To enable I2C-2 for 2430 SDP

[David Brownell]

On H4, J15 is used for the TUSB 6010 EVM, either for the chip IRQ or
the DMA request (depending on cpu board version), instead of I2C2_SCL.

Eventually there should be a way to configure whether a given board
uses I2C1, I2C2, or both.

- Dave