* [PATCH] ARM: OMAP: USB: fix the pointer type mismatch compilation warning
@ 2012-03-05 11:19 Keshava Munegowda
[not found] ` <1330946376-17672-1-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Keshava Munegowda @ 2012-03-05 11:19 UTC (permalink / raw)
To: linux-omap, linux-usb
Cc: Keshava Munegowda, balbi, parthab, govindraj.raja, paul,
b-cousson, Keshava Munegowda
From: Keshava Munegowda <Keshava_mgowda@ti.com>
The compilation of usb-host.c file was resulting compilation warning
due to pointer type mismatch in assignment of return pointer type
of the function omap_device_build_ss to local pointer type.
This warning is fixed.
Signed-off-by: Keshava Munegowda <keshava_mgowda@ti.com>
---
arch/arm/mach-omap2/usb-host.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/usb-host.c b/arch/arm/mach-omap2/usb-host.c
index 771dc78..88d4a19 100644
--- a/arch/arm/mach-omap2/usb-host.c
+++ b/arch/arm/mach-omap2/usb-host.c
@@ -486,7 +486,7 @@ static void setup_4430ohci_io_mux(const enum usbhs_omap_port_mode *port_mode)
void __init usbhs_init(const struct usbhs_omap_board_data *pdata)
{
struct omap_hwmod *oh[2];
- struct omap_device *od;
+ struct platform_device *od;
int bus_id = -1;
int i;
--
1.6.0.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: OMAP: USB: fix the pointer type mismatch compilation warning
[not found] ` <1330946376-17672-1-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>
@ 2012-03-05 11:23 ` Govindraj
2012-03-05 11:36 ` Munegowda, Keshava
2012-03-05 11:43 ` Sergei Shtylyov
1 sibling, 1 reply; 5+ messages in thread
From: Govindraj @ 2012-03-05 11:23 UTC (permalink / raw)
To: Keshava Munegowda
Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA,
linux-usb-u79uwXL29TY76Z2rM5mHXA, balbi-l0cyMroinI0,
parthab-PpE0FKYn9XJWk0Htik3J/w, govindraj.raja-l0cyMroinI0,
paul-DWxLp4Yu+b8AvxtiuMwx3w, b-cousson-l0cyMroinI0
On Mon, Mar 5, 2012 at 4:49 PM, Keshava Munegowda <keshava_mgowda-Bv2c3lPp1Ag@public.gmane.orgm> wrote:
> From: Keshava Munegowda <Keshava_mgowda-l0cyMroinI0@public.gmane.org>
>
> The compilation of usb-host.c file was resulting compilation warning
> due to pointer type mismatch in assignment of return pointer type
> of the function omap_device_build_ss to local pointer type.
> This warning is fixed.
Its fixed already.
https://lkml.org/lkml/2012/2/14/73
>
> Signed-off-by: Keshava Munegowda <keshava_mgowda-l0cyMroinI0@public.gmane.org>
> ---
> arch/arm/mach-omap2/usb-host.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/usb-host.c b/arch/arm/mach-omap2/usb-host.c
> index 771dc78..88d4a19 100644
> --- a/arch/arm/mach-omap2/usb-host.c
> +++ b/arch/arm/mach-omap2/usb-host.c
> @@ -486,7 +486,7 @@ static void setup_4430ohci_io_mux(const enum usbhs_omap_port_mode *port_mode)
> void __init usbhs_init(const struct usbhs_omap_board_data *pdata)
> {
> struct omap_hwmod *oh[2];
> - struct omap_device *od;
> + struct platform_device *od;
> int bus_id = -1;
> int i;
>
> --
> 1.6.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: OMAP: USB: fix the pointer type mismatch compilation warning
2012-03-05 11:23 ` Govindraj
@ 2012-03-05 11:36 ` Munegowda, Keshava
0 siblings, 0 replies; 5+ messages in thread
From: Munegowda, Keshava @ 2012-03-05 11:36 UTC (permalink / raw)
To: Govindraj
Cc: linux-omap, linux-usb, balbi, parthab, govindraj.raja, paul,
b-cousson
On Mon, Mar 5, 2012 at 4:53 PM, Govindraj <govindraj.ti@gmail.com> wrote:
> On Mon, Mar 5, 2012 at 4:49 PM, Keshava Munegowda <keshava_mgowda@ti.com> wrote:
>> From: Keshava Munegowda <Keshava_mgowda@ti.com>
>>
>> The compilation of usb-host.c file was resulting compilation warning
>> due to pointer type mismatch in assignment of return pointer type
>> of the function omap_device_build_ss to local pointer type.
>> This warning is fixed.
>
> Its fixed already.
>
> https://lkml.org/lkml/2012/2/14/73
Thanks ; it by Felipe :)
regards
keshava
>
>>
>> Signed-off-by: Keshava Munegowda <keshava_mgowda@ti.com>
>> ---
>> arch/arm/mach-omap2/usb-host.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/usb-host.c b/arch/arm/mach-omap2/usb-host.c
>> index 771dc78..88d4a19 100644
>> --- a/arch/arm/mach-omap2/usb-host.c
>> +++ b/arch/arm/mach-omap2/usb-host.c
>> @@ -486,7 +486,7 @@ static void setup_4430ohci_io_mux(const enum usbhs_omap_port_mode *port_mode)
>> void __init usbhs_init(const struct usbhs_omap_board_data *pdata)
>> {
>> struct omap_hwmod *oh[2];
>> - struct omap_device *od;
>> + struct platform_device *od;
>> int bus_id = -1;
>> int i;
>>
>> --
>> 1.6.0.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: OMAP: USB: fix the pointer type mismatch compilation warning
[not found] ` <1330946376-17672-1-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>
2012-03-05 11:23 ` Govindraj
@ 2012-03-05 11:43 ` Sergei Shtylyov
[not found] ` <4F54A6E6.6070409-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
1 sibling, 1 reply; 5+ messages in thread
From: Sergei Shtylyov @ 2012-03-05 11:43 UTC (permalink / raw)
To: Keshava Munegowda
Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA,
linux-usb-u79uwXL29TY76Z2rM5mHXA, balbi-l0cyMroinI0,
parthab-PpE0FKYn9XJWk0Htik3J/w, govindraj.raja-l0cyMroinI0,
paul-DWxLp4Yu+b8AvxtiuMwx3w, b-cousson-l0cyMroinI0
Hello.
On 05-03-2012 15:19, Keshava Munegowda wrote:
> From: Keshava Munegowda<Keshava_mgowda-l0cyMroinI0@public.gmane.org>
> The compilation of usb-host.c file was resulting compilation warning
> due to pointer type mismatch in assignment of return pointer type
> of the function omap_device_build_ss to local pointer type.
> This warning is fixed.
> Signed-off-by: Keshava Munegowda<keshava_mgowda-l0cyMroinI0@public.gmane.org>
> ---
> arch/arm/mach-omap2/usb-host.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> diff --git a/arch/arm/mach-omap2/usb-host.c b/arch/arm/mach-omap2/usb-host.c
> index 771dc78..88d4a19 100644
> --- a/arch/arm/mach-omap2/usb-host.c
> +++ b/arch/arm/mach-omap2/usb-host.c
> @@ -486,7 +486,7 @@ static void setup_4430ohci_io_mux(const enum usbhs_omap_port_mode *port_mode)
> void __init usbhs_init(const struct usbhs_omap_board_data *pdata)
> {
> struct omap_hwmod *oh[2];
> - struct omap_device *od;
> + struct platform_device *od;
Makes sense to rename variable to 'pd' then.
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: OMAP: USB: fix the pointer type mismatch compilation warning
[not found] ` <4F54A6E6.6070409-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
@ 2012-03-05 13:36 ` Munegowda, Keshava
0 siblings, 0 replies; 5+ messages in thread
From: Munegowda, Keshava @ 2012-03-05 13:36 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA,
linux-usb-u79uwXL29TY76Z2rM5mHXA, balbi-l0cyMroinI0,
parthab-PpE0FKYn9XJWk0Htik3J/w, govindraj.raja-l0cyMroinI0,
paul-DWxLp4Yu+b8AvxtiuMwx3w, b-cousson-l0cyMroinI0
On Mon, Mar 5, 2012 at 5:13 PM, Sergei Shtylyov <sshtylyov-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org> wrote:
> Hello.
>
>
> On 05-03-2012 15:19, Keshava Munegowda wrote:
>
>> From: Keshava Munegowda<Keshava_mgowda-l0cyMroinI0@public.gmane.org>
>
>
>> The compilation of usb-host.c file was resulting compilation warning
>> due to pointer type mismatch in assignment of return pointer type
>> of the function omap_device_build_ss to local pointer type.
>> This warning is fixed.
>
>
>> Signed-off-by: Keshava Munegowda<keshava_mgowda-l0cyMroinI0@public.gmane.org>
>> ---
>> arch/arm/mach-omap2/usb-host.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>
>> diff --git a/arch/arm/mach-omap2/usb-host.c
>> b/arch/arm/mach-omap2/usb-host.c
>> index 771dc78..88d4a19 100644
>> --- a/arch/arm/mach-omap2/usb-host.c
>> +++ b/arch/arm/mach-omap2/usb-host.c
>> @@ -486,7 +486,7 @@ static void setup_4430ohci_io_mux(const enum
>> usbhs_omap_port_mode *port_mode)
>> void __init usbhs_init(const struct usbhs_omap_board_data *pdata)
>> {
>> struct omap_hwmod *oh[2];
>> - struct omap_device *od;
>> + struct platform_device *od;
>
>
> Makes sense to rename variable to 'pd' then.
>
> WBR, Sergei
ya, and its already in mainline :)
regards
keshava
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-03-05 13:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-05 11:19 [PATCH] ARM: OMAP: USB: fix the pointer type mismatch compilation warning Keshava Munegowda
[not found] ` <1330946376-17672-1-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>
2012-03-05 11:23 ` Govindraj
2012-03-05 11:36 ` Munegowda, Keshava
2012-03-05 11:43 ` Sergei Shtylyov
[not found] ` <4F54A6E6.6070409-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
2012-03-05 13:36 ` Munegowda, Keshava
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox