[PATCH] ARM: OMAP: USB: fix the pointer type mismatch compilation warning

[PATCH] ARM: OMAP: USB: fix the pointer type mismatch compilation warning

[Keshava Munegowda]

From: Keshava Munegowda <Keshava_mgowda@ti.com>

The compilation of usb-host.c file was resulting compilation warning
due to pointer type mismatch in assignment of return pointer type
of the function omap_device_build_ss to local pointer type.
This warning is fixed.

Signed-off-by: Keshava Munegowda <keshava_mgowda@ti.com>
---
 arch/arm/mach-omap2/usb-host.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/usb-host.c b/arch/arm/mach-omap2/usb-host.c
index 771dc78..88d4a19 100644
--- a/arch/arm/mach-omap2/usb-host.c
+++ b/arch/arm/mach-omap2/usb-host.c
@@ -486,7 +486,7 @@ static void setup_4430ohci_io_mux(const enum usbhs_omap_port_mode *port_mode)
 void __init usbhs_init(const struct usbhs_omap_board_data *pdata)
 {
 	struct omap_hwmod	*oh[2];
-	struct omap_device	*od;
+	struct platform_device	*od;
 	int			bus_id = -1;
 	int			i;
 
-- 
1.6.0.4

Re: [PATCH] ARM: OMAP: USB: fix the pointer type mismatch compilation warning

[Govindraj]

On Mon, Mar 5, 2012 at 4:49 PM, Keshava Munegowda <keshava_mgowda-Bv2c3lPp1Ag@public.gmane.orgm> wrote:
> From: Keshava Munegowda <Keshava_mgowda-l0cyMroinI0@public.gmane.org>
>
> The compilation of usb-host.c file was resulting compilation warning
> due to pointer type mismatch in assignment of return pointer type
> of the function omap_device_build_ss to local pointer type.
> This warning is fixed.

Its fixed already.

https://lkml.org/lkml/2012/2/14/73

>
> Signed-off-by: Keshava Munegowda <keshava_mgowda-l0cyMroinI0@public.gmane.org>
> ---
>  arch/arm/mach-omap2/usb-host.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/usb-host.c b/arch/arm/mach-omap2/usb-host.c
> index 771dc78..88d4a19 100644
> --- a/arch/arm/mach-omap2/usb-host.c
> +++ b/arch/arm/mach-omap2/usb-host.c
> @@ -486,7 +486,7 @@ static void setup_4430ohci_io_mux(const enum usbhs_omap_port_mode *port_mode)
>  void __init usbhs_init(const struct usbhs_omap_board_data *pdata)
>  {
>        struct omap_hwmod       *oh[2];
> -       struct omap_device      *od;
> +       struct platform_device  *od;
>        int                     bus_id = -1;
>        int                     i;
>
> --
> 1.6.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: OMAP: USB: fix the pointer type mismatch compilation warning

[Munegowda, Keshava]

On Mon, Mar 5, 2012 at 4:53 PM, Govindraj <govindraj.ti@gmail.com> wrote:
> On Mon, Mar 5, 2012 at 4:49 PM, Keshava Munegowda <keshava_mgowda@ti.com> wrote:
>> From: Keshava Munegowda <Keshava_mgowda@ti.com>
>>
>> The compilation of usb-host.c file was resulting compilation warning
>> due to pointer type mismatch in assignment of return pointer type
>> of the function omap_device_build_ss to local pointer type.
>> This warning is fixed.
>
> Its fixed already.
>
> https://lkml.org/lkml/2012/2/14/73

Thanks ;  it by Felipe :)

regards
keshava


>
>>
>> Signed-off-by: Keshava Munegowda <keshava_mgowda@ti.com>
>> ---
>>  arch/arm/mach-omap2/usb-host.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/usb-host.c b/arch/arm/mach-omap2/usb-host.c
>> index 771dc78..88d4a19 100644
>> --- a/arch/arm/mach-omap2/usb-host.c
>> +++ b/arch/arm/mach-omap2/usb-host.c
>> @@ -486,7 +486,7 @@ static void setup_4430ohci_io_mux(const enum usbhs_omap_port_mode *port_mode)
>>  void __init usbhs_init(const struct usbhs_omap_board_data *pdata)
>>  {
>>        struct omap_hwmod       *oh[2];
>> -       struct omap_device      *od;
>> +       struct platform_device  *od;
>>        int                     bus_id = -1;
>>        int                     i;
>>
>> --
>> 1.6.0.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: OMAP: USB: fix the pointer type mismatch compilation warning

[Sergei Shtylyov]

Hello.

On 05-03-2012 15:19, Keshava Munegowda wrote:

> From: Keshava Munegowda<Keshava_mgowda-l0cyMroinI0@public.gmane.org>

> The compilation of usb-host.c file was resulting compilation warning
> due to pointer type mismatch in assignment of return pointer type
> of the function omap_device_build_ss to local pointer type.
> This warning is fixed.

> Signed-off-by: Keshava Munegowda<keshava_mgowda-l0cyMroinI0@public.gmane.org>
> ---
>   arch/arm/mach-omap2/usb-host.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)

> diff --git a/arch/arm/mach-omap2/usb-host.c b/arch/arm/mach-omap2/usb-host.c
> index 771dc78..88d4a19 100644
> --- a/arch/arm/mach-omap2/usb-host.c
> +++ b/arch/arm/mach-omap2/usb-host.c
> @@ -486,7 +486,7 @@ static void setup_4430ohci_io_mux(const enum usbhs_omap_port_mode *port_mode)
>   void __init usbhs_init(const struct usbhs_omap_board_data *pdata)
>   {
>   	struct omap_hwmod	*oh[2];
> -	struct omap_device	*od;
> +	struct platform_device	*od;

    Makes sense to rename variable to 'pd' then.

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: OMAP: USB: fix the pointer type mismatch compilation warning

[Munegowda, Keshava]

On Mon, Mar 5, 2012 at 5:13 PM, Sergei Shtylyov <sshtylyov-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org> wrote:
> Hello.
>
>
> On 05-03-2012 15:19, Keshava Munegowda wrote:
>
>> From: Keshava Munegowda<Keshava_mgowda-l0cyMroinI0@public.gmane.org>
>
>
>> The compilation of usb-host.c file was resulting compilation warning
>> due to pointer type mismatch in assignment of return pointer type
>> of the function omap_device_build_ss to local pointer type.
>> This warning is fixed.
>
>
>> Signed-off-by: Keshava Munegowda<keshava_mgowda-l0cyMroinI0@public.gmane.org>
>> ---
>>  arch/arm/mach-omap2/usb-host.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>
>
>> diff --git a/arch/arm/mach-omap2/usb-host.c
>> b/arch/arm/mach-omap2/usb-host.c
>> index 771dc78..88d4a19 100644
>> --- a/arch/arm/mach-omap2/usb-host.c
>> +++ b/arch/arm/mach-omap2/usb-host.c
>> @@ -486,7 +486,7 @@ static void setup_4430ohci_io_mux(const enum
>> usbhs_omap_port_mode *port_mode)
>>  void __init usbhs_init(const struct usbhs_omap_board_data *pdata)
>>  {
>>        struct omap_hwmod       *oh[2];
>> -       struct omap_device      *od;
>> +       struct platform_device  *od;
>
>
>   Makes sense to rename variable to 'pd' then.
>
> WBR, Sergei

ya, and its already in mainline :)

regards
keshava
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html