* [PATCH 00/51] video: fbdev: Convert to platform remove callback returning void
@ 2023-03-18 23:53 Uwe Kleine-König
2023-03-18 23:54 ` [PATCH 30/51] video: fbdev: omapfb: " Uwe Kleine-König
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Uwe Kleine-König @ 2023-03-18 23:53 UTC (permalink / raw)
To: Helge Deller, Yihao Han, Jaya Kumar, Javier Martinez Canillas,
Thomas Zimmermann, Wolfram Sang, Alexander Shiyan, Dongliang Mu,
Peter Jones, Gaosheng Cui, Timur Tabi, Xuezhi Zhang,
Jiasheng Jiang, Ferenc Bakonyi, Sascha Hauer, Shawn Guo,
Christophe Leroy, Stephen Kitt, Daniel Thompson, Mark Brown,
Rob Herring, Bartlomiej Zolnierkiewicz, Arnd Bergmann,
Tony Lindgren, Jiapeng Chong, Yu Zhe, Xu Panda, Zhang Qilong,
Hyunwoo Kim, Yang Yingliang, Robert Jarzmik, Ulf Hansson,
wangkailong@jari.cn, Wang Qing, Kristoffer Ericson, Jingoo Han,
ye xingchen, Geert Uytterhoeven, Hans de Goede,
Michal Januszewski, Daniel Vetter, Zeng Heng,
Florian Tobias Schandinat, Michal Simek
Cc: linux-fbdev, dri-devel, kernel, linux-arm-kernel, linux-nvidia,
Fabio Estevam, NXP Linux Team, linux-omap
Hello,
this series adapts the platform drivers below drivers/video/fbdev to use the
.remove_new() callback. Compared to the traditional .remove() callback
.remove_new() returns no value. This is a good thing because the driver core
doesn't (and cannot) cope for errors during remove. The only effect of a
non-zero return value in .remove() is that the driver core emits a warning. The
device is removed anyhow and an early return from .remove() usually yields a
resource leak.
By changing the remove callback to return void driver authors cannot
reasonably assume any more that there is some kind of cleanup later.
The first patch simplifies the remove callback of one driver to obviously
always return zero. After that all drivers are converted trivially to
.remove_new().
Best regards
Uwe
Uwe Kleine-König (51):
video: fbdev: au1100fb: Drop if with an always false condition
video: fbdev: arcfb: Convert to platform remove callback returning
void
video: fbdev: au1100fb: Convert to platform remove callback returning
void
video: fbdev: au1200fb: Convert to platform remove callback returning
void
video: fbdev: broadsheetfb: Convert to platform remove callback
returning void
video: fbdev: bw2: Convert to platform remove callback returning void
video: fbdev: cg14: Convert to platform remove callback returning void
video: fbdev: cg3: Convert to platform remove callback returning void
video: fbdev: cg6: Convert to platform remove callback returning void
video: fbdev: clps711x-fb: Convert to platform remove callback
returning void
video: fbdev: cobalt_lcdfb: Convert to platform remove callback
returning void
video: fbdev: da8xx-fb: Convert to platform remove callback returning
void
video: fbdev: efifb: Convert to platform remove callback returning
void
video: fbdev: ep93xx-fb: Convert to platform remove callback returning
void
video: fbdev: ffb: Convert to platform remove callback returning void
video: fbdev: fsl-diu-fb: Convert to platform remove callback
returning void
video: fbdev: gbefb: Convert to platform remove callback returning
void
video: fbdev: goldfishfb: Convert to platform remove callback
returning void
video: fbdev: grvga: Convert to platform remove callback returning
void
video: fbdev: hecubafb: Convert to platform remove callback returning
void
video: fbdev: hgafb: Convert to platform remove callback returning
void
video: fbdev: hitfb: Convert to platform remove callback returning
void
video: fbdev: imxfb: Convert to platform remove callback returning
void
video: fbdev: leo: Convert to platform remove callback returning void
video: fbdev: mb862xx: Convert to platform remove callback returning
void
video: fbdev: metronomefb: Convert to platform remove callback
returning void
video: fbdev: mx3fb: Convert to platform remove callback returning
void
video: fbdev: ocfb: Convert to platform remove callback returning void
video: fbdev: offb: Convert to platform remove callback returning void
video: fbdev: omapfb: Convert to platform remove callback returning
void
video: fbdev: p9100: Convert to platform remove callback returning
void
video: fbdev: platinumfb: Convert to platform remove callback
returning void
video: fbdev: pxa168fb: Convert to platform remove callback returning
void
video: fbdev: pxa3xx-gcu: Convert to platform remove callback
returning void
video: fbdev: pxafb: Convert to platform remove callback returning
void
video: fbdev: s1d13xxxfb: Convert to platform remove callback
returning void
video: fbdev: s3c-fb: Convert to platform remove callback returning
void
video: fbdev: sh7760fb: Convert to platform remove callback returning
void
video: fbdev: sh_mobile_lcdcfb: Convert to platform remove callback
returning void
video: fbdev: simplefb: Convert to platform remove callback returning
void
video: fbdev: sm501fb: Convert to platform remove callback returning
void
video: fbdev: tcx: Convert to platform remove callback returning void
video: fbdev: uvesafb: Convert to platform remove callback returning
void
video: fbdev: vesafb: Convert to platform remove callback returning
void
video: fbdev: vfb: Convert to platform remove callback returning void
video: fbdev: vga16fb: Convert to platform remove callback returning
void
video: fbdev: via: Convert to platform remove callback returning void
video: fbdev: vt8500lcdfb: Convert to platform remove callback
returning void
video: fbdev: wm8505fb: Convert to platform remove callback returning
void
video: fbdev: wmt_ge_rops: Convert to platform remove callback
returning void
video: fbdev: xilinxfb: Convert to platform remove callback returning
void
drivers/video/fbdev/arcfb.c | 5 ++---
drivers/video/fbdev/au1100fb.c | 11 +++--------
drivers/video/fbdev/au1200fb.c | 6 ++----
drivers/video/fbdev/broadsheetfb.c | 5 ++---
drivers/video/fbdev/bw2.c | 6 ++----
drivers/video/fbdev/cg14.c | 6 ++----
drivers/video/fbdev/cg3.c | 6 ++----
drivers/video/fbdev/cg6.c | 6 ++----
drivers/video/fbdev/clps711x-fb.c | 6 ++----
drivers/video/fbdev/cobalt_lcdfb.c | 6 ++----
drivers/video/fbdev/da8xx-fb.c | 6 ++----
drivers/video/fbdev/efifb.c | 6 ++----
drivers/video/fbdev/ep93xx-fb.c | 6 ++----
drivers/video/fbdev/ffb.c | 6 ++----
drivers/video/fbdev/fsl-diu-fb.c | 6 ++----
drivers/video/fbdev/gbefb.c | 6 ++----
drivers/video/fbdev/goldfishfb.c | 5 ++---
drivers/video/fbdev/grvga.c | 6 ++----
drivers/video/fbdev/hecubafb.c | 5 ++---
drivers/video/fbdev/hgafb.c | 6 ++----
drivers/video/fbdev/hitfb.c | 6 ++----
drivers/video/fbdev/imxfb.c | 6 ++----
drivers/video/fbdev/leo.c | 6 ++----
drivers/video/fbdev/mb862xx/mb862xxfbdrv.c | 5 ++---
drivers/video/fbdev/metronomefb.c | 5 ++---
drivers/video/fbdev/mx3fb.c | 5 ++---
drivers/video/fbdev/ocfb.c | 6 ++----
drivers/video/fbdev/offb.c | 8 +++-----
drivers/video/fbdev/omap/omapfb_main.c | 6 ++----
drivers/video/fbdev/omap2/omapfb/dss/core.c | 6 ++----
drivers/video/fbdev/omap2/omapfb/dss/dispc.c | 5 ++---
drivers/video/fbdev/omap2/omapfb/dss/dpi.c | 5 ++---
drivers/video/fbdev/omap2/omapfb/dss/dsi.c | 5 ++---
drivers/video/fbdev/omap2/omapfb/dss/dss.c | 5 ++---
drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c | 5 ++---
drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c | 5 ++---
drivers/video/fbdev/omap2/omapfb/dss/sdi.c | 5 ++---
drivers/video/fbdev/omap2/omapfb/dss/venc.c | 5 ++---
drivers/video/fbdev/omap2/omapfb/omapfb-main.c | 6 ++----
drivers/video/fbdev/p9100.c | 6 ++----
drivers/video/fbdev/platinumfb.c | 6 ++----
drivers/video/fbdev/pxa168fb.c | 8 +++-----
drivers/video/fbdev/pxa3xx-gcu.c | 6 ++----
drivers/video/fbdev/pxafb.c | 8 +++-----
drivers/video/fbdev/s1d13xxxfb.c | 5 ++---
drivers/video/fbdev/s3c-fb.c | 6 ++----
drivers/video/fbdev/sh7760fb.c | 6 ++----
drivers/video/fbdev/sh_mobile_lcdcfb.c | 5 ++---
drivers/video/fbdev/simplefb.c | 6 ++----
drivers/video/fbdev/sm501fb.c | 6 ++----
drivers/video/fbdev/tcx.c | 6 ++----
drivers/video/fbdev/uvesafb.c | 6 ++----
drivers/video/fbdev/vesafb.c | 6 ++----
drivers/video/fbdev/vfb.c | 5 ++---
drivers/video/fbdev/vga16fb.c | 6 ++----
drivers/video/fbdev/via/via-gpio.c | 5 ++---
drivers/video/fbdev/via/via_i2c.c | 5 ++---
drivers/video/fbdev/vt8500lcdfb.c | 6 ++----
drivers/video/fbdev/wm8505fb.c | 6 ++----
drivers/video/fbdev/wmt_ge_rops.c | 5 ++---
drivers/video/fbdev/xilinxfb.c | 6 ++----
61 files changed, 126 insertions(+), 230 deletions(-)
base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6
--
2.39.2
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 30/51] video: fbdev: omapfb: Convert to platform remove callback returning void
2023-03-18 23:53 [PATCH 00/51] video: fbdev: Convert to platform remove callback returning void Uwe Kleine-König
@ 2023-03-18 23:54 ` Uwe Kleine-König
2023-03-19 18:04 ` [PATCH 00/51] video: fbdev: " Helge Deller
2023-03-20 10:03 ` Thomas Zimmermann
2 siblings, 0 replies; 10+ messages in thread
From: Uwe Kleine-König @ 2023-03-18 23:54 UTC (permalink / raw)
To: Helge Deller, Bartlomiej Zolnierkiewicz, Arnd Bergmann,
Tony Lindgren, Jiapeng Chong, Yu Zhe, Xu Panda, Zhang Qilong,
Wolfram Sang
Cc: linux-fbdev, linux-omap, dri-devel, kernel
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/video/fbdev/omap/omapfb_main.c | 6 ++----
drivers/video/fbdev/omap2/omapfb/dss/core.c | 6 ++----
drivers/video/fbdev/omap2/omapfb/dss/dispc.c | 5 ++---
drivers/video/fbdev/omap2/omapfb/dss/dpi.c | 5 ++---
drivers/video/fbdev/omap2/omapfb/dss/dsi.c | 5 ++---
drivers/video/fbdev/omap2/omapfb/dss/dss.c | 5 ++---
drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c | 5 ++---
drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c | 5 ++---
drivers/video/fbdev/omap2/omapfb/dss/sdi.c | 5 ++---
drivers/video/fbdev/omap2/omapfb/dss/venc.c | 5 ++---
drivers/video/fbdev/omap2/omapfb/omapfb-main.c | 6 ++----
11 files changed, 22 insertions(+), 36 deletions(-)
diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video/fbdev/omap/omapfb_main.c
index 1f3df2055ff0..764058f40341 100644
--- a/drivers/video/fbdev/omap/omapfb_main.c
+++ b/drivers/video/fbdev/omap/omapfb_main.c
@@ -1793,7 +1793,7 @@ void omapfb_register_panel(struct lcd_panel *panel)
EXPORT_SYMBOL_GPL(omapfb_register_panel);
/* Called when the device is being detached from the driver */
-static int omapfb_remove(struct platform_device *pdev)
+static void omapfb_remove(struct platform_device *pdev)
{
struct omapfb_device *fbdev = platform_get_drvdata(pdev);
enum omapfb_state saved_state = fbdev->state;
@@ -1805,8 +1805,6 @@ static int omapfb_remove(struct platform_device *pdev)
platform_device_unregister(&omapdss_device);
fbdev->dssdev = NULL;
-
- return 0;
}
/* PM suspend */
@@ -1831,7 +1829,7 @@ static int omapfb_resume(struct platform_device *pdev)
static struct platform_driver omapfb_driver = {
.probe = omapfb_probe,
- .remove = omapfb_remove,
+ .remove_new = omapfb_remove,
.suspend = omapfb_suspend,
.resume = omapfb_resume,
.driver = {
diff --git a/drivers/video/fbdev/omap2/omapfb/dss/core.c b/drivers/video/fbdev/omap2/omapfb/dss/core.c
index 37858be8be83..5fbd8885bad8 100644
--- a/drivers/video/fbdev/omap2/omapfb/dss/core.c
+++ b/drivers/video/fbdev/omap2/omapfb/dss/core.c
@@ -171,13 +171,11 @@ static int __init omap_dss_probe(struct platform_device *pdev)
return 0;
}
-static int omap_dss_remove(struct platform_device *pdev)
+static void omap_dss_remove(struct platform_device *pdev)
{
unregister_pm_notifier(&omap_dss_pm_notif_block);
dss_uninitialize_debugfs();
-
- return 0;
}
static void omap_dss_shutdown(struct platform_device *pdev)
@@ -187,7 +185,7 @@ static void omap_dss_shutdown(struct platform_device *pdev)
}
static struct platform_driver omap_dss_driver = {
- .remove = omap_dss_remove,
+ .remove_new = omap_dss_remove,
.shutdown = omap_dss_shutdown,
.driver = {
.name = "omapdss",
diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dispc.c b/drivers/video/fbdev/omap2/omapfb/dss/dispc.c
index 92fb6b7e1f68..21fef9db90d2 100644
--- a/drivers/video/fbdev/omap2/omapfb/dss/dispc.c
+++ b/drivers/video/fbdev/omap2/omapfb/dss/dispc.c
@@ -4017,10 +4017,9 @@ static int dispc_probe(struct platform_device *pdev)
return component_add(&pdev->dev, &dispc_component_ops);
}
-static int dispc_remove(struct platform_device *pdev)
+static void dispc_remove(struct platform_device *pdev)
{
component_del(&pdev->dev, &dispc_component_ops);
- return 0;
}
static int dispc_runtime_suspend(struct device *dev)
@@ -4073,7 +4072,7 @@ static const struct of_device_id dispc_of_match[] = {
static struct platform_driver omap_dispchw_driver = {
.probe = dispc_probe,
- .remove = dispc_remove,
+ .remove_new = dispc_remove,
.driver = {
.name = "omapdss_dispc",
.pm = &dispc_pm_ops,
diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dpi.c b/drivers/video/fbdev/omap2/omapfb/dss/dpi.c
index 99ce6e955a46..7c1b7d89389a 100644
--- a/drivers/video/fbdev/omap2/omapfb/dss/dpi.c
+++ b/drivers/video/fbdev/omap2/omapfb/dss/dpi.c
@@ -810,15 +810,14 @@ static int dpi_probe(struct platform_device *pdev)
return component_add(&pdev->dev, &dpi_component_ops);
}
-static int dpi_remove(struct platform_device *pdev)
+static void dpi_remove(struct platform_device *pdev)
{
component_del(&pdev->dev, &dpi_component_ops);
- return 0;
}
static struct platform_driver omap_dpi_driver = {
.probe = dpi_probe,
- .remove = dpi_remove,
+ .remove_new = dpi_remove,
.driver = {
.name = "omapdss_dpi",
.suppress_bind_attrs = true,
diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dsi.c b/drivers/video/fbdev/omap2/omapfb/dss/dsi.c
index 7cddb7b8ae34..b7eb17a16ec4 100644
--- a/drivers/video/fbdev/omap2/omapfb/dss/dsi.c
+++ b/drivers/video/fbdev/omap2/omapfb/dss/dsi.c
@@ -5495,10 +5495,9 @@ static int dsi_probe(struct platform_device *pdev)
return component_add(&pdev->dev, &dsi_component_ops);
}
-static int dsi_remove(struct platform_device *pdev)
+static void dsi_remove(struct platform_device *pdev)
{
component_del(&pdev->dev, &dsi_component_ops);
- return 0;
}
static int dsi_runtime_suspend(struct device *dev)
@@ -5565,7 +5564,7 @@ static const struct of_device_id dsi_of_match[] = {
static struct platform_driver omap_dsihw_driver = {
.probe = dsi_probe,
- .remove = dsi_remove,
+ .remove_new = dsi_remove,
.driver = {
.name = "omapdss_dsi",
.pm = &dsi_pm_ops,
diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dss.c b/drivers/video/fbdev/omap2/omapfb/dss/dss.c
index 335e0af4eec1..d814e4baa4b3 100644
--- a/drivers/video/fbdev/omap2/omapfb/dss/dss.c
+++ b/drivers/video/fbdev/omap2/omapfb/dss/dss.c
@@ -1224,10 +1224,9 @@ static int dss_probe(struct platform_device *pdev)
return 0;
}
-static int dss_remove(struct platform_device *pdev)
+static void dss_remove(struct platform_device *pdev)
{
component_master_del(&pdev->dev, &dss_component_ops);
- return 0;
}
static int dss_runtime_suspend(struct device *dev)
@@ -1279,7 +1278,7 @@ MODULE_DEVICE_TABLE(of, dss_of_match);
static struct platform_driver omap_dsshw_driver = {
.probe = dss_probe,
- .remove = dss_remove,
+ .remove_new = dss_remove,
.driver = {
.name = "omapdss_dss",
.pm = &dss_pm_ops,
diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c b/drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c
index 0f39612e002e..f05b4e35a842 100644
--- a/drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c
+++ b/drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c
@@ -756,10 +756,9 @@ static int hdmi4_probe(struct platform_device *pdev)
return component_add(&pdev->dev, &hdmi4_component_ops);
}
-static int hdmi4_remove(struct platform_device *pdev)
+static void hdmi4_remove(struct platform_device *pdev)
{
component_del(&pdev->dev, &hdmi4_component_ops);
- return 0;
}
static int hdmi_runtime_suspend(struct device *dev)
@@ -792,7 +791,7 @@ static const struct of_device_id hdmi_of_match[] = {
static struct platform_driver omapdss_hdmihw_driver = {
.probe = hdmi4_probe,
- .remove = hdmi4_remove,
+ .remove_new = hdmi4_remove,
.driver = {
.name = "omapdss_hdmi",
.pm = &hdmi_pm_ops,
diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c b/drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c
index bfccc2cb917a..03292945b1d4 100644
--- a/drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c
+++ b/drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c
@@ -797,10 +797,9 @@ static int hdmi5_probe(struct platform_device *pdev)
return component_add(&pdev->dev, &hdmi5_component_ops);
}
-static int hdmi5_remove(struct platform_device *pdev)
+static void hdmi5_remove(struct platform_device *pdev)
{
component_del(&pdev->dev, &hdmi5_component_ops);
- return 0;
}
static int hdmi_runtime_suspend(struct device *dev)
@@ -834,7 +833,7 @@ static const struct of_device_id hdmi_of_match[] = {
static struct platform_driver omapdss_hdmihw_driver = {
.probe = hdmi5_probe,
- .remove = hdmi5_remove,
+ .remove_new = hdmi5_remove,
.driver = {
.name = "omapdss_hdmi5",
.pm = &hdmi_pm_ops,
diff --git a/drivers/video/fbdev/omap2/omapfb/dss/sdi.c b/drivers/video/fbdev/omap2/omapfb/dss/sdi.c
index 002f07f5480f..d527931b2b16 100644
--- a/drivers/video/fbdev/omap2/omapfb/dss/sdi.c
+++ b/drivers/video/fbdev/omap2/omapfb/dss/sdi.c
@@ -375,15 +375,14 @@ static int sdi_probe(struct platform_device *pdev)
return component_add(&pdev->dev, &sdi_component_ops);
}
-static int sdi_remove(struct platform_device *pdev)
+static void sdi_remove(struct platform_device *pdev)
{
component_del(&pdev->dev, &sdi_component_ops);
- return 0;
}
static struct platform_driver omap_sdi_driver = {
.probe = sdi_probe,
- .remove = sdi_remove,
+ .remove_new = sdi_remove,
.driver = {
.name = "omapdss_sdi",
.suppress_bind_attrs = true,
diff --git a/drivers/video/fbdev/omap2/omapfb/dss/venc.c b/drivers/video/fbdev/omap2/omapfb/dss/venc.c
index 78a7309d25dd..c9d40e28a06f 100644
--- a/drivers/video/fbdev/omap2/omapfb/dss/venc.c
+++ b/drivers/video/fbdev/omap2/omapfb/dss/venc.c
@@ -880,10 +880,9 @@ static int venc_probe(struct platform_device *pdev)
return component_add(&pdev->dev, &venc_component_ops);
}
-static int venc_remove(struct platform_device *pdev)
+static void venc_remove(struct platform_device *pdev)
{
component_del(&pdev->dev, &venc_component_ops);
- return 0;
}
static int venc_runtime_suspend(struct device *dev)
@@ -922,7 +921,7 @@ static const struct of_device_id venc_of_match[] = {
static struct platform_driver omap_venchw_driver = {
.probe = venc_probe,
- .remove = venc_remove,
+ .remove_new = venc_remove,
.driver = {
.name = "omapdss_venc",
.pm = &venc_pm_ops,
diff --git a/drivers/video/fbdev/omap2/omapfb/omapfb-main.c b/drivers/video/fbdev/omap2/omapfb/omapfb-main.c
index 5ccddcfce722..c0538069eb48 100644
--- a/drivers/video/fbdev/omap2/omapfb/omapfb-main.c
+++ b/drivers/video/fbdev/omap2/omapfb/omapfb-main.c
@@ -2599,7 +2599,7 @@ static int omapfb_probe(struct platform_device *pdev)
return r;
}
-static int omapfb_remove(struct platform_device *pdev)
+static void omapfb_remove(struct platform_device *pdev)
{
struct omapfb2_device *fbdev = platform_get_drvdata(pdev);
@@ -2610,13 +2610,11 @@ static int omapfb_remove(struct platform_device *pdev)
omapfb_free_resources(fbdev);
omapdss_compat_uninit();
-
- return 0;
}
static struct platform_driver omapfb_driver = {
.probe = omapfb_probe,
- .remove = omapfb_remove,
+ .remove_new = omapfb_remove,
.driver = {
.name = "omapfb",
},
--
2.39.2
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 00/51] video: fbdev: Convert to platform remove callback returning void
2023-03-18 23:53 [PATCH 00/51] video: fbdev: Convert to platform remove callback returning void Uwe Kleine-König
2023-03-18 23:54 ` [PATCH 30/51] video: fbdev: omapfb: " Uwe Kleine-König
@ 2023-03-19 18:04 ` Helge Deller
2023-03-19 21:08 ` Uwe Kleine-König
2023-05-30 14:02 ` Uwe Kleine-König
2023-03-20 10:03 ` Thomas Zimmermann
2 siblings, 2 replies; 10+ messages in thread
From: Helge Deller @ 2023-03-19 18:04 UTC (permalink / raw)
To: Uwe Kleine-König, Yihao Han, Javier Martinez Canillas,
Thomas Zimmermann, Wolfram Sang, Alexander Shiyan, Dongliang Mu,
Peter Jones, Gaosheng Cui, Timur Tabi, Xuezhi Zhang,
Jiasheng Jiang, Ferenc Bakonyi, Sascha Hauer, Shawn Guo,
Christophe Leroy, Stephen Kitt, Daniel Thompson, Mark Brown,
Rob Herring, Bartlomiej Zolnierkiewicz, Arnd Bergmann,
Tony Lindgren, Jiapeng Chong, Yu Zhe, Xu Panda, Zhang Qilong,
Hyunwoo Kim, Yang Yingliang, Robert Jarzmik, Ulf Hansson,
Wang Qing, Kristoffer Ericson, Jingoo Han, ye xingchen,
Geert Uytterhoeven, Hans de Goede, Michal Januszewski,
Daniel Vetter, Zeng Heng, Florian Tobias Schandinat, Michal Simek
Cc: linux-fbdev, dri-devel, kernel, linux-arm-kernel, linux-nvidia,
Fabio Estevam, NXP Linux Team, linux-omap
Hello Uwe,
On 3/19/23 00:53, Uwe Kleine-König wrote:
> this series adapts the platform drivers below drivers/video/fbdev to use the
> .remove_new() callback. Compared to the traditional .remove() callback
> .remove_new() returns no value. This is a good thing because the driver core
> doesn't (and cannot) cope for errors during remove. The only effect of a
> non-zero return value in .remove() is that the driver core emits a warning. The
> device is removed anyhow and an early return from .remove() usually yields a
> resource leak.
>
> By changing the remove callback to return void driver authors cannot
> reasonably assume any more that there is some kind of cleanup later.
>
> The first patch simplifies the remove callback of one driver to obviously
> always return zero. After that all drivers are converted trivially to
> .remove_new().
Thanks for that patch series. It's a nice cleanup.
I've applied it to the fbdev "for-next" git tree for now to get some compile testing.
I hope that's ok for you.
Regarding the new "remove_new" struct member I'd prefer a better name but don't
have any idea yet...
Helge
>
> Best regards
> Uwe
>
> Uwe Kleine-König (51):
> video: fbdev: au1100fb: Drop if with an always false condition
> video: fbdev: arcfb: Convert to platform remove callback returning
> void
> video: fbdev: au1100fb: Convert to platform remove callback returning
> void
> video: fbdev: au1200fb: Convert to platform remove callback returning
> void
> video: fbdev: broadsheetfb: Convert to platform remove callback
> returning void
> video: fbdev: bw2: Convert to platform remove callback returning void
> video: fbdev: cg14: Convert to platform remove callback returning void
> video: fbdev: cg3: Convert to platform remove callback returning void
> video: fbdev: cg6: Convert to platform remove callback returning void
> video: fbdev: clps711x-fb: Convert to platform remove callback
> returning void
> video: fbdev: cobalt_lcdfb: Convert to platform remove callback
> returning void
> video: fbdev: da8xx-fb: Convert to platform remove callback returning
> void
> video: fbdev: efifb: Convert to platform remove callback returning
> void
> video: fbdev: ep93xx-fb: Convert to platform remove callback returning
> void
> video: fbdev: ffb: Convert to platform remove callback returning void
> video: fbdev: fsl-diu-fb: Convert to platform remove callback
> returning void
> video: fbdev: gbefb: Convert to platform remove callback returning
> void
> video: fbdev: goldfishfb: Convert to platform remove callback
> returning void
> video: fbdev: grvga: Convert to platform remove callback returning
> void
> video: fbdev: hecubafb: Convert to platform remove callback returning
> void
> video: fbdev: hgafb: Convert to platform remove callback returning
> void
> video: fbdev: hitfb: Convert to platform remove callback returning
> void
> video: fbdev: imxfb: Convert to platform remove callback returning
> void
> video: fbdev: leo: Convert to platform remove callback returning void
> video: fbdev: mb862xx: Convert to platform remove callback returning
> void
> video: fbdev: metronomefb: Convert to platform remove callback
> returning void
> video: fbdev: mx3fb: Convert to platform remove callback returning
> void
> video: fbdev: ocfb: Convert to platform remove callback returning void
> video: fbdev: offb: Convert to platform remove callback returning void
> video: fbdev: omapfb: Convert to platform remove callback returning
> void
> video: fbdev: p9100: Convert to platform remove callback returning
> void
> video: fbdev: platinumfb: Convert to platform remove callback
> returning void
> video: fbdev: pxa168fb: Convert to platform remove callback returning
> void
> video: fbdev: pxa3xx-gcu: Convert to platform remove callback
> returning void
> video: fbdev: pxafb: Convert to platform remove callback returning
> void
> video: fbdev: s1d13xxxfb: Convert to platform remove callback
> returning void
> video: fbdev: s3c-fb: Convert to platform remove callback returning
> void
> video: fbdev: sh7760fb: Convert to platform remove callback returning
> void
> video: fbdev: sh_mobile_lcdcfb: Convert to platform remove callback
> returning void
> video: fbdev: simplefb: Convert to platform remove callback returning
> void
> video: fbdev: sm501fb: Convert to platform remove callback returning
> void
> video: fbdev: tcx: Convert to platform remove callback returning void
> video: fbdev: uvesafb: Convert to platform remove callback returning
> void
> video: fbdev: vesafb: Convert to platform remove callback returning
> void
> video: fbdev: vfb: Convert to platform remove callback returning void
> video: fbdev: vga16fb: Convert to platform remove callback returning
> void
> video: fbdev: via: Convert to platform remove callback returning void
> video: fbdev: vt8500lcdfb: Convert to platform remove callback
> returning void
> video: fbdev: wm8505fb: Convert to platform remove callback returning
> void
> video: fbdev: wmt_ge_rops: Convert to platform remove callback
> returning void
> video: fbdev: xilinxfb: Convert to platform remove callback returning
> void
>
> drivers/video/fbdev/arcfb.c | 5 ++---
> drivers/video/fbdev/au1100fb.c | 11 +++--------
> drivers/video/fbdev/au1200fb.c | 6 ++----
> drivers/video/fbdev/broadsheetfb.c | 5 ++---
> drivers/video/fbdev/bw2.c | 6 ++----
> drivers/video/fbdev/cg14.c | 6 ++----
> drivers/video/fbdev/cg3.c | 6 ++----
> drivers/video/fbdev/cg6.c | 6 ++----
> drivers/video/fbdev/clps711x-fb.c | 6 ++----
> drivers/video/fbdev/cobalt_lcdfb.c | 6 ++----
> drivers/video/fbdev/da8xx-fb.c | 6 ++----
> drivers/video/fbdev/efifb.c | 6 ++----
> drivers/video/fbdev/ep93xx-fb.c | 6 ++----
> drivers/video/fbdev/ffb.c | 6 ++----
> drivers/video/fbdev/fsl-diu-fb.c | 6 ++----
> drivers/video/fbdev/gbefb.c | 6 ++----
> drivers/video/fbdev/goldfishfb.c | 5 ++---
> drivers/video/fbdev/grvga.c | 6 ++----
> drivers/video/fbdev/hecubafb.c | 5 ++---
> drivers/video/fbdev/hgafb.c | 6 ++----
> drivers/video/fbdev/hitfb.c | 6 ++----
> drivers/video/fbdev/imxfb.c | 6 ++----
> drivers/video/fbdev/leo.c | 6 ++----
> drivers/video/fbdev/mb862xx/mb862xxfbdrv.c | 5 ++---
> drivers/video/fbdev/metronomefb.c | 5 ++---
> drivers/video/fbdev/mx3fb.c | 5 ++---
> drivers/video/fbdev/ocfb.c | 6 ++----
> drivers/video/fbdev/offb.c | 8 +++-----
> drivers/video/fbdev/omap/omapfb_main.c | 6 ++----
> drivers/video/fbdev/omap2/omapfb/dss/core.c | 6 ++----
> drivers/video/fbdev/omap2/omapfb/dss/dispc.c | 5 ++---
> drivers/video/fbdev/omap2/omapfb/dss/dpi.c | 5 ++---
> drivers/video/fbdev/omap2/omapfb/dss/dsi.c | 5 ++---
> drivers/video/fbdev/omap2/omapfb/dss/dss.c | 5 ++---
> drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c | 5 ++---
> drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c | 5 ++---
> drivers/video/fbdev/omap2/omapfb/dss/sdi.c | 5 ++---
> drivers/video/fbdev/omap2/omapfb/dss/venc.c | 5 ++---
> drivers/video/fbdev/omap2/omapfb/omapfb-main.c | 6 ++----
> drivers/video/fbdev/p9100.c | 6 ++----
> drivers/video/fbdev/platinumfb.c | 6 ++----
> drivers/video/fbdev/pxa168fb.c | 8 +++-----
> drivers/video/fbdev/pxa3xx-gcu.c | 6 ++----
> drivers/video/fbdev/pxafb.c | 8 +++-----
> drivers/video/fbdev/s1d13xxxfb.c | 5 ++---
> drivers/video/fbdev/s3c-fb.c | 6 ++----
> drivers/video/fbdev/sh7760fb.c | 6 ++----
> drivers/video/fbdev/sh_mobile_lcdcfb.c | 5 ++---
> drivers/video/fbdev/simplefb.c | 6 ++----
> drivers/video/fbdev/sm501fb.c | 6 ++----
> drivers/video/fbdev/tcx.c | 6 ++----
> drivers/video/fbdev/uvesafb.c | 6 ++----
> drivers/video/fbdev/vesafb.c | 6 ++----
> drivers/video/fbdev/vfb.c | 5 ++---
> drivers/video/fbdev/vga16fb.c | 6 ++----
> drivers/video/fbdev/via/via-gpio.c | 5 ++---
> drivers/video/fbdev/via/via_i2c.c | 5 ++---
> drivers/video/fbdev/vt8500lcdfb.c | 6 ++----
> drivers/video/fbdev/wm8505fb.c | 6 ++----
> drivers/video/fbdev/wmt_ge_rops.c | 5 ++---
> drivers/video/fbdev/xilinxfb.c | 6 ++----
> 61 files changed, 126 insertions(+), 230 deletions(-)
>
> base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 00/51] video: fbdev: Convert to platform remove callback returning void
2023-03-19 18:04 ` [PATCH 00/51] video: fbdev: " Helge Deller
@ 2023-03-19 21:08 ` Uwe Kleine-König
2023-03-19 21:41 ` Helge Deller
2023-05-30 14:02 ` Uwe Kleine-König
1 sibling, 1 reply; 10+ messages in thread
From: Uwe Kleine-König @ 2023-03-19 21:08 UTC (permalink / raw)
To: Helge Deller
Cc: Yihao Han, Javier Martinez Canillas, Thomas Zimmermann,
Wolfram Sang, Alexander Shiyan, Dongliang Mu, Peter Jones,
Gaosheng Cui, Timur Tabi, Xuezhi Zhang, Jiasheng Jiang,
Ferenc Bakonyi, Sascha Hauer, Shawn Guo, Christophe Leroy,
Stephen Kitt, Daniel Thompson, Mark Brown, Rob Herring,
Arnd Bergmann, Tony Lindgren, Jiapeng Chong, Yu Zhe, Xu Panda,
Zhang Qilong, Hyunwoo Kim, Yang Yingliang, Robert Jarzmik,
Ulf Hansson, Wang Qing, Kristoffer Ericson, Jingoo Han,
ye xingchen, Geert Uytterhoeven, Hans de Goede, Daniel Vetter,
Zeng Heng, Florian Tobias Schandinat, Michal Simek, linux-fbdev,
dri-devel, NXP Linux Team, kernel, linux-nvidia, linux-omap,
Fabio Estevam, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 1817 bytes --]
Hello,
[Dropped Bartlomiej Zolnierkiewicz and Michal Januszewski from Cc, their
email addresses bounced]
On Sun, Mar 19, 2023 at 07:04:54PM +0100, Helge Deller wrote:
> Hello Uwe,
>
> On 3/19/23 00:53, Uwe Kleine-König wrote:
> > this series adapts the platform drivers below drivers/video/fbdev to use the
> > .remove_new() callback. Compared to the traditional .remove() callback
> > .remove_new() returns no value. This is a good thing because the driver core
> > doesn't (and cannot) cope for errors during remove. The only effect of a
> > non-zero return value in .remove() is that the driver core emits a warning. The
> > device is removed anyhow and an early return from .remove() usually yields a
> > resource leak.
> >
> > By changing the remove callback to return void driver authors cannot
> > reasonably assume any more that there is some kind of cleanup later.
> >
> > The first patch simplifies the remove callback of one driver to obviously
> > always return zero. After that all drivers are converted trivially to
> > .remove_new().
>
> Thanks for that patch series. It's a nice cleanup.
> I've applied it to the fbdev "for-next" git tree for now to get some compile testing.
> I hope that's ok for you.
>
> Regarding the new "remove_new" struct member I'd prefer a better name but don't
> have any idea yet...
Ideally we won't have to life with it for long. The eventual plan is to
switch back to "remove" once all drivers are converted. So I didn't
think intensively about a better name. Did you know that struct
i2c_driver has a "temporary" .probe_new() callback since 2016?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 00/51] video: fbdev: Convert to platform remove callback returning void
2023-03-19 21:08 ` Uwe Kleine-König
@ 2023-03-19 21:41 ` Helge Deller
0 siblings, 0 replies; 10+ messages in thread
From: Helge Deller @ 2023-03-19 21:41 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Yihao Han, Javier Martinez Canillas, Thomas Zimmermann,
Wolfram Sang, Alexander Shiyan, Dongliang Mu, Peter Jones,
Gaosheng Cui, Timur Tabi, Xuezhi Zhang, Jiasheng Jiang,
Ferenc Bakonyi, Sascha Hauer, Shawn Guo, Christophe Leroy,
Stephen Kitt, Daniel Thompson, Mark Brown, Rob Herring,
Arnd Bergmann, Tony Lindgren, Jiapeng Chong, Yu Zhe, Xu Panda,
Zhang Qilong, Hyunwoo Kim, Yang Yingliang, Robert Jarzmik,
Ulf Hansson, Wang Qing, Kristoffer Ericson, Jingoo Han,
ye xingchen, Geert Uytterhoeven, Hans de Goede, Daniel Vetter,
Zeng Heng, Florian Tobias Schandinat, Michal Simek, linux-fbdev,
dri-devel, NXP Linux Team, kernel, linux-nvidia, linux-omap,
Fabio Estevam, linux-arm-kernel
On 3/19/23 22:08, Uwe Kleine-König wrote:
> Hello,
>
> [Dropped Bartlomiej Zolnierkiewicz and Michal Januszewski from Cc, their
> email addresses bounced]
>
> On Sun, Mar 19, 2023 at 07:04:54PM +0100, Helge Deller wrote:
>> Hello Uwe,
>>
>> On 3/19/23 00:53, Uwe Kleine-König wrote:
>>> this series adapts the platform drivers below drivers/video/fbdev to use the
>>> .remove_new() callback. Compared to the traditional .remove() callback
>>> .remove_new() returns no value. This is a good thing because the driver core
>>> doesn't (and cannot) cope for errors during remove. The only effect of a
>>> non-zero return value in .remove() is that the driver core emits a warning. The
>>> device is removed anyhow and an early return from .remove() usually yields a
>>> resource leak.
>>>
>>> By changing the remove callback to return void driver authors cannot
>>> reasonably assume any more that there is some kind of cleanup later.
>>>
>>> The first patch simplifies the remove callback of one driver to obviously
>>> always return zero. After that all drivers are converted trivially to
>>> .remove_new().
>>
>> Thanks for that patch series. It's a nice cleanup.
>> I've applied it to the fbdev "for-next" git tree for now to get some compile testing.
>> I hope that's ok for you.
>>
>> Regarding the new "remove_new" struct member I'd prefer a better name but don't
>> have any idea yet...
>
> Ideally we won't have to life with it for long. The eventual plan is to
> switch back to "remove" once all drivers are converted. So I didn't
> think intensively about a better name.
Ok.
> Did you know that struct i2c_driver has a "temporary" .probe_new()
> callback since 2016?
No, I didn't knew. Nice :-)
Helge
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 00/51] video: fbdev: Convert to platform remove callback returning void
2023-03-18 23:53 [PATCH 00/51] video: fbdev: Convert to platform remove callback returning void Uwe Kleine-König
2023-03-18 23:54 ` [PATCH 30/51] video: fbdev: omapfb: " Uwe Kleine-König
2023-03-19 18:04 ` [PATCH 00/51] video: fbdev: " Helge Deller
@ 2023-03-20 10:03 ` Thomas Zimmermann
2 siblings, 0 replies; 10+ messages in thread
From: Thomas Zimmermann @ 2023-03-20 10:03 UTC (permalink / raw)
To: Uwe Kleine-König, Helge Deller, Yihao Han, Jaya Kumar,
Javier Martinez Canillas, Wolfram Sang, Alexander Shiyan,
Dongliang Mu, Peter Jones, Gaosheng Cui, Timur Tabi, Xuezhi Zhang,
Jiasheng Jiang, Ferenc Bakonyi, Sascha Hauer, Shawn Guo,
Christophe Leroy, Stephen Kitt, Daniel Thompson, Mark Brown,
Rob Herring, Bartlomiej Zolnierkiewicz, Arnd Bergmann,
Tony Lindgren, Jiapeng Chong, Yu Zhe, Xu Panda, Zhang Qilong,
Hyunwoo Kim, Yang Yingliang, Robert Jarzmik, Ulf Hansson,
wangkailong@jari.cn, Wang Qing, Kristoffer Ericson, Jingoo Han,
ye xingchen, Geert Uytterhoeven, Hans de Goede,
Michal Januszewski, Daniel Vetter, Zeng Heng,
Florian Tobias Schandinat, Michal Simek
Cc: linux-fbdev, dri-devel, NXP Linux Team, kernel, linux-nvidia,
linux-omap, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 9667 bytes --]
I'm a bit late, but still
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
for the series. Thanks for this cleanup.
Best regards
Thomas
Am 19.03.23 um 00:53 schrieb Uwe Kleine-König:
> Hello,
>
> this series adapts the platform drivers below drivers/video/fbdev to use the
> .remove_new() callback. Compared to the traditional .remove() callback
> .remove_new() returns no value. This is a good thing because the driver core
> doesn't (and cannot) cope for errors during remove. The only effect of a
> non-zero return value in .remove() is that the driver core emits a warning. The
> device is removed anyhow and an early return from .remove() usually yields a
> resource leak.
>
> By changing the remove callback to return void driver authors cannot
> reasonably assume any more that there is some kind of cleanup later.
>
> The first patch simplifies the remove callback of one driver to obviously
> always return zero. After that all drivers are converted trivially to
> .remove_new().
>
> Best regards
> Uwe
>
> Uwe Kleine-König (51):
> video: fbdev: au1100fb: Drop if with an always false condition
> video: fbdev: arcfb: Convert to platform remove callback returning
> void
> video: fbdev: au1100fb: Convert to platform remove callback returning
> void
> video: fbdev: au1200fb: Convert to platform remove callback returning
> void
> video: fbdev: broadsheetfb: Convert to platform remove callback
> returning void
> video: fbdev: bw2: Convert to platform remove callback returning void
> video: fbdev: cg14: Convert to platform remove callback returning void
> video: fbdev: cg3: Convert to platform remove callback returning void
> video: fbdev: cg6: Convert to platform remove callback returning void
> video: fbdev: clps711x-fb: Convert to platform remove callback
> returning void
> video: fbdev: cobalt_lcdfb: Convert to platform remove callback
> returning void
> video: fbdev: da8xx-fb: Convert to platform remove callback returning
> void
> video: fbdev: efifb: Convert to platform remove callback returning
> void
> video: fbdev: ep93xx-fb: Convert to platform remove callback returning
> void
> video: fbdev: ffb: Convert to platform remove callback returning void
> video: fbdev: fsl-diu-fb: Convert to platform remove callback
> returning void
> video: fbdev: gbefb: Convert to platform remove callback returning
> void
> video: fbdev: goldfishfb: Convert to platform remove callback
> returning void
> video: fbdev: grvga: Convert to platform remove callback returning
> void
> video: fbdev: hecubafb: Convert to platform remove callback returning
> void
> video: fbdev: hgafb: Convert to platform remove callback returning
> void
> video: fbdev: hitfb: Convert to platform remove callback returning
> void
> video: fbdev: imxfb: Convert to platform remove callback returning
> void
> video: fbdev: leo: Convert to platform remove callback returning void
> video: fbdev: mb862xx: Convert to platform remove callback returning
> void
> video: fbdev: metronomefb: Convert to platform remove callback
> returning void
> video: fbdev: mx3fb: Convert to platform remove callback returning
> void
> video: fbdev: ocfb: Convert to platform remove callback returning void
> video: fbdev: offb: Convert to platform remove callback returning void
> video: fbdev: omapfb: Convert to platform remove callback returning
> void
> video: fbdev: p9100: Convert to platform remove callback returning
> void
> video: fbdev: platinumfb: Convert to platform remove callback
> returning void
> video: fbdev: pxa168fb: Convert to platform remove callback returning
> void
> video: fbdev: pxa3xx-gcu: Convert to platform remove callback
> returning void
> video: fbdev: pxafb: Convert to platform remove callback returning
> void
> video: fbdev: s1d13xxxfb: Convert to platform remove callback
> returning void
> video: fbdev: s3c-fb: Convert to platform remove callback returning
> void
> video: fbdev: sh7760fb: Convert to platform remove callback returning
> void
> video: fbdev: sh_mobile_lcdcfb: Convert to platform remove callback
> returning void
> video: fbdev: simplefb: Convert to platform remove callback returning
> void
> video: fbdev: sm501fb: Convert to platform remove callback returning
> void
> video: fbdev: tcx: Convert to platform remove callback returning void
> video: fbdev: uvesafb: Convert to platform remove callback returning
> void
> video: fbdev: vesafb: Convert to platform remove callback returning
> void
> video: fbdev: vfb: Convert to platform remove callback returning void
> video: fbdev: vga16fb: Convert to platform remove callback returning
> void
> video: fbdev: via: Convert to platform remove callback returning void
> video: fbdev: vt8500lcdfb: Convert to platform remove callback
> returning void
> video: fbdev: wm8505fb: Convert to platform remove callback returning
> void
> video: fbdev: wmt_ge_rops: Convert to platform remove callback
> returning void
> video: fbdev: xilinxfb: Convert to platform remove callback returning
> void
>
> drivers/video/fbdev/arcfb.c | 5 ++---
> drivers/video/fbdev/au1100fb.c | 11 +++--------
> drivers/video/fbdev/au1200fb.c | 6 ++----
> drivers/video/fbdev/broadsheetfb.c | 5 ++---
> drivers/video/fbdev/bw2.c | 6 ++----
> drivers/video/fbdev/cg14.c | 6 ++----
> drivers/video/fbdev/cg3.c | 6 ++----
> drivers/video/fbdev/cg6.c | 6 ++----
> drivers/video/fbdev/clps711x-fb.c | 6 ++----
> drivers/video/fbdev/cobalt_lcdfb.c | 6 ++----
> drivers/video/fbdev/da8xx-fb.c | 6 ++----
> drivers/video/fbdev/efifb.c | 6 ++----
> drivers/video/fbdev/ep93xx-fb.c | 6 ++----
> drivers/video/fbdev/ffb.c | 6 ++----
> drivers/video/fbdev/fsl-diu-fb.c | 6 ++----
> drivers/video/fbdev/gbefb.c | 6 ++----
> drivers/video/fbdev/goldfishfb.c | 5 ++---
> drivers/video/fbdev/grvga.c | 6 ++----
> drivers/video/fbdev/hecubafb.c | 5 ++---
> drivers/video/fbdev/hgafb.c | 6 ++----
> drivers/video/fbdev/hitfb.c | 6 ++----
> drivers/video/fbdev/imxfb.c | 6 ++----
> drivers/video/fbdev/leo.c | 6 ++----
> drivers/video/fbdev/mb862xx/mb862xxfbdrv.c | 5 ++---
> drivers/video/fbdev/metronomefb.c | 5 ++---
> drivers/video/fbdev/mx3fb.c | 5 ++---
> drivers/video/fbdev/ocfb.c | 6 ++----
> drivers/video/fbdev/offb.c | 8 +++-----
> drivers/video/fbdev/omap/omapfb_main.c | 6 ++----
> drivers/video/fbdev/omap2/omapfb/dss/core.c | 6 ++----
> drivers/video/fbdev/omap2/omapfb/dss/dispc.c | 5 ++---
> drivers/video/fbdev/omap2/omapfb/dss/dpi.c | 5 ++---
> drivers/video/fbdev/omap2/omapfb/dss/dsi.c | 5 ++---
> drivers/video/fbdev/omap2/omapfb/dss/dss.c | 5 ++---
> drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c | 5 ++---
> drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c | 5 ++---
> drivers/video/fbdev/omap2/omapfb/dss/sdi.c | 5 ++---
> drivers/video/fbdev/omap2/omapfb/dss/venc.c | 5 ++---
> drivers/video/fbdev/omap2/omapfb/omapfb-main.c | 6 ++----
> drivers/video/fbdev/p9100.c | 6 ++----
> drivers/video/fbdev/platinumfb.c | 6 ++----
> drivers/video/fbdev/pxa168fb.c | 8 +++-----
> drivers/video/fbdev/pxa3xx-gcu.c | 6 ++----
> drivers/video/fbdev/pxafb.c | 8 +++-----
> drivers/video/fbdev/s1d13xxxfb.c | 5 ++---
> drivers/video/fbdev/s3c-fb.c | 6 ++----
> drivers/video/fbdev/sh7760fb.c | 6 ++----
> drivers/video/fbdev/sh_mobile_lcdcfb.c | 5 ++---
> drivers/video/fbdev/simplefb.c | 6 ++----
> drivers/video/fbdev/sm501fb.c | 6 ++----
> drivers/video/fbdev/tcx.c | 6 ++----
> drivers/video/fbdev/uvesafb.c | 6 ++----
> drivers/video/fbdev/vesafb.c | 6 ++----
> drivers/video/fbdev/vfb.c | 5 ++---
> drivers/video/fbdev/vga16fb.c | 6 ++----
> drivers/video/fbdev/via/via-gpio.c | 5 ++---
> drivers/video/fbdev/via/via_i2c.c | 5 ++---
> drivers/video/fbdev/vt8500lcdfb.c | 6 ++----
> drivers/video/fbdev/wm8505fb.c | 6 ++----
> drivers/video/fbdev/wmt_ge_rops.c | 5 ++---
> drivers/video/fbdev/xilinxfb.c | 6 ++----
> 61 files changed, 126 insertions(+), 230 deletions(-)
>
> base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 00/51] video: fbdev: Convert to platform remove callback returning void
2023-03-19 18:04 ` [PATCH 00/51] video: fbdev: " Helge Deller
2023-03-19 21:08 ` Uwe Kleine-König
@ 2023-05-30 14:02 ` Uwe Kleine-König
2023-05-30 16:12 ` Helge Deller
1 sibling, 1 reply; 10+ messages in thread
From: Uwe Kleine-König @ 2023-05-30 14:02 UTC (permalink / raw)
To: Helge Deller
Cc: Yihao Han, Javier Martinez Canillas, Thomas Zimmermann,
Wolfram Sang, Alexander Shiyan, Dongliang Mu, Peter Jones,
Gaosheng Cui, Timur Tabi, Xuezhi Zhang, Jiasheng Jiang,
Sascha Hauer, Shawn Guo, Christophe Leroy, Stephen Kitt,
Daniel Thompson, Mark Brown, Rob Herring, Arnd Bergmann,
Tony Lindgren, Jiapeng Chong, Yu Zhe, Xu Panda, Zhang Qilong,
Hyunwoo Kim, Yang Yingliang, Robert Jarzmik, Ulf Hansson,
Wang Qing, Kristoffer Ericson, Jingoo Han, ye xingchen,
Geert Uytterhoeven, Hans de Goede, Daniel Vetter, Zeng Heng,
Florian Tobias Schandinat, Michal Simek, linux-fbdev, dri-devel,
NXP Linux Team, kernel, linux-omap, Fabio Estevam,
linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 1491 bytes --]
[Dropped a few recipents that resulted in bounces before]
Hello,
On Sun, Mar 19, 2023 at 07:04:54PM +0100, Helge Deller wrote:
> On 3/19/23 00:53, Uwe Kleine-König wrote:
> > this series adapts the platform drivers below drivers/video/fbdev to use the
> > .remove_new() callback. Compared to the traditional .remove() callback
> > .remove_new() returns no value. This is a good thing because the driver core
> > doesn't (and cannot) cope for errors during remove. The only effect of a
> > non-zero return value in .remove() is that the driver core emits a warning. The
> > device is removed anyhow and an early return from .remove() usually yields a
> > resource leak.
> >
> > By changing the remove callback to return void driver authors cannot
> > reasonably assume any more that there is some kind of cleanup later.
> >
> > The first patch simplifies the remove callback of one driver to obviously
> > always return zero. After that all drivers are converted trivially to
> > .remove_new().
>
> Thanks for that patch series. It's a nice cleanup.
> I've applied it to the fbdev "for-next" git tree for now to get some compile testing.
> I hope that's ok for you.
I found patches #7 up to #51 in next, but the first 6 patches are
missing. I guess this wasn't' done on purpose?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 00/51] video: fbdev: Convert to platform remove callback returning void
2023-05-30 14:02 ` Uwe Kleine-König
@ 2023-05-30 16:12 ` Helge Deller
2023-05-30 16:27 ` Uwe Kleine-König
0 siblings, 1 reply; 10+ messages in thread
From: Helge Deller @ 2023-05-30 16:12 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Yihao Han, Javier Martinez Canillas, Thomas Zimmermann,
Wolfram Sang, Alexander Shiyan, Dongliang Mu, Peter Jones,
Gaosheng Cui, Timur Tabi, Xuezhi Zhang, Jiasheng Jiang,
Sascha Hauer, Shawn Guo, Christophe Leroy, Stephen Kitt,
Daniel Thompson, Mark Brown, Rob Herring, Arnd Bergmann,
Tony Lindgren, Jiapeng Chong, Yu Zhe, Xu Panda, Zhang Qilong,
Hyunwoo Kim, Yang Yingliang, Robert Jarzmik, Ulf Hansson,
Wang Qing, Kristoffer Ericson, Jingoo Han, ye xingchen,
Geert Uytterhoeven, Hans de Goede, Daniel Vetter, Zeng Heng,
Florian Tobias Schandinat, Michal Simek, linux-fbdev, dri-devel,
NXP Linux Team, kernel, linux-omap, Fabio Estevam,
linux-arm-kernel
Hi Uwe,
On 5/30/23 16:02, Uwe Kleine-König wrote:
> On Sun, Mar 19, 2023 at 07:04:54PM +0100, Helge Deller wrote:
>> On 3/19/23 00:53, Uwe Kleine-König wrote:
>>> this series adapts the platform drivers below drivers/video/fbdev to use the
>>> .remove_new() callback. Compared to the traditional .remove() callback
>>> .remove_new() returns no value. This is a good thing because the driver core
>>> doesn't (and cannot) cope for errors during remove. The only effect of a
>>> non-zero return value in .remove() is that the driver core emits a warning. The
>>> device is removed anyhow and an early return from .remove() usually yields a
>>> resource leak.
>>>
>>> By changing the remove callback to return void driver authors cannot
>>> reasonably assume any more that there is some kind of cleanup later.
>>>
>>> The first patch simplifies the remove callback of one driver to obviously
>>> always return zero. After that all drivers are converted trivially to
>>> .remove_new().
>>
>> Thanks for that patch series. It's a nice cleanup.
>> I've applied it to the fbdev "for-next" git tree for now to get some compile testing.
>> I hope that's ok for you.
>
> I found patches #7 up to #51 in next, but the first 6 patches are
> missing. I guess this wasn't' done on purpose?
Strange. I don't know why I didn't applied those.
Anyway, I've just added them now:
Applying: video: fbdev: au1100fb: Drop if with an always false condition
Applying: video: fbdev: arcfb: Convert to platform remove callback returning void
Applying: video: fbdev: au1100fb: Convert to platform remove callback returning void
Applying: video: fbdev: au1200fb: Convert to platform remove callback returning void
Applying: video: fbdev: broadsheetfb: Convert to platform remove callback returning void
Applying: video: fbdev: bw2: Convert to platform remove callback returning void
Thanks!
Helge
Btw... I cleaned up some minor whitespace issues in patch 3 (au1100fb).
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 00/51] video: fbdev: Convert to platform remove callback returning void
2023-05-30 16:12 ` Helge Deller
@ 2023-05-30 16:27 ` Uwe Kleine-König
2023-05-30 16:34 ` Helge Deller
0 siblings, 1 reply; 10+ messages in thread
From: Uwe Kleine-König @ 2023-05-30 16:27 UTC (permalink / raw)
To: Helge Deller
Cc: Ulf Hansson, Stephen Kitt, Geert Uytterhoeven, Tony Lindgren,
Daniel Vetter, linux-fbdev, dri-devel, Michal Simek, Wang Qing,
Wolfram Sang, Peter Jones, Xuezhi Zhang, Robert Jarzmik,
Gaosheng Cui, Rob Herring, Daniel Thompson, Alexander Shiyan,
Florian Tobias Schandinat, Xu Panda, Javier Martinez Canillas,
Christophe Leroy, Kristoffer Ericson, NXP Linux Team,
Yang Yingliang, kernel, Arnd Bergmann, Jiapeng Chong, Yu Zhe,
ye xingchen, Sascha Hauer, Jiasheng Jiang, Zeng Heng,
Hans de Goede, Mark Brown, Fabio Estevam, Hyunwoo Kim, linux-omap,
linux-arm-kernel, Yihao Han, Timur Tabi, Jingoo Han, Zhang Qilong,
Dongliang Mu, Thomas Zimmermann, Shawn Guo
[-- Attachment #1: Type: text/plain, Size: 1192 bytes --]
Hello Helge,
On Tue, May 30, 2023 at 06:12:09PM +0200, Helge Deller wrote:
> Btw... I cleaned up some minor whitespace issues in patch 3 (au1100fb).
We both did some different cleanup, on top of your
87be5a5d9a5c5b00505181eedbee62134f07d11d we could further cleanup doing
diff --git a/drivers/video/fbdev/au1100fb.c b/drivers/video/fbdev/au1100fb.c
index fb38557a9b63..648d6cac86e8 100644
--- a/drivers/video/fbdev/au1100fb.c
+++ b/drivers/video/fbdev/au1100fb.c
@@ -590,7 +590,7 @@ static struct platform_driver au1100fb_driver = {
.probe = au1100fb_drv_probe,
.remove_new = au1100fb_drv_remove,
.suspend = au1100fb_drv_suspend,
- .resume = au1100fb_drv_resume,
+ .resume = au1100fb_drv_resume,
};
module_platform_driver(au1100fb_driver);
Feel free to squash this into 87be5a5d9a5c5b00505181eedbee62134f07d11d.
If you want to apply it separately, either tell me to post a proper
patch, or apply it under your name with my Suggested-by -- whatever
suits you best.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 00/51] video: fbdev: Convert to platform remove callback returning void
2023-05-30 16:27 ` Uwe Kleine-König
@ 2023-05-30 16:34 ` Helge Deller
0 siblings, 0 replies; 10+ messages in thread
From: Helge Deller @ 2023-05-30 16:34 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Ulf Hansson, Stephen Kitt, Geert Uytterhoeven, Tony Lindgren,
Daniel Vetter, linux-fbdev, dri-devel, Michal Simek, Wang Qing,
Wolfram Sang, Peter Jones, Xuezhi Zhang, Robert Jarzmik,
Gaosheng Cui, Rob Herring, Daniel Thompson, Alexander Shiyan,
Florian Tobias Schandinat, Xu Panda, Javier Martinez Canillas,
Christophe Leroy, Kristoffer Ericson, NXP Linux Team,
Yang Yingliang, kernel, Arnd Bergmann, Jiapeng Chong, Yu Zhe,
ye xingchen, Sascha Hauer, Jiasheng Jiang, Zeng Heng,
Hans de Goede, Mark Brown, Fabio Estevam, Hyunwoo Kim, linux-omap,
linux-arm-kernel, Yihao Han, Timur Tabi, Jingoo Han, Zhang Qilong,
Dongliang Mu, Thomas Zimmermann, Shawn Guo
On 5/30/23 18:27, Uwe Kleine-König wrote:
> Hello Helge,
>
> On Tue, May 30, 2023 at 06:12:09PM +0200, Helge Deller wrote:
>> Btw... I cleaned up some minor whitespace issues in patch 3 (au1100fb).
>
> We both did some different cleanup, on top of your
> 87be5a5d9a5c5b00505181eedbee62134f07d11d we could further cleanup doing
>
> diff --git a/drivers/video/fbdev/au1100fb.c b/drivers/video/fbdev/au1100fb.c
> index fb38557a9b63..648d6cac86e8 100644
> --- a/drivers/video/fbdev/au1100fb.c
> +++ b/drivers/video/fbdev/au1100fb.c
> @@ -590,7 +590,7 @@ static struct platform_driver au1100fb_driver = {
> .probe = au1100fb_drv_probe,
> .remove_new = au1100fb_drv_remove,
> .suspend = au1100fb_drv_suspend,
> - .resume = au1100fb_drv_resume,
> + .resume = au1100fb_drv_resume,
> };
> module_platform_driver(au1100fb_driver);
>
> Feel free to squash this into 87be5a5d9a5c5b00505181eedbee62134f07d11d.
> If you want to apply it separately, either tell me to post a proper
> patch, or apply it under your name with my Suggested-by -- whatever
> suits you best.
I've squashed it into your patch.
Thanks!
Helge
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2023-05-30 16:36 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-18 23:53 [PATCH 00/51] video: fbdev: Convert to platform remove callback returning void Uwe Kleine-König
2023-03-18 23:54 ` [PATCH 30/51] video: fbdev: omapfb: " Uwe Kleine-König
2023-03-19 18:04 ` [PATCH 00/51] video: fbdev: " Helge Deller
2023-03-19 21:08 ` Uwe Kleine-König
2023-03-19 21:41 ` Helge Deller
2023-05-30 14:02 ` Uwe Kleine-König
2023-05-30 16:12 ` Helge Deller
2023-05-30 16:27 ` Uwe Kleine-König
2023-05-30 16:34 ` Helge Deller
2023-03-20 10:03 ` Thomas Zimmermann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox