From: "Joel Soete" <jsoe0708@tiscali.be>
To: "Randolph Chung" <tausq@debian.org>
Cc: parisc-linux@lists.parisc-linux.org
Subject: Re: [parisc-linux] Oops on 2.4.20-pa33
Date: Tue, 6 May 2003 19:33:28 +0200 [thread overview]
Message-ID: <3EB7766A000003D3@ocpmta7.freegates.net> (raw)
>> That is ok for me (even if I don't understand very well :( ; afaik the
>previous
>> code works fine for gcc<=3.1 and do not seems to concern 64bits? )
>
>The point is that if the new code is always correct, then littering
>the code with #ifdef's makes the code hard to read and maintain. If
>you really need to make the code different for the two cases, it's
>better to conditionally define a function/macro in a single place
>(header file) and use that in the source, rather than having ifdef's
>in many places.
>
>HTH,
Very clear now, but not easy to implement:
- which name to give to such a macro
- where to implement it:
the temptation to change the definition of SIG_IGN and SIG_DFL in asm-parisc/signal.h
is great but it will solve comparison pb but will broken variable affectation.
So may be better to define something like:
#define CMP_SIG( (x), (cmp), (y) ( (x) (cmp) (void*)(y) )
(but care have to be taken to always place SIG_... at the right (y) place?)
then change all occurences of SIG_... comparison??
There must be better idea else where but I ignore it :(
Also suggestion is welcome.
Thanks again,
Joel
---------------------------------
Vous surfez avec une ligne classique ?
Economisez jusqu'à 25% avec Tiscali Complete !
Offre spéciale : première année d'abonnement offerte.
... Plus d'info sur http://complete.tiscali.be
next reply other threads:[~2003-05-06 17:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-06 17:33 Joel Soete [this message]
2003-05-06 17:40 ` [parisc-linux] Oops on 2.4.20-pa33 Randolph Chung
-- strict thread matches above, loose matches on Subject: below --
2003-05-05 20:02 Jan-Benedict Glaw
2003-05-05 20:05 ` Randolph Chung
2003-05-06 6:04 ` Joel Soete
2003-05-06 14:04 ` Randolph Chung
2003-05-06 15:04 ` Joel Soete
2003-05-06 15:08 ` Randolph Chung
2003-05-06 16:34 ` Joel Soete
2003-05-06 16:42 ` John David Anglin
2003-05-06 17:56 ` Joel Soete
2003-05-07 15:48 ` Jan-Benedict Glaw
2003-05-07 16:09 ` Joel Soete
2003-05-07 17:17 ` Randolph Chung
2003-05-07 17:51 ` Jan-Benedict Glaw
2003-05-09 2:37 ` Andrew Shugg
2003-05-09 22:04 ` Jan-Benedict Glaw
2003-05-08 5:52 ` Joel Soete
2003-05-05 20:10 ` John David Anglin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EB7766A000003D3@ocpmta7.freegates.net \
--to=jsoe0708@tiscali.be \
--cc=parisc-linux@lists.parisc-linux.org \
--cc=tausq@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox