Linux PARISC architecture development
 help / color / mirror / Atom feed
From: Randolph Chung <randolph@tausq.org>
To: Joel Soete <jsoe0708@tiscali.be>
Cc: Jan-Benedict Glaw <jbglaw@lug-owl.de>,
	parisc-linux@lists.parisc-linux.org
Subject: Re: [parisc-linux] Oops on 2.4.20-pa33
Date: Tue, 6 May 2003 07:04:25 -0700	[thread overview]
Message-ID: <20030506140425.GF18309@tausq.org> (raw)
In-Reply-To: <3EB6425400000488@ocpmta7.freegates.net>

> AFAIK here is the full patch I suggested after some mail exchanges with Dave:
> 

I think willy already mentioned that:

> +#if !defined (__LP64__) && ((__GNUC__ > 3) || (__GNUC__ == 3 && __GNUC_MINOR__
> >= 1))
> +		if (ka->sa.sa_handler == (void *)SIG_IGN) {
> +#else
>  		if (ka->sa.sa_handler == SIG_IGN) {
> +#endif

is wrong.. just do

> +		if (ka->sa.sa_handler == (void *)SIG_IGN) {

unconditionally. don't put the ifdef's in.

can you post a cleaned up patch?

thanks,
randolph
-- 
Randolph Chung
Debian GNU/Linux Developer, hppa/ia64 ports
http://www.tausq.org/

  reply	other threads:[~2003-05-06 14:06 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-05 20:02 [parisc-linux] Oops on 2.4.20-pa33 Jan-Benedict Glaw
2003-05-05 20:05 ` Randolph Chung
2003-05-05 21:05   ` [parisc-linux] [PATCH-2.4] DIVA serial build error (was: Oops on 2.4.20-pa33) Jan-Benedict Glaw
2003-05-06 15:20     ` Jan-Benedict Glaw
2003-05-07 16:27       ` Paul Bame
2003-05-06  6:04   ` [parisc-linux] Oops on 2.4.20-pa33 Joel Soete
2003-05-06 14:04     ` Randolph Chung [this message]
2003-05-06 15:04       ` Joel Soete
2003-05-06 15:08         ` Randolph Chung
2003-05-06 16:34         ` Joel Soete
2003-05-06 16:42           ` John David Anglin
2003-05-06 17:56             ` Joel Soete
2003-05-07 15:48               ` Jan-Benedict Glaw
2003-05-07 16:09                 ` Joel Soete
2003-05-07 17:17                   ` Randolph Chung
2003-05-07 17:51                     ` Jan-Benedict Glaw
2003-05-09  2:37                       ` Andrew Shugg
2003-05-09 22:04                         ` Jan-Benedict Glaw
2003-05-08  5:52                     ` Joel Soete
2003-05-08  6:12               ` [parisc-linux] [PATCH-linux-2.5] sa_handler compare with cast Jan-Benedict Glaw
2003-05-10 20:31             ` [parisc-linux] Yet another '__canonicalize_funcptr_for_compare' pb Joel Soete
2003-05-10 20:25               ` Jan-Benedict Glaw
2003-05-10 21:08               ` Grant Grundler
2003-05-10 21:32                 ` John David Anglin
2003-05-10 21:33                 ` Joel Soete
2003-05-10 21:38                   ` [parisc-linux] Yet another '__canonicalize_funcptr_for_compare' John David Anglin
2003-05-10 21:21               ` [parisc-linux] Re: Yet another '__canonicalize_funcptr_for_compare' pb John David Anglin
2003-05-05 20:10 ` [parisc-linux] Oops on 2.4.20-pa33 John David Anglin
  -- strict thread matches above, loose matches on Subject: below --
2003-05-06 17:33 Joel Soete
2003-05-06 17:40 ` Randolph Chung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030506140425.GF18309@tausq.org \
    --to=randolph@tausq.org \
    --cc=jbglaw@lug-owl.de \
    --cc=jsoe0708@tiscali.be \
    --cc=parisc-linux@lists.parisc-linux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox