* [PATCH] drm/bridge: cdns-dsi: Select VIDEOMODE_HELPERS
@ 2025-08-21 20:52 Nathan Chancellor
2025-09-04 19:51 ` Nathan Chancellor
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Nathan Chancellor @ 2025-08-21 20:52 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, Devarsh Thakkar, Tomi Valkeinen,
Aradhya Bhatia
Cc: dri-devel, patches, Nathan Chancellor
When no other driver selects CONFIG_VIDEOMODE_HELPERS but
CONFIG_DRM_CDNS_DSI is enabled, there is a linker or modpost error:
ERROR: modpost: "drm_display_mode_to_videomode" [drivers/gpu/drm/bridge/cadence/cdns-dsi.ko] undefined!
Select VIDEOMODE_HELPERS to ensure that this helper function is
available to the driver.
Fixes: ce4bc5ca7c1d ("drm/bridge: cdns-dsi: Use video mode and clean up cdns_dsi_mode2cfg()")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
drivers/gpu/drm/bridge/cadence/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/bridge/cadence/Kconfig b/drivers/gpu/drm/bridge/cadence/Kconfig
index cced81633ddc..f1d8a8a151d8 100644
--- a/drivers/gpu/drm/bridge/cadence/Kconfig
+++ b/drivers/gpu/drm/bridge/cadence/Kconfig
@@ -6,6 +6,7 @@ config DRM_CDNS_DSI
select DRM_PANEL_BRIDGE
select GENERIC_PHY
select GENERIC_PHY_MIPI_DPHY
+ select VIDEOMODE_HELPERS
depends on OF
help
Support Cadence DPI to DSI bridge. This is an internal
---
base-commit: 3f13bcc886fc034113cb75cb32b8d9db1216b846
change-id: 20250821-cdns-videohelpers-71182a6145bc
Best regards,
--
Nathan Chancellor <nathan@kernel.org>
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/bridge: cdns-dsi: Select VIDEOMODE_HELPERS
2025-08-21 20:52 [PATCH] drm/bridge: cdns-dsi: Select VIDEOMODE_HELPERS Nathan Chancellor
@ 2025-09-04 19:51 ` Nathan Chancellor
2025-09-04 20:24 ` Dmitry Baryshkov
2025-09-04 20:35 ` Dmitry Baryshkov
2 siblings, 0 replies; 4+ messages in thread
From: Nathan Chancellor @ 2025-09-04 19:51 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, Devarsh Thakkar, Tomi Valkeinen,
Aradhya Bhatia
Cc: dri-devel, patches
Gentle ping, this seems fairly obvious and it continues to break out
builds in -next.
On Thu, Aug 21, 2025 at 01:52:12PM -0700, Nathan Chancellor wrote:
> When no other driver selects CONFIG_VIDEOMODE_HELPERS but
> CONFIG_DRM_CDNS_DSI is enabled, there is a linker or modpost error:
>
> ERROR: modpost: "drm_display_mode_to_videomode" [drivers/gpu/drm/bridge/cadence/cdns-dsi.ko] undefined!
>
> Select VIDEOMODE_HELPERS to ensure that this helper function is
> available to the driver.
>
> Fixes: ce4bc5ca7c1d ("drm/bridge: cdns-dsi: Use video mode and clean up cdns_dsi_mode2cfg()")
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> ---
> drivers/gpu/drm/bridge/cadence/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/bridge/cadence/Kconfig b/drivers/gpu/drm/bridge/cadence/Kconfig
> index cced81633ddc..f1d8a8a151d8 100644
> --- a/drivers/gpu/drm/bridge/cadence/Kconfig
> +++ b/drivers/gpu/drm/bridge/cadence/Kconfig
> @@ -6,6 +6,7 @@ config DRM_CDNS_DSI
> select DRM_PANEL_BRIDGE
> select GENERIC_PHY
> select GENERIC_PHY_MIPI_DPHY
> + select VIDEOMODE_HELPERS
> depends on OF
> help
> Support Cadence DPI to DSI bridge. This is an internal
>
> ---
> base-commit: 3f13bcc886fc034113cb75cb32b8d9db1216b846
> change-id: 20250821-cdns-videohelpers-71182a6145bc
>
> Best regards,
> --
> Nathan Chancellor <nathan@kernel.org>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/bridge: cdns-dsi: Select VIDEOMODE_HELPERS
2025-08-21 20:52 [PATCH] drm/bridge: cdns-dsi: Select VIDEOMODE_HELPERS Nathan Chancellor
2025-09-04 19:51 ` Nathan Chancellor
@ 2025-09-04 20:24 ` Dmitry Baryshkov
2025-09-04 20:35 ` Dmitry Baryshkov
2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2025-09-04 20:24 UTC (permalink / raw)
To: Nathan Chancellor
Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, Devarsh Thakkar, Tomi Valkeinen,
Aradhya Bhatia, dri-devel, patches
On Thu, Aug 21, 2025 at 01:52:12PM -0700, Nathan Chancellor wrote:
> When no other driver selects CONFIG_VIDEOMODE_HELPERS but
> CONFIG_DRM_CDNS_DSI is enabled, there is a linker or modpost error:
>
> ERROR: modpost: "drm_display_mode_to_videomode" [drivers/gpu/drm/bridge/cadence/cdns-dsi.ko] undefined!
>
> Select VIDEOMODE_HELPERS to ensure that this helper function is
> available to the driver.
>
> Fixes: ce4bc5ca7c1d ("drm/bridge: cdns-dsi: Use video mode and clean up cdns_dsi_mode2cfg()")
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> ---
> drivers/gpu/drm/bridge/cadence/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/bridge: cdns-dsi: Select VIDEOMODE_HELPERS
2025-08-21 20:52 [PATCH] drm/bridge: cdns-dsi: Select VIDEOMODE_HELPERS Nathan Chancellor
2025-09-04 19:51 ` Nathan Chancellor
2025-09-04 20:24 ` Dmitry Baryshkov
@ 2025-09-04 20:35 ` Dmitry Baryshkov
2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2025-09-04 20:35 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, Devarsh Thakkar, Tomi Valkeinen,
Aradhya Bhatia, Nathan Chancellor
Cc: dri-devel, patches
On Thu, 21 Aug 2025 13:52:12 -0700, Nathan Chancellor wrote:
> When no other driver selects CONFIG_VIDEOMODE_HELPERS but
> CONFIG_DRM_CDNS_DSI is enabled, there is a linker or modpost error:
>
> ERROR: modpost: "drm_display_mode_to_videomode" [drivers/gpu/drm/bridge/cadence/cdns-dsi.ko] undefined!
>
> Select VIDEOMODE_HELPERS to ensure that this helper function is
> available to the driver.
>
> [...]
Applied to drm-misc-next, thanks!
[1/1] drm/bridge: cdns-dsi: Select VIDEOMODE_HELPERS
commit: 28fa7f5243c02a812af50707c9805c2b57deceeb
Best regards,
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-09-04 20:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-21 20:52 [PATCH] drm/bridge: cdns-dsi: Select VIDEOMODE_HELPERS Nathan Chancellor
2025-09-04 19:51 ` Nathan Chancellor
2025-09-04 20:24 ` Dmitry Baryshkov
2025-09-04 20:35 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox