From: Damien Le Moal <dlemoal@kernel.org>
To: "Niklas Cassel" <cassel@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
bhelgaas@google.com, linux-pci@vger.kernel.org,
Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Subject: Re: [PATCH 3/4] misc: pci_endpoint_test: Let PCITEST_{READ,WRITE,COPY} set IRQ type automatically
Date: Tue, 25 Mar 2025 03:36:51 +0900 [thread overview]
Message-ID: <019712df-e973-4dc3-89c2-d41ef51e405b@kernel.org> (raw)
In-Reply-To: <Z+Giej6/jpSHSV3H@x1-carbon>
On 3/25/25 03:20, Niklas Cassel wrote:
> Hello Krzysztof,
>
> On Sun, Mar 23, 2025 at 08:34:49PM +0900, Krzysztof Wilczyński wrote:
>> [...]
>>> I still need to send a patch that fixes the kdoc.
>>
>> Feel free to let me know what kernel-doc you want added there. I will, in
>> the mean time, go ahead and add something.
>
> We already have:
>
> * @msi_capable: indicate if the endpoint function has MSI capability
> * @msix_capable: indicate if the endpoint function has MSI-X capability
>
> How about:
>
> intx_capable: indicate if the endpoint can raise INTx interrupts
It feels like we should just have a @irq_capability field that combines
PCI_IRQ_xxx flags to indicate the type(s) of IRQ supported by the controller.
That would be way cleaner than one boolean per type :)
>
>
> Kind regards,
> Niklas
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2025-03-24 18:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 10:33 [PATCH 0/4] pci_endpoint_test: Let PCITEST_{READ,WRITE,COPY} set IRQ type automatically Niklas Cassel
2025-03-18 10:33 ` [PATCH 1/4] Revert "misc: pci_endpoint_test: Add support for PCITEST_IRQ_TYPE_AUTO" Niklas Cassel
2025-03-18 10:33 ` [PATCH 2/4] misc: pci_endpoint_test: Fetch supported IRQ types in CAPS register Niklas Cassel
2025-03-18 10:33 ` [PATCH 3/4] misc: pci_endpoint_test: Let PCITEST_{READ,WRITE,COPY} set IRQ type automatically Niklas Cassel
2025-03-20 15:27 ` Manivannan Sadhasivam
2025-03-21 13:27 ` Niklas Cassel
2025-03-22 2:24 ` Manivannan Sadhasivam
2025-03-22 5:31 ` Niklas Cassel
2025-03-23 11:34 ` Krzysztof Wilczyński
2025-03-24 18:20 ` Niklas Cassel
2025-03-24 18:36 ` Damien Le Moal [this message]
2025-03-26 6:23 ` Krzysztof Wilczyński
2025-03-26 14:39 ` Niklas Cassel
2025-03-26 16:17 ` Manivannan Sadhasivam
2025-03-26 19:22 ` Niklas Cassel
2025-03-26 19:58 ` Bjorn Helgaas
2025-04-02 7:24 ` Manivannan Sadhasivam
2025-03-18 10:33 ` [PATCH 4/4] selftests: pci_endpoint: Remove PCITEST_SET_IRQTYPE ioctls for read/write/copy Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=019712df-e973-4dc3-89c2-d41ef51e405b@kernel.org \
--to=dlemoal@kernel.org \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=hayashi.kunihiko@socionext.com \
--cc=kw@linux.com \
--cc=linux-pci@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox