Re: [PATCH 3/4] misc: pci_endpoint_test: Let PCITEST_{READ,WRITE,COPY} set IRQ type automatically

["Krzysztof Wilczyński" <kw@linux.com>]

Hello,

> >> I'm really (honestly) happy with whatever solution, as long as we, once again,
> >> handle EPCs that only support INTx, or only support MSI-X.
> >> 
> >
> >We will keep your old series as it is.
> >
> >> (Because ever since your patch series that migrated pcitest to selftests,
> >> READ_TEST / WRITE_TEST / COPY_TEST test cases unconditionally use MSI, which
> >> is a regression for EPCs that only support INTx, or only support MSI-X,
> >> which is the whole reason why I wrote this series.)
> >> 
> >
> >IMO, the regression could be simply fixed if you have removed the ASSERT_EQ from
> >READ/WRITE/COPY testcases.
> >
> >But anyway, all good now. Thanks a lot for your patience in educating me :)
> >Really appreciated.
> 
> Don't say it like that :)
> 
> I understand where you were coming from.
> I think if we designed the API today, we would have kept it as one ioctl, and user space could have provided the IRQ type (and/or auto) as a struct member in the struct supplied in the ioctl.

Nobody would object to a refactor, I believe.  Especially, where it makes
sense to fix some old technical debt.

[...]
> I still need to send a patch that fixes the kdoc.

Feel free to let me know what kernel-doc you want added there.  I will, in
the mean time, go ahead and add something.

Thank you!

	Krzysztof