Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Niklas Cassel <cassel@kernel.org>
To: bhelgaas@google.com, kw@linux.com, manivannan.sadhasivam@linaro.org
Cc: linux-pci@vger.kernel.org, Damien Le Moal <dlemoal@kernel.org>,
	Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
	Niklas Cassel <cassel@kernel.org>
Subject: [PATCH 4/4] selftests: pci_endpoint: Remove PCITEST_SET_IRQTYPE ioctls for read/write/copy
Date: Tue, 18 Mar 2025 11:33:35 +0100	[thread overview]
Message-ID: <20250318103330.1840678-10-cassel@kernel.org> (raw)
In-Reply-To: <20250318103330.1840678-6-cassel@kernel.org>

The test cases for read/write/copy currently do:
1) ioctl(PCITEST_SET_IRQTYPE)
2) ioctl(PCITEST_{READ,WRITE,COPY})

The PCITEST_{READ,WRITE,COPY} ioctls now configure the IRQ type to use
themselves, ignoring any value configured by the user via
ioctl(PCITEST_SET_IRQTYPE).

Since PCITEST_{READ,WRITE,COPY} ioctls will ignore the IRQ type set by the
user, remove the ioctl(PCITEST_SET_IRQTYPE), as it has no effect on the
result of the test case.

Signed-off-by: Niklas Cassel <cassel@kernel.org>
---
 tools/testing/selftests/pci_endpoint/pci_endpoint_test.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/tools/testing/selftests/pci_endpoint/pci_endpoint_test.c b/tools/testing/selftests/pci_endpoint/pci_endpoint_test.c
index fdf4bc6aa9d2a..e788ab4eb003e 100644
--- a/tools/testing/selftests/pci_endpoint/pci_endpoint_test.c
+++ b/tools/testing/selftests/pci_endpoint/pci_endpoint_test.c
@@ -181,9 +181,6 @@ TEST_F(pci_ep_data_transfer, READ_TEST)
 	if (variant->use_dma)
 		param.flags = PCITEST_FLAGS_USE_DMA;
 
-	pci_ep_ioctl(PCITEST_SET_IRQTYPE, PCITEST_IRQ_TYPE_MSI);
-	ASSERT_EQ(0, ret) TH_LOG("Can't set MSI IRQ type");
-
 	for (i = 0; i < ARRAY_SIZE(test_size); i++) {
 		param.size = test_size[i];
 		pci_ep_ioctl(PCITEST_READ, &param);
@@ -200,9 +197,6 @@ TEST_F(pci_ep_data_transfer, WRITE_TEST)
 	if (variant->use_dma)
 		param.flags = PCITEST_FLAGS_USE_DMA;
 
-	pci_ep_ioctl(PCITEST_SET_IRQTYPE, PCITEST_IRQ_TYPE_MSI);
-	ASSERT_EQ(0, ret) TH_LOG("Can't set MSI IRQ type");
-
 	for (i = 0; i < ARRAY_SIZE(test_size); i++) {
 		param.size = test_size[i];
 		pci_ep_ioctl(PCITEST_WRITE, &param);
@@ -219,9 +213,6 @@ TEST_F(pci_ep_data_transfer, COPY_TEST)
 	if (variant->use_dma)
 		param.flags = PCITEST_FLAGS_USE_DMA;
 
-	pci_ep_ioctl(PCITEST_SET_IRQTYPE, PCITEST_IRQ_TYPE_MSI);
-	ASSERT_EQ(0, ret) TH_LOG("Can't set MSI IRQ type");
-
 	for (i = 0; i < ARRAY_SIZE(test_size); i++) {
 		param.size = test_size[i];
 		pci_ep_ioctl(PCITEST_COPY, &param);
-- 
2.48.1


      parent reply	other threads:[~2025-03-18 10:34 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-18 10:33 [PATCH 0/4] pci_endpoint_test: Let PCITEST_{READ,WRITE,COPY} set IRQ type automatically Niklas Cassel
2025-03-18 10:33 ` [PATCH 1/4] Revert "misc: pci_endpoint_test: Add support for PCITEST_IRQ_TYPE_AUTO" Niklas Cassel
2025-03-18 10:33 ` [PATCH 2/4] misc: pci_endpoint_test: Fetch supported IRQ types in CAPS register Niklas Cassel
2025-03-18 10:33 ` [PATCH 3/4] misc: pci_endpoint_test: Let PCITEST_{READ,WRITE,COPY} set IRQ type automatically Niklas Cassel
2025-03-20 15:27   ` Manivannan Sadhasivam
2025-03-21 13:27     ` Niklas Cassel
2025-03-22  2:24       ` Manivannan Sadhasivam
2025-03-22  5:31         ` Niklas Cassel
2025-03-23 11:34           ` Krzysztof Wilczyński
2025-03-24 18:20             ` Niklas Cassel
2025-03-24 18:36               ` Damien Le Moal
2025-03-26  6:23               ` Krzysztof Wilczyński
2025-03-26 14:39           ` Niklas Cassel
2025-03-26 16:17             ` Manivannan Sadhasivam
2025-03-26 19:22               ` Niklas Cassel
2025-03-26 19:58                 ` Bjorn Helgaas
2025-04-02  7:24                 ` Manivannan Sadhasivam
2025-03-18 10:33 ` Niklas Cassel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250318103330.1840678-10-cassel@kernel.org \
    --to=cassel@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=dlemoal@kernel.org \
    --cc=hayashi.kunihiko@socionext.com \
    --cc=kw@linux.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox