From: "Arnd Bergmann" <arnd@arndb.de>
To: "Philipp Stanner" <pstanner@redhat.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Dan Williams" <dan.j.williams@intel.com>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Dave Jiang" <dave.jiang@intel.com>,
"Uladzislau Koshchanka" <koshchanka@gmail.com>,
"Neil Brown" <neilb@suse.de>,
"Niklas Schnelle" <schnelle@linux.ibm.com>,
"John Sanpe" <sanpeqf@gmail.com>,
"Kent Overstreet" <kent.overstreet@gmail.com>,
"Masami Hiramatsu" <mhiramat@kernel.org>,
"Kees Cook" <keescook@chromium.org>,
"David Gow" <davidgow@google.com>,
"Yury Norov" <yury.norov@gmail.com>,
"wuqiang.matt" <wuqiang.matt@bytedance.com>,
"Jason Baron" <jbaron@akamai.com>,
"Kefeng Wang" <wangkefeng.wang@huawei.com>,
"Ben Dooks" <ben.dooks@codethink.co.uk>,
"Danilo Krummrich" <dakr@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
Linux-Arch <linux-arch@vger.kernel.org>
Subject: Re: [PATCH v2 1/4] lib: move pci_iomap.c to drivers/pci/
Date: Fri, 01 Dec 2023 23:17:47 +0100 [thread overview]
Message-ID: <0ed157c7-e0be-43d9-afb1-2bd53b934f56@app.fastmail.com> (raw)
In-Reply-To: <4bf46893a583551c71bdfbf91df9ccc4b51556b1.camel@redhat.com>
On Fri, Dec 1, 2023, at 19:56, Philipp Stanner wrote:
> On Fri, 2023-12-01 at 15:43 +0100, Arnd Bergmann wrote:
>> On Fri, Dec 1, 2023, at 13:16, Philipp Stanner wrote:
>> >
>> > -#ifdef CONFIG_PCI
>> > /**
>>
>> You should not remove the #ifdef here, it probably results in
>> a build failure when CONFIG_GENERIC_PCI_IOMAP is set and
>> GENERIC_PCI is not.
>
> CONFIG_PCI you mean.
> Yes, that results in a build failure. That's what the Intel bots have
> reminded me of subtly before, which is why I:
>
>>
>> Alternatively you could use Kconfig or Makefile logic to
>> prevent the file from being built without CONFIG_PCI.
>
> did exactly that in this very patch:
>
> @@ -14,6 +14,7 @@ ifdef CONFIG_PCI <------------
> obj-$(CONFIG_PROC_FS) += proc.o
> obj-$(CONFIG_SYSFS) += slot.o
> obj-$(CONFIG_ACPI) += pci-acpi.o
> +obj-$(CONFIG_GENERIC_PCI_IOMAP) += iomap.o <-----------
> endif
Ok, got it, looks good then.
Arnd
next prev parent reply other threads:[~2023-12-01 22:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 12:16 [PATCH v2 0/4] Regather scattered PCI-Code Philipp Stanner
2023-12-01 12:16 ` [PATCH v2 1/4] lib: move pci_iomap.c to drivers/pci/ Philipp Stanner
2023-12-01 14:43 ` Arnd Bergmann
2023-12-01 18:56 ` Philipp Stanner
2023-12-01 22:17 ` Arnd Bergmann [this message]
2023-12-01 12:16 ` [PATCH v2 2/4] lib: move pci-specific devres code " Philipp Stanner
2023-12-01 14:44 ` Arnd Bergmann
2023-12-01 19:00 ` Philipp Stanner
2023-12-01 22:31 ` Arnd Bergmann
2023-12-01 12:16 ` [PATCH v2 3/4] pci: move devres code from pci.c to devres.c Philipp Stanner
2023-12-01 12:16 ` [PATCH v2 4/4] lib, pci: unify generic pci_iounmap() Philipp Stanner
2023-12-01 15:26 ` Arnd Bergmann
2023-12-01 19:37 ` Philipp Stanner
2023-12-01 21:32 ` Arnd Bergmann
2023-12-01 21:56 ` Philipp Stanner
2023-12-01 21:59 ` Arnd Bergmann
2023-12-01 16:27 ` [PATCH v2 0/4] Regather scattered PCI-Code Arnd Bergmann
2023-12-01 19:09 ` Philipp Stanner
2023-12-01 22:17 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ed157c7-e0be-43d9-afb1-2bd53b934f56@app.fastmail.com \
--to=arnd@arndb.de \
--cc=Jonathan.Cameron@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=ben.dooks@codethink.co.uk \
--cc=bhelgaas@google.com \
--cc=dakr@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=davidgow@google.com \
--cc=jbaron@akamai.com \
--cc=keescook@chromium.org \
--cc=kent.overstreet@gmail.com \
--cc=koshchanka@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=neilb@suse.de \
--cc=pstanner@redhat.com \
--cc=sanpeqf@gmail.com \
--cc=schnelle@linux.ibm.com \
--cc=wangkefeng.wang@huawei.com \
--cc=wuqiang.matt@bytedance.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox