* [PATCH] pci: Remove unnecessary dependency between PME and ACPI. @ 2013-02-21 15:53 Andrew Murray 2013-04-11 23:44 ` Bjorn Helgaas 0 siblings, 1 reply; 5+ messages in thread From: Andrew Murray @ 2013-02-21 15:53 UTC (permalink / raw) To: linux-pci Cc: bhelgaas@google.com, thierry.reding@avionic-design.de, thomas.petazzoni@free-electrons.com, jbarnes@virtuousgeek.org Signed-off-by: Andrew Murray <Andrew.Murray@arm.com> Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com> --- drivers/pci/pcie/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/pci/pcie/Kconfig b/drivers/pci/pcie/Kconfig index 6c8bc58..4cccd8c 100644 --- a/drivers/pci/pcie/Kconfig +++ b/drivers/pci/pcie/Kconfig @@ -82,4 +82,4 @@ endchoice config PCIE_PME def_bool y - depends on PCIEPORTBUS && PM_RUNTIME && EXPERIMENTAL && ACPI + depends on PCIEPORTBUS && PM_RUNTIME && EXPERIMENTAL -- 1.7.0.4 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] pci: Remove unnecessary dependency between PME and ACPI. 2013-02-21 15:53 [PATCH] pci: Remove unnecessary dependency between PME and ACPI Andrew Murray @ 2013-04-11 23:44 ` Bjorn Helgaas 2013-04-12 7:42 ` Andrew Murray 2013-04-12 11:13 ` Rafael J. Wysocki 0 siblings, 2 replies; 5+ messages in thread From: Bjorn Helgaas @ 2013-04-11 23:44 UTC (permalink / raw) To: Andrew Murray Cc: linux-pci, thierry.reding@avionic-design.de, thomas.petazzoni@free-electrons.com, jbarnes@virtuousgeek.org, linux-acpi, Rafael J. Wysocki On Thu, Feb 21, 2013 at 03:53:29PM +0000, Andrew Murray wrote: > Signed-off-by: Andrew Murray <Andrew.Murray@arm.com> > Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com> > --- > drivers/pci/pcie/Kconfig | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/pci/pcie/Kconfig b/drivers/pci/pcie/Kconfig > index 6c8bc58..4cccd8c 100644 > --- a/drivers/pci/pcie/Kconfig > +++ b/drivers/pci/pcie/Kconfig > @@ -82,4 +82,4 @@ endchoice > > config PCIE_PME > def_bool y > - depends on PCIEPORTBUS && PM_RUNTIME && EXPERIMENTAL && ACPI > + depends on PCIEPORTBUS && PM_RUNTIME && EXPERIMENTAL I think we can go even further and remove the ACPI-related #includes as in the patch below. Any objections to this? commit 8bde83b5f5519b630e7630fb735f76c184c74289 Author: Bjorn Helgaas <bhelgaas@google.com> Date: Thu Apr 11 17:36:50 2013 -0600 PCI: Remove unnecessary dependencies between PME and ACPI PCIe PME doesn't depend on ACPI, so remove the #includes and Kconfig dependency. Based-on-patch-by: Andrew Murray <Andrew.Murray@arm.com> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> diff --git a/drivers/pci/pcie/Kconfig b/drivers/pci/pcie/Kconfig index fde4a32..569f82f 100644 --- a/drivers/pci/pcie/Kconfig +++ b/drivers/pci/pcie/Kconfig @@ -82,4 +82,4 @@ endchoice config PCIE_PME def_bool y - depends on PCIEPORTBUS && PM_RUNTIME && ACPI + depends on PCIEPORTBUS && PM_RUNTIME diff --git a/drivers/pci/pcie/pme.c b/drivers/pci/pcie/pme.c index 9ca0dc9..795db1f 100644 --- a/drivers/pci/pcie/pme.c +++ b/drivers/pci/pcie/pme.c @@ -19,8 +19,6 @@ #include <linux/interrupt.h> #include <linux/device.h> #include <linux/pcieport_if.h> -#include <linux/acpi.h> -#include <linux/pci-acpi.h> #include <linux/pm_runtime.h> #include "../pci.h" ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] pci: Remove unnecessary dependency between PME and ACPI. 2013-04-11 23:44 ` Bjorn Helgaas @ 2013-04-12 7:42 ` Andrew Murray 2013-04-12 11:13 ` Rafael J. Wysocki 1 sibling, 0 replies; 5+ messages in thread From: Andrew Murray @ 2013-04-12 7:42 UTC (permalink / raw) To: Bjorn Helgaas Cc: linux-pci@vger.kernel.org, thierry.reding@avionic-design.de, thomas.petazzoni@free-electrons.com, jbarnes@virtuousgeek.org, linux-acpi@vger.kernel.org, Rafael J. Wysocki On Fri, Apr 12, 2013 at 12:44:26AM +0100, Bjorn Helgaas wrote: > On Thu, Feb 21, 2013 at 03:53:29PM +0000, Andrew Murray wrote: > > Signed-off-by: Andrew Murray <Andrew.Murray@arm.com> > > Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com> > > --- > > drivers/pci/pcie/Kconfig | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/pci/pcie/Kconfig b/drivers/pci/pcie/Kconfig > > index 6c8bc58..4cccd8c 100644 > > --- a/drivers/pci/pcie/Kconfig > > +++ b/drivers/pci/pcie/Kconfig > > @@ -82,4 +82,4 @@ endchoice > > > > config PCIE_PME > > def_bool y > > - depends on PCIEPORTBUS && PM_RUNTIME && EXPERIMENTAL && ACPI > > + depends on PCIEPORTBUS && PM_RUNTIME && EXPERIMENTAL > > I think we can go even further and remove the ACPI-related #includes > as in the patch below. Any objections to this? > > > commit 8bde83b5f5519b630e7630fb735f76c184c74289 > Author: Bjorn Helgaas <bhelgaas@google.com> > Date: Thu Apr 11 17:36:50 2013 -0600 > > PCI: Remove unnecessary dependencies between PME and ACPI > > PCIe PME doesn't depend on ACPI, so remove the #includes and > Kconfig dependency. > > Based-on-patch-by: Andrew Murray <Andrew.Murray@arm.com> > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> > > diff --git a/drivers/pci/pcie/Kconfig b/drivers/pci/pcie/Kconfig > index fde4a32..569f82f 100644 > --- a/drivers/pci/pcie/Kconfig > +++ b/drivers/pci/pcie/Kconfig > @@ -82,4 +82,4 @@ endchoice > > config PCIE_PME > def_bool y > - depends on PCIEPORTBUS && PM_RUNTIME && ACPI > + depends on PCIEPORTBUS && PM_RUNTIME > diff --git a/drivers/pci/pcie/pme.c b/drivers/pci/pcie/pme.c > index 9ca0dc9..795db1f 100644 > --- a/drivers/pci/pcie/pme.c > +++ b/drivers/pci/pcie/pme.c > @@ -19,8 +19,6 @@ > #include <linux/interrupt.h> > #include <linux/device.h> > #include <linux/pcieport_if.h> > -#include <linux/acpi.h> > -#include <linux/pci-acpi.h> > #include <linux/pm_runtime.h> > > #include "../pci.h" > -- Looks good to me. Andrew Murray > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] pci: Remove unnecessary dependency between PME and ACPI. 2013-04-11 23:44 ` Bjorn Helgaas 2013-04-12 7:42 ` Andrew Murray @ 2013-04-12 11:13 ` Rafael J. Wysocki 2013-04-12 19:03 ` Bjorn Helgaas 1 sibling, 1 reply; 5+ messages in thread From: Rafael J. Wysocki @ 2013-04-12 11:13 UTC (permalink / raw) To: Bjorn Helgaas Cc: Andrew Murray, linux-pci, thierry.reding@avionic-design.de, thomas.petazzoni@free-electrons.com, jbarnes@virtuousgeek.org, linux-acpi On Thursday, April 11, 2013 05:44:26 PM Bjorn Helgaas wrote: > On Thu, Feb 21, 2013 at 03:53:29PM +0000, Andrew Murray wrote: > > Signed-off-by: Andrew Murray <Andrew.Murray@arm.com> > > Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com> > > --- > > drivers/pci/pcie/Kconfig | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/pci/pcie/Kconfig b/drivers/pci/pcie/Kconfig > > index 6c8bc58..4cccd8c 100644 > > --- a/drivers/pci/pcie/Kconfig > > +++ b/drivers/pci/pcie/Kconfig > > @@ -82,4 +82,4 @@ endchoice > > > > config PCIE_PME > > def_bool y > > - depends on PCIEPORTBUS && PM_RUNTIME && EXPERIMENTAL && ACPI > > + depends on PCIEPORTBUS && PM_RUNTIME && EXPERIMENTAL > > I think we can go even further and remove the ACPI-related #includes > as in the patch below. Any objections to this? > > > commit 8bde83b5f5519b630e7630fb735f76c184c74289 > Author: Bjorn Helgaas <bhelgaas@google.com> > Date: Thu Apr 11 17:36:50 2013 -0600 > > PCI: Remove unnecessary dependencies between PME and ACPI > > PCIe PME doesn't depend on ACPI, so remove the #includes and > Kconfig dependency. > > Based-on-patch-by: Andrew Murray <Andrew.Murray@arm.com> > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > diff --git a/drivers/pci/pcie/Kconfig b/drivers/pci/pcie/Kconfig > index fde4a32..569f82f 100644 > --- a/drivers/pci/pcie/Kconfig > +++ b/drivers/pci/pcie/Kconfig > @@ -82,4 +82,4 @@ endchoice > > config PCIE_PME > def_bool y > - depends on PCIEPORTBUS && PM_RUNTIME && ACPI > + depends on PCIEPORTBUS && PM_RUNTIME > diff --git a/drivers/pci/pcie/pme.c b/drivers/pci/pcie/pme.c > index 9ca0dc9..795db1f 100644 > --- a/drivers/pci/pcie/pme.c > +++ b/drivers/pci/pcie/pme.c > @@ -19,8 +19,6 @@ > #include <linux/interrupt.h> > #include <linux/device.h> > #include <linux/pcieport_if.h> > -#include <linux/acpi.h> > -#include <linux/pci-acpi.h> > #include <linux/pm_runtime.h> > > #include "../pci.h" > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] pci: Remove unnecessary dependency between PME and ACPI. 2013-04-12 11:13 ` Rafael J. Wysocki @ 2013-04-12 19:03 ` Bjorn Helgaas 0 siblings, 0 replies; 5+ messages in thread From: Bjorn Helgaas @ 2013-04-12 19:03 UTC (permalink / raw) To: Rafael J. Wysocki Cc: Andrew Murray, linux-pci@vger.kernel.org, thierry.reding@avionic-design.de, thomas.petazzoni@free-electrons.com, jbarnes@virtuousgeek.org, linux-acpi@vger.kernel.org On Fri, Apr 12, 2013 at 5:13 AM, Rafael J. Wysocki <rjw@sisk.pl> wrote: > On Thursday, April 11, 2013 05:44:26 PM Bjorn Helgaas wrote: >> On Thu, Feb 21, 2013 at 03:53:29PM +0000, Andrew Murray wrote: >> > Signed-off-by: Andrew Murray <Andrew.Murray@arm.com> >> > Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com> >> > --- >> > drivers/pci/pcie/Kconfig | 2 +- >> > 1 files changed, 1 insertions(+), 1 deletions(-) >> > >> > diff --git a/drivers/pci/pcie/Kconfig b/drivers/pci/pcie/Kconfig >> > index 6c8bc58..4cccd8c 100644 >> > --- a/drivers/pci/pcie/Kconfig >> > +++ b/drivers/pci/pcie/Kconfig >> > @@ -82,4 +82,4 @@ endchoice >> > >> > config PCIE_PME >> > def_bool y >> > - depends on PCIEPORTBUS && PM_RUNTIME && EXPERIMENTAL && ACPI >> > + depends on PCIEPORTBUS && PM_RUNTIME && EXPERIMENTAL >> >> I think we can go even further and remove the ACPI-related #includes >> as in the patch below. Any objections to this? >> >> >> commit 8bde83b5f5519b630e7630fb735f76c184c74289 >> Author: Bjorn Helgaas <bhelgaas@google.com> >> Date: Thu Apr 11 17:36:50 2013 -0600 >> >> PCI: Remove unnecessary dependencies between PME and ACPI >> >> PCIe PME doesn't depend on ACPI, so remove the #includes and >> Kconfig dependency. >> >> Based-on-patch-by: Andrew Murray <Andrew.Murray@arm.com> >> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> > > Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> I applied this for v3.10, thanks! Bjorn >> diff --git a/drivers/pci/pcie/Kconfig b/drivers/pci/pcie/Kconfig >> index fde4a32..569f82f 100644 >> --- a/drivers/pci/pcie/Kconfig >> +++ b/drivers/pci/pcie/Kconfig >> @@ -82,4 +82,4 @@ endchoice >> >> config PCIE_PME >> def_bool y >> - depends on PCIEPORTBUS && PM_RUNTIME && ACPI >> + depends on PCIEPORTBUS && PM_RUNTIME >> diff --git a/drivers/pci/pcie/pme.c b/drivers/pci/pcie/pme.c >> index 9ca0dc9..795db1f 100644 >> --- a/drivers/pci/pcie/pme.c >> +++ b/drivers/pci/pcie/pme.c >> @@ -19,8 +19,6 @@ >> #include <linux/interrupt.h> >> #include <linux/device.h> >> #include <linux/pcieport_if.h> >> -#include <linux/acpi.h> >> -#include <linux/pci-acpi.h> >> #include <linux/pm_runtime.h> >> >> #include "../pci.h" >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > -- > I speak only for myself. > Rafael J. Wysocki, Intel Open Source Technology Center. ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-04-12 19:03 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-02-21 15:53 [PATCH] pci: Remove unnecessary dependency between PME and ACPI Andrew Murray 2013-04-11 23:44 ` Bjorn Helgaas 2013-04-12 7:42 ` Andrew Murray 2013-04-12 11:13 ` Rafael J. Wysocki 2013-04-12 19:03 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox