[PATCH v2 0/2] PCI: rockchip: Cleanup

[PATCH v2 0/2] PCI: rockchip: Cleanup

[Bjorn Helgaas]

  - Remove platform drvdata because it appears unused (we called
    platform_set_drvdata() but not platform_get_drvdata()).

Nothing here should change the behavior of the driver.

Changes from v1:
  Added Dan's indentation fix.
  I dropped the following patches because they were a lot of churn for
  questionable benefit:
    PCI: rockchip: Rename accessors
    PCI: rockchip: Swap order of rockchip_writel() reg/val arguments

---

Bjorn Helgaas (1):
      PCI: rockchip: Remove unused platform data

Dan Carpenter (1):
      PCI: rockchip: Indent "if" statement body


 drivers/pci/host/pcie-rockchip.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

[PATCH v2 1/2] PCI: rockchip: Remove unused platform data

[Bjorn Helgaas]

The rockchip driver never uses the platform drvdata pointer, so don't
bother setting it.  No functional change intended.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Shawn Lin <shawn.lin@rock-chips.com>
---
 drivers/pci/host/pcie-rockchip.c |    2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/pci/host/pcie-rockchip.c b/drivers/pci/host/pcie-rockchip.c
index b8c82fc..59bf0db 100644
--- a/drivers/pci/host/pcie-rockchip.c
+++ b/drivers/pci/host/pcie-rockchip.c
@@ -1091,8 +1091,6 @@ static int rockchip_pcie_probe(struct platform_device *pdev)
 	if (err)
 		goto err_vpcie;
 
-	platform_set_drvdata(pdev, rockchip);
-
 	rockchip_pcie_enable_interrupts(rockchip);
 
 	err = rockchip_pcie_init_irq_domain(rockchip);

[PATCH v2 2/2] PCI: rockchip: Indent "if" statement body

[Bjorn Helgaas]

From: Dan Carpenter <dan.carpenter@oracle.com>

Body of an "if" statement wasn't indented.  Add a tab.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
 drivers/pci/host/pcie-rockchip.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/host/pcie-rockchip.c b/drivers/pci/host/pcie-rockchip.c
index 59bf0db..e0b22da 100644
--- a/drivers/pci/host/pcie-rockchip.c
+++ b/drivers/pci/host/pcie-rockchip.c
@@ -972,7 +972,7 @@ static int rockchip_pcie_prog_ob_atu(struct rockchip_pcie *rockchip,
 		return -EINVAL;
 	if (region_no == 0) {
 		if (AXI_REGION_0_SIZE < (2ULL << num_pass_bits))
-		return -EINVAL;
+			return -EINVAL;
 	}
 	if (region_no != 0) {
 		if (AXI_REGION_SIZE < (2ULL << num_pass_bits))

Re: [PATCH v2 0/2] PCI: rockchip: Cleanup

[Bjorn Helgaas]

On Wed, Oct 12, 2016 at 08:04:16AM -0500, Bjorn Helgaas wrote:
>   - Remove platform drvdata because it appears unused (we called
>     platform_set_drvdata() but not platform_get_drvdata()).
> 
> Nothing here should change the behavior of the driver.
> 
> Changes from v1:
>   Added Dan's indentation fix.
>   I dropped the following patches because they were a lot of churn for
>   questionable benefit:
>     PCI: rockchip: Rename accessors
>     PCI: rockchip: Swap order of rockchip_writel() reg/val arguments
> 
> ---
> 
> Bjorn Helgaas (1):
>       PCI: rockchip: Remove unused platform data
> 
> Dan Carpenter (1):
>       PCI: rockchip: Indent "if" statement body

I applied these to pci/host-rockchip for v4.9.  I hope to ask Linus to
pull them tomorrow, so if you see any issues, let me know soon.

Re: [PATCH v2 0/2] PCI: rockchip: Cleanup

[Shawn Lin]

Hi Bjorn,

On 2016/10/13 0:02, Bjorn Helgaas wrote:
> On Wed, Oct 12, 2016 at 08:04:16AM -0500, Bjorn Helgaas wrote:
>>   - Remove platform drvdata because it appears unused (we called
>>     platform_set_drvdata() but not platform_get_drvdata()).
>>
>> Nothing here should change the behavior of the driver.
>>
>> Changes from v1:
>>   Added Dan's indentation fix.
>>   I dropped the following patches because they were a lot of churn for
>>   questionable benefit:
>>     PCI: rockchip: Rename accessors
>>     PCI: rockchip: Swap order of rockchip_writel() reg/val arguments
>>
>> ---
>>
>> Bjorn Helgaas (1):
>>       PCI: rockchip: Remove unused platform data
>>
>> Dan Carpenter (1):
>>       PCI: rockchip: Indent "if" statement body
>
> I applied these to pci/host-rockchip for v4.9.  I hope to ask Linus to
> pull them tomorrow, so if you see any issues, let me know soon.

Seems the first round of cleanup for host-rockchip again v10 when this
driver got merged was incorrectly changed. The issue wasn't exposed as
it's just a debug log which was easily overlooked.

So could you pick the  patch[0] to fix this problem ? :)

[0]: https://patchwork.kernel.org/patch/9374129/

> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>


-- 
Best Regards
Shawn Lin