* [PATCH] PCI/switchtec: Correct bool variable type assignment
@ 2020-05-21 20:04 Krzysztof Wilczynski
2020-05-21 20:06 ` Logan Gunthorpe
2020-05-21 20:23 ` Bjorn Helgaas
0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Wilczynski @ 2020-05-21 20:04 UTC (permalink / raw)
To: Kurt Schwemmer; +Cc: Bjorn Helgaas, Logan Gunthorpe, linux-pci
Use true instead of 1 in the assignment as the variable use_dma_mrpc is
of a bool type. Also, resolve the following Coccinelle warning:
drivers/pci/switch/switchtec.c:28:12-24: WARNING: Assignment of 0/1 to
bool variable
Signed-off-by: Krzysztof Wilczynski <kw@linux.com>
---
drivers/pci/switch/switchtec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/switch/switchtec.c b/drivers/pci/switch/switchtec.c
index e69cac84b605..850cfeb74608 100644
--- a/drivers/pci/switch/switchtec.c
+++ b/drivers/pci/switch/switchtec.c
@@ -25,7 +25,7 @@ static int max_devices = 16;
module_param(max_devices, int, 0644);
MODULE_PARM_DESC(max_devices, "max number of switchtec device instances");
-static bool use_dma_mrpc = 1;
+static bool use_dma_mrpc = true;
module_param(use_dma_mrpc, bool, 0644);
MODULE_PARM_DESC(use_dma_mrpc,
"Enable the use of the DMA MRPC feature");
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] PCI/switchtec: Correct bool variable type assignment
2020-05-21 20:04 [PATCH] PCI/switchtec: Correct bool variable type assignment Krzysztof Wilczynski
@ 2020-05-21 20:06 ` Logan Gunthorpe
2020-05-21 20:23 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Logan Gunthorpe @ 2020-05-21 20:06 UTC (permalink / raw)
To: Krzysztof Wilczynski, Kurt Schwemmer; +Cc: Bjorn Helgaas, linux-pci
On 2020-05-21 2:04 p.m., Krzysztof Wilczynski wrote:
> Use true instead of 1 in the assignment as the variable use_dma_mrpc is
> of a bool type. Also, resolve the following Coccinelle warning:
>
> drivers/pci/switch/switchtec.c:28:12-24: WARNING: Assignment of 0/1 to
> bool variable
>
> Signed-off-by: Krzysztof Wilczynski <kw@linux.com>
Sure,
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
> ---
> drivers/pci/switch/switchtec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/switch/switchtec.c b/drivers/pci/switch/switchtec.c
> index e69cac84b605..850cfeb74608 100644
> --- a/drivers/pci/switch/switchtec.c
> +++ b/drivers/pci/switch/switchtec.c
> @@ -25,7 +25,7 @@ static int max_devices = 16;
> module_param(max_devices, int, 0644);
> MODULE_PARM_DESC(max_devices, "max number of switchtec device instances");
>
> -static bool use_dma_mrpc = 1;
> +static bool use_dma_mrpc = true;
> module_param(use_dma_mrpc, bool, 0644);
> MODULE_PARM_DESC(use_dma_mrpc,
> "Enable the use of the DMA MRPC feature");
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PCI/switchtec: Correct bool variable type assignment
2020-05-21 20:04 [PATCH] PCI/switchtec: Correct bool variable type assignment Krzysztof Wilczynski
2020-05-21 20:06 ` Logan Gunthorpe
@ 2020-05-21 20:23 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2020-05-21 20:23 UTC (permalink / raw)
To: Krzysztof Wilczynski
Cc: Kurt Schwemmer, Bjorn Helgaas, Logan Gunthorpe, linux-pci
On Thu, May 21, 2020 at 08:04:39PM +0000, Krzysztof Wilczynski wrote:
> Use true instead of 1 in the assignment as the variable use_dma_mrpc is
> of a bool type. Also, resolve the following Coccinelle warning:
>
> drivers/pci/switch/switchtec.c:28:12-24: WARNING: Assignment of 0/1 to
> bool variable
>
> Signed-off-by: Krzysztof Wilczynski <kw@linux.com>
Applied to pci/switchtec for v5.8, thanks!
> ---
> drivers/pci/switch/switchtec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/switch/switchtec.c b/drivers/pci/switch/switchtec.c
> index e69cac84b605..850cfeb74608 100644
> --- a/drivers/pci/switch/switchtec.c
> +++ b/drivers/pci/switch/switchtec.c
> @@ -25,7 +25,7 @@ static int max_devices = 16;
> module_param(max_devices, int, 0644);
> MODULE_PARM_DESC(max_devices, "max number of switchtec device instances");
>
> -static bool use_dma_mrpc = 1;
> +static bool use_dma_mrpc = true;
> module_param(use_dma_mrpc, bool, 0644);
> MODULE_PARM_DESC(use_dma_mrpc,
> "Enable the use of the DMA MRPC feature");
> --
> 2.26.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-21 20:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-21 20:04 [PATCH] PCI/switchtec: Correct bool variable type assignment Krzysztof Wilczynski
2020-05-21 20:06 ` Logan Gunthorpe
2020-05-21 20:23 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox