Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Matt Ranostay <mranostay@ti.com>
To: <robh@kernel.org>, <tjoseph@cadence.com>, <nm@ti.com>,
	<a-verma1@ti.com>, <vigneshr@ti.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
	<linux-pci@vger.kernel.org>, Matt Ranostay <mranostay@ti.com>
Subject: [PATCH v3 3/3] PCI: j721e: Add warnings on num-lanes misconfiguration
Date: Wed, 19 Oct 2022 18:29:11 -0700	[thread overview]
Message-ID: <20221020012911.305139-4-mranostay@ti.com> (raw)
In-Reply-To: <20221020012911.305139-1-mranostay@ti.com>

Added dev_warn messages to alert of devicetree misconfigurations
for incorrect num-lanes setting, or the lack of one being defined.

Signed-off-by: Matt Ranostay <mranostay@ti.com>
Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
---
 drivers/pci/controller/cadence/pci-j721e.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/drivers/pci/controller/cadence/pci-j721e.c b/drivers/pci/controller/cadence/pci-j721e.c
index 0a537f2d5078..2922be2ac4e1 100644
--- a/drivers/pci/controller/cadence/pci-j721e.c
+++ b/drivers/pci/controller/cadence/pci-j721e.c
@@ -441,8 +441,17 @@ static int j721e_pcie_probe(struct platform_device *pdev)
 	pcie->user_cfg_base = base;
 
 	ret = of_property_read_u32(node, "num-lanes", &num_lanes);
-	if (ret || num_lanes > data->max_lanes)
+	if (ret) {
+		dev_warn(dev, "no num-lanes defined, defaulting to 1\n");
 		num_lanes = 1;
+	}
+
+	if (num_lanes > data->max_lanes) {
+		dev_warn(dev, "defined num-lanes %u is greater than the "
+			      "allowed maximum of %u, defaulting to 1\n",
+			      num_lanes, data->max_lanes);
+		num_lanes = 1;
+	}
 	pcie->num_lanes = num_lanes;
 
 	if (dma_set_mask_and_coherent(dev, DMA_BIT_MASK(48)))
-- 
2.38.GIT


  parent reply	other threads:[~2022-10-20  2:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-20  1:29 [PATCH v3 0/3] PCI: add 4x lane support for pci-j721e controllers Matt Ranostay
2022-10-20  1:29 ` [PATCH v3 1/3] PCI: j721e: Add PCIe 4x lane selection support Matt Ranostay
2022-10-25 11:53   ` Vignesh Raghavendra
2022-10-25 12:51     ` Matt Ranostay
2022-10-20  1:29 ` [PATCH v3 2/3] PCI: j721e: Add per platform maximum lane settings Matt Ranostay
2022-10-20  1:29 ` Matt Ranostay [this message]
2022-10-20 16:58   ` [PATCH v3 3/3] PCI: j721e: Add warnings on num-lanes misconfiguration Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221020012911.305139-4-mranostay@ti.com \
    --to=mranostay@ti.com \
    --cc=a-verma1@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh@kernel.org \
    --cc=tjoseph@cadence.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox