From: Mario Limonciello <mario.limonciello@amd.com>
To: Bjorn Helgaas <bhelgaas@google.com>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>
Cc: "Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Hans de Goede" <hdegoede@redhat.com>,
iain@orangesquash.org.uk,
"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>,
"open list:PCI SUBSYSTEM" <linux-pci@vger.kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Lukas Wunner" <lukas@wunner.de>,
"Mario Limonciello" <mario.limonciello@amd.com>
Subject: [PATCH v20 0/2] Add quirk for PCIe root port on AMD systems
Date: Tue, 19 Sep 2023 22:27:22 -0500 [thread overview]
Message-ID: <20230920032724.71083-1-mario.limonciello@amd.com> (raw)
Iain reports that USB devices can't be used to wake a Lenovo Z13
from suspend. This is because the PCIe root port has been put
into D3hot and AMD's platform can't handle USB devices waking the
platform from a hardware sleep state in this case.
The firmware doesn't express this limitation in a way that Linux
recognizes so this series introduces a quirk for this problem.
Previous submissions:
* v19
https://lore.kernel.org/linux-pci/20230915023354.939-1-mario.limonciello@amd.com/
* v18
https://lore.kernel.org/linux-usb/20230913040832.114610-1-mario.limonciello@amd.com/T/#m92a2654129d5f6be5439d8a94fb36734804763c1
* v17
https://lore.kernel.org/platform-driver-x86/20230906184354.45846-1-mario.limonciello@amd.com/
This version implemented constraints for the amd-pmc driver and introduced
a veto/optin system for the PCI core as suggested by Hans.
Rafael suggested not to use the veto/optin system and instead use a quirk.
* v16
https://lore.kernel.org/platform-driver-x86/20230829171212.156688-1-mario.limonciello@amd.com/
This version implemented constraints for the amd-pmc driver.
* v15
https://lore.kernel.org/platform-driver-x86/20230828042819.47013-1-mario.limonciello@amd.com/#t
This version hardcoded the quirk into amd-pmc driver as part of suspend
callback.
* v14
https://lore.kernel.org/linux-pci/20230818193932.27187-1-mario.limonciello@amd.com/
https://lore.kernel.org/linux-pci/20230818194007.27410-1-mario.limonciello@amd.com/
https://lore.kernel.org/linux-pci/20230818194027.27559-1-mario.limonciello@amd.com/
This version implemented constraints exporting and limited the policy for
>= 2015 to Intel only. It also added support for constraints optin.
V13 was split into multiple parts to make it easier to land. 14.b was
merged.
* v13
https://lore.kernel.org/linux-pci/20230818051319.551-1-mario.limonciello@amd.com/
* v12
https://lore.kernel.org/linux-pci/20230816204143.66281-1-mario.limonciello@amd.com/
* v11
https://lore.kernel.org/linux-pci/20230809185453.40916-1-mario.limonciello@amd.com/
* v10
https://lore.kernel.org/linux-pci/20230804210129.5356-1-mario.limonciello@amd.com/
* v9
https://lore.kernel.org/linux-pci/20230804010229.3664-1-mario.limonciello@amd.com/
* v8
https://lore.kernel.org/linux-pci/20230802201013.910-1-mario.limonciello@amd.com/
* v7
https://lore.kernel.org/linux-pci/20230711005325.1499-1-mario.limonciello@amd.com/
* v6
https://lore.kernel.org/linux-pci/20230708214457.1229-1-mario.limonciello@amd.com/
* v5
https://lore.kernel.org/linux-pci/20230530163947.230418-1-mario.limonciello@amd.com/
* v4
https://lore.kernel.org/linux-pci/20230524190726.17012-1-mario.limonciello@amd.com/
* v3
https://lore.kernel.org/linux-pci/20230524152136.1033-1-mario.limonciello@amd.com/
* v2
https://lore.kernel.org/linux-pci/20230517150827.89819-1-mario.limonciello@amd.com/
* v1
https://lore.kernel.org/linux-pci/20230515231515.1440-1-mario.limonciello@amd.com/
Mario Limonciello (2):
PCI: Move the `PCI_CLASS_SERIAL_USB_USB4` definition to common header
PCI: Add a quirk for AMD PCIe root ports w/ USB4 controllers
drivers/pci/quirks.c | 71 +++++++++++++++++++++++++++++++++++++++
drivers/thunderbolt/nhi.h | 2 --
include/linux/pci_ids.h | 1 +
3 files changed, 72 insertions(+), 2 deletions(-)
--
2.34.1
next reply other threads:[~2023-09-20 3:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 3:27 Mario Limonciello [this message]
2023-09-20 3:27 ` [PATCH v20 1/2] PCI: Move the `PCI_CLASS_SERIAL_USB_USB4` definition to common header Mario Limonciello
2023-09-20 3:27 ` [PATCH v20 2/2] PCI: Add a quirk for AMD PCIe root ports w/ USB4 controllers Mario Limonciello
2023-09-25 5:20 ` Mika Westerberg
2023-09-27 18:40 ` Mario Limonciello
2023-09-29 19:44 ` Bjorn Helgaas
2023-09-30 2:05 ` Mario Limonciello
2023-10-03 17:09 ` Bjorn Helgaas
2023-09-30 9:24 ` Lukas Wunner
2023-10-02 16:27 ` Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230920032724.71083-1-mario.limonciello@amd.com \
--to=mario.limonciello@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=bhelgaas@google.com \
--cc=hdegoede@redhat.com \
--cc=iain@orangesquash.org.uk \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox