public inbox for linux-pci@vger.kernel.org
 help / color / mirror / Atom feed
From: Matthew W Carlis <mattc@purestorage.com>
To: helgaas@kernel.org, bhelgaas@google.com,
	sathyanarayanan.kuppuswamy@linux.intel.com,
	linux-pci@vger.kernel.org, mika.westerberg@linux.intel.com
Cc: Matthew W Carlis <mattc@purestorage.com>
Subject: [PATCH 1/1] PCI/portdrv: Allow DPC if the OS controls AER natively.
Date: Sat, 23 Dec 2023 14:22:34 -0700	[thread overview]
Message-ID: <20231223212235.34293-1-mattc@purestorage.com> (raw)

During our kernel version migration we encountered an issue preventing DPC
from being used by the kernel on the downstream ports of PCIe switches.
After some review of the patch history & code we found that the kernel
now required pcie_ports=dpc-native command line argument for such devices.
This came after we picked up:
    "PCI/portdrv: Allow AER service only for Root Ports & RCECs"

Belief is that the above patch is 'more correct' on the AER side, but perhaps
'less correct' on DPC. I initially reached out in the patch's email
thread to see whether others had thoughts & whether this change might be
desireable after which I was asked if I would submit a patch. Took a little
time to read some of the ACPI/PCIe specifications which are the basis of my
beliefs about the correctness of this patch. That being, if a user builds the
kernel with DPC/AER & the kernel receives OS control over AER, then it should
automatically use AER & DPC where applicable in the PCIe hierarchy.

Matthew W Carlis (1):
  PCI/portdrv: Allow DPC if the OS controls AER natively.

 drivers/pci/pcie/portdrv.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)


base-commit: ceb6a6f023fd3e8b07761ed900352ef574010bcb
-- 
2.17.1


             reply	other threads:[~2023-12-23 21:22 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-23 21:22 Matthew W Carlis [this message]
2023-12-23 21:22 ` [PATCH 1/1] PCI/portdrv: Allow DPC if the OS controls AER natively Matthew W Carlis
2023-12-25 17:53   ` kernel test robot
2023-12-25 20:36   ` kernel test robot
2023-12-26  0:02     ` Matthew W Carlis
2023-12-28 21:23   ` Bjorn Helgaas
2024-01-02 15:41     ` Kuppuswamy Sathyanarayanan
2024-01-08 19:46       ` Matthew W Carlis
2024-01-08 19:53         ` Kuppuswamy Sathyanarayanan
2024-01-09  0:15           ` Matthew W Carlis
2024-01-10 16:41             ` Kuppuswamy Sathyanarayanan
2024-01-10 17:13               ` Kuppuswamy Sathyanarayanan
2024-01-10 20:01                 ` Matthew W Carlis
2024-01-10 19:59               ` Matthew W Carlis
2024-01-22 19:32             ` Bjorn Helgaas
2024-01-23  2:37               ` Kuppuswamy Sathyanarayanan
2024-01-23 15:59                 ` Bjorn Helgaas
2024-01-23 23:18                   ` Matthew W Carlis
2024-01-24 20:29                     ` Bjorn Helgaas
2024-02-21 23:11                   ` Bjorn Helgaas
2024-02-21 23:33                     ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231223212235.34293-1-mattc@purestorage.com \
    --to=mattc@purestorage.com \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=sathyanarayanan.kuppuswamy@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox