From: "Krzysztof Wilczyński" <kw@linux.com>
To: Niklas Cassel <cassel@kernel.org>
Cc: Jingoo Han <jingoohan1@gmail.com>,
Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Rob Herring <robh@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Kishon Vijay Abraham I <kishon@kernel.org>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v2] PCI: dwc: endpoint: Fix advertised resizable BAR size
Date: Mon, 11 Mar 2024 03:51:45 +0900 [thread overview]
Message-ID: <20240310185145.GF2765217@rocinante> (raw)
In-Reply-To: <20240307111520.3303774-1-cassel@kernel.org>
Hello,
> The commit message in commit fc9a77040b04 ("PCI: designware-ep: Configure
> Resizable BAR cap to advertise the smallest size") claims that it modifies
> the Resizable BAR capability to only advertise support for 1 MB size BARs.
>
> However, the commit writes all zeroes to PCI_REBAR_CAP (the register which
> contains the possible BAR sizes that a BAR be resized to).
>
> According to the spec, it is illegal to not have a bit set in
> PCI_REBAR_CAP, and 1 MB is the smallest size allowed.
>
> Set bit 4 in PCI_REBAR_CAP, so that we actually advertise support for a
> 1 MB BAR size.
>
> Before:
> Capabilities: [2e8 v1] Physical Resizable BAR
> BAR 0: current size: 1MB
> BAR 1: current size: 1MB
> BAR 2: current size: 1MB
> BAR 3: current size: 1MB
> BAR 4: current size: 1MB
> BAR 5: current size: 1MB
> After:
> Capabilities: [2e8 v1] Physical Resizable BAR
> BAR 0: current size: 1MB, supported: 1MB
> BAR 1: current size: 1MB, supported: 1MB
> BAR 2: current size: 1MB, supported: 1MB
> BAR 3: current size: 1MB, supported: 1MB
> BAR 4: current size: 1MB, supported: 1MB
> BAR 5: current size: 1MB, supported: 1MB
Applied to controller/dwc, thank you!
[1/1] PCI: dwc: endpoint: Fix advertised resizable BAR size
https://git.kernel.org/pci/pci/c/72e34b8593e0
Krzysztof
prev parent reply other threads:[~2024-03-10 18:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 11:15 [PATCH v2] PCI: dwc: endpoint: Fix advertised resizable BAR size Niklas Cassel
2024-03-10 13:04 ` Manivannan Sadhasivam
2024-03-10 18:52 ` Krzysztof Wilczyński
2024-03-10 18:51 ` Krzysztof Wilczyński [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240310185145.GF2765217@rocinante \
--to=kw@linux.com \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=kishon@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox