* [pci:enumeration 28/28] drivers/mfd/intel-lpss-pci.c:57:49: error: 'PCI_IRQ_LEGACY' undeclared; did you mean 'NR_IRQS_LEGACY'?
@ 2024-03-26 10:19 kernel test robot
2024-03-26 11:52 ` Damien Le Moal
0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2024-03-26 10:19 UTC (permalink / raw)
To: Damien Le Moal; +Cc: oe-kbuild-all, linux-pci, Bjorn Helgaas
tree: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git enumeration
head: 8694697a54096ae97eb38bf4144f2d96c64c68f2
commit: 8694697a54096ae97eb38bf4144f2d96c64c68f2 [28/28] PCI: Remove PCI_IRQ_LEGACY
config: i386-buildonly-randconfig-001-20240326 (https://download.01.org/0day-ci/archive/20240326/202403261840.1RP419n5-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240326/202403261840.1RP419n5-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202403261840.1RP419n5-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/mfd/intel-lpss-pci.c: In function 'intel_lpss_pci_probe':
>> drivers/mfd/intel-lpss-pci.c:57:49: error: 'PCI_IRQ_LEGACY' undeclared (first use in this function); did you mean 'NR_IRQS_LEGACY'?
57 | ret = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_LEGACY);
| ^~~~~~~~~~~~~~
| NR_IRQS_LEGACY
drivers/mfd/intel-lpss-pci.c:57:49: note: each undeclared identifier is reported only once for each function it appears in
vim +57 drivers/mfd/intel-lpss-pci.c
e6b142060b2401 Hans de Goede 2021-12-03 44
4b45efe8526359 Andy Shevchenko 2015-07-27 45 static int intel_lpss_pci_probe(struct pci_dev *pdev,
4b45efe8526359 Andy Shevchenko 2015-07-27 46 const struct pci_device_id *id)
4b45efe8526359 Andy Shevchenko 2015-07-27 47 {
9ffe4c1089f6c3 Andy Shevchenko 2023-11-24 48 const struct intel_lpss_platform_info *data = (void *)id->driver_data;
ac9538f6007e1c Aleksandrs Vinarskis 2023-12-21 49 const struct pci_device_id *quirk_pci_info;
4b45efe8526359 Andy Shevchenko 2015-07-27 50 struct intel_lpss_platform_info *info;
4b45efe8526359 Andy Shevchenko 2015-07-27 51 int ret;
4b45efe8526359 Andy Shevchenko 2015-07-27 52
4b45efe8526359 Andy Shevchenko 2015-07-27 53 ret = pcim_enable_device(pdev);
4b45efe8526359 Andy Shevchenko 2015-07-27 54 if (ret)
4b45efe8526359 Andy Shevchenko 2015-07-27 55 return ret;
4b45efe8526359 Andy Shevchenko 2015-07-27 56
6978c7d2dd81e0 Andy Shevchenko 2023-11-06 @57 ret = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_LEGACY);
0c679fffd67605 Andy Shevchenko 2023-11-30 58 if (ret < 0)
6978c7d2dd81e0 Andy Shevchenko 2023-11-06 59 return ret;
6978c7d2dd81e0 Andy Shevchenko 2023-11-06 60
9ffe4c1089f6c3 Andy Shevchenko 2023-11-24 61 info = devm_kmemdup(&pdev->dev, data, sizeof(*info), GFP_KERNEL);
4b45efe8526359 Andy Shevchenko 2015-07-27 62 if (!info)
4b45efe8526359 Andy Shevchenko 2015-07-27 63 return -ENOMEM;
4b45efe8526359 Andy Shevchenko 2015-07-27 64
3b6dba220e67ed Andy Shevchenko 2023-11-24 65 /* No need to check mem and irq here as intel_lpss_probe() does it for us */
6978c7d2dd81e0 Andy Shevchenko 2023-11-06 66 info->mem = pci_resource_n(pdev, 0);
6978c7d2dd81e0 Andy Shevchenko 2023-11-06 67 info->irq = pci_irq_vector(pdev, 0);
4b45efe8526359 Andy Shevchenko 2015-07-27 68
ac9538f6007e1c Aleksandrs Vinarskis 2023-12-21 69 quirk_pci_info = pci_match_id(quirk_ids, pdev);
ac9538f6007e1c Aleksandrs Vinarskis 2023-12-21 70 if (quirk_pci_info)
ac9538f6007e1c Aleksandrs Vinarskis 2023-12-21 71 info->quirks = quirk_pci_info->driver_data;
e6b142060b2401 Hans de Goede 2021-12-03 72
76380a607ba0b2 Kai-Heng Feng 2019-07-05 73 pdev->d3cold_delay = 0;
76380a607ba0b2 Kai-Heng Feng 2019-07-05 74
4b45efe8526359 Andy Shevchenko 2015-07-27 75 /* Probably it is enough to set this for iDMA capable devices only */
4b45efe8526359 Andy Shevchenko 2015-07-27 76 pci_set_master(pdev);
85a9419a254e23 Andy Shevchenko 2016-11-15 77 pci_try_set_mwi(pdev);
4b45efe8526359 Andy Shevchenko 2015-07-27 78
4b45efe8526359 Andy Shevchenko 2015-07-27 79 ret = intel_lpss_probe(&pdev->dev, info);
4b45efe8526359 Andy Shevchenko 2015-07-27 80 if (ret)
4b45efe8526359 Andy Shevchenko 2015-07-27 81 return ret;
4b45efe8526359 Andy Shevchenko 2015-07-27 82
4b45efe8526359 Andy Shevchenko 2015-07-27 83 pm_runtime_put(&pdev->dev);
4b45efe8526359 Andy Shevchenko 2015-07-27 84 pm_runtime_allow(&pdev->dev);
4b45efe8526359 Andy Shevchenko 2015-07-27 85
4b45efe8526359 Andy Shevchenko 2015-07-27 86 return 0;
4b45efe8526359 Andy Shevchenko 2015-07-27 87 }
4b45efe8526359 Andy Shevchenko 2015-07-27 88
:::::: The code at line 57 was first introduced by commit
:::::: 6978c7d2dd81e0a3f9d30d1fbdb013a5ae5fabaf mfd: intel-lpss: Use PCI APIs instead of dereferencing
:::::: TO: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
:::::: CC: Lee Jones <lee@kernel.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [pci:enumeration 28/28] drivers/mfd/intel-lpss-pci.c:57:49: error: 'PCI_IRQ_LEGACY' undeclared; did you mean 'NR_IRQS_LEGACY'?
2024-03-26 10:19 [pci:enumeration 28/28] drivers/mfd/intel-lpss-pci.c:57:49: error: 'PCI_IRQ_LEGACY' undeclared; did you mean 'NR_IRQS_LEGACY'? kernel test robot
@ 2024-03-26 11:52 ` Damien Le Moal
2024-03-26 21:13 ` Bjorn Helgaas
0 siblings, 1 reply; 3+ messages in thread
From: Damien Le Moal @ 2024-03-26 11:52 UTC (permalink / raw)
To: kernel test robot; +Cc: oe-kbuild-all, linux-pci, Bjorn Helgaas
On 3/26/24 19:19, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git enumeration
> head: 8694697a54096ae97eb38bf4144f2d96c64c68f2
> commit: 8694697a54096ae97eb38bf4144f2d96c64c68f2 [28/28] PCI: Remove PCI_IRQ_LEGACY
> config: i386-buildonly-randconfig-001-20240326 (https://download.01.org/0day-ci/archive/20240326/202403261840.1RP419n5-lkp@intel.com/config)
> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240326/202403261840.1RP419n5-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202403261840.1RP419n5-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
> drivers/mfd/intel-lpss-pci.c: In function 'intel_lpss_pci_probe':
>>> drivers/mfd/intel-lpss-pci.c:57:49: error: 'PCI_IRQ_LEGACY' undeclared (first use in this function); did you mean 'NR_IRQS_LEGACY'?
> 57 | ret = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_LEGACY);
> | ^~~~~~~~~~~~~~
> | NR_IRQS_LEGACY
> drivers/mfd/intel-lpss-pci.c:57:49: note: each undeclared identifier is reported only once for each function it appears in
Bjorn,
Not sure what is going on here. I did an allyesconfig build on x86_64 and did
not see such issue. Did the build bot missed some patches ?
And the above also reminds me that we could change NR_IRQS_LEGACY to
NR_IRQS_INTX too.
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [pci:enumeration 28/28] drivers/mfd/intel-lpss-pci.c:57:49: error: 'PCI_IRQ_LEGACY' undeclared; did you mean 'NR_IRQS_LEGACY'?
2024-03-26 11:52 ` Damien Le Moal
@ 2024-03-26 21:13 ` Bjorn Helgaas
0 siblings, 0 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2024-03-26 21:13 UTC (permalink / raw)
To: Damien Le Moal
Cc: kernel test robot, oe-kbuild-all, linux-pci, Andy Shevchenko
On Tue, Mar 26, 2024 at 08:52:36PM +0900, Damien Le Moal wrote:
> On 3/26/24 19:19, kernel test robot wrote:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git enumeration
> > head: 8694697a54096ae97eb38bf4144f2d96c64c68f2
> > commit: 8694697a54096ae97eb38bf4144f2d96c64c68f2 [28/28] PCI: Remove PCI_IRQ_LEGACY
> > config: i386-buildonly-randconfig-001-20240326 (https://download.01.org/0day-ci/archive/20240326/202403261840.1RP419n5-lkp@intel.com/config)
> > compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240326/202403261840.1RP419n5-lkp@intel.com/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202403261840.1RP419n5-lkp@intel.com/
> >
> > All errors (new ones prefixed by >>):
> >
> > drivers/mfd/intel-lpss-pci.c: In function 'intel_lpss_pci_probe':
> >>> drivers/mfd/intel-lpss-pci.c:57:49: error: 'PCI_IRQ_LEGACY' undeclared (first use in this function); did you mean 'NR_IRQS_LEGACY'?
> > 57 | ret = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_LEGACY);
> > | ^~~~~~~~~~~~~~
> > | NR_IRQS_LEGACY
> > drivers/mfd/intel-lpss-pci.c:57:49: note: each undeclared identifier is reported only once for each function it appears in
>
> Bjorn,
>
> Not sure what is going on here. I did an allyesconfig build on x86_64 and did
> not see such issue. Did the build bot missed some patches ?
>
> And the above also reminds me that we could change NR_IRQS_LEGACY to
> NR_IRQS_INTX too.
Sorry, this is my fault because I dropped the intel-lpss-pci.c patch
because I was thinking Andy's patch would make it obsolete [1]. And
it *does*, but we don't know the ordering of when his patch and this
series will be merged into -next or upstream, so ...
Anyway, I blew it, and I restore the intel-lpss-pci.c patch in the
series, and we'll just have a trivial merge conflict to resolve until
they're both upstream.
Sorry for all the confusion.
Bjorn
[1] https://lore.kernel.org/r/20240325210444.GA1449676@bhelgaas
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-26 21:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-26 10:19 [pci:enumeration 28/28] drivers/mfd/intel-lpss-pci.c:57:49: error: 'PCI_IRQ_LEGACY' undeclared; did you mean 'NR_IRQS_LEGACY'? kernel test robot
2024-03-26 11:52 ` Damien Le Moal
2024-03-26 21:13 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox