* Re: [PATCH v9 4/5] PCI: rcar-gen4: Add support for r8a779g0
2024-06-11 12:50 ` [PATCH v9 4/5] PCI: rcar-gen4: Add support for r8a779g0 Yoshihiro Shimoda
@ 2024-06-18 7:09 ` Manivannan Sadhasivam
2024-06-18 8:10 ` Yoshihiro Shimoda
2024-06-23 13:16 ` Manivannan Sadhasivam
` (2 subsequent siblings)
3 siblings, 1 reply; 25+ messages in thread
From: Manivannan Sadhasivam @ 2024-06-18 7:09 UTC (permalink / raw)
To: Yoshihiro Shimoda
Cc: lpieralisi, kw, robh, bhelgaas, jingoohan1, marek.vasut+renesas,
linux-pci, linux-renesas-soc
On Tue, Jun 11, 2024 at 09:50:56PM +0900, Yoshihiro Shimoda wrote:
> Add support for r8a779g0 (R-Car V4H).
>
> This driver previously supported r8a779f0 (R-Car S4-8). PCIe features
> of both r8a779f0 and r8a779g0 are almost all the same. For example:
> - PCI Express Base Specification Revision 4.0
> - Root complex mode and endpoint mode are supported
> However, r8a779g0 requires specific firmware downloading, to
> initialize the PHY. Otherwise, the PCIe controller cannot work.
>
> The attached firmware file "104_PCIe_fw_addr_data_ver1.05.txt" in
> the datasheet is a text file. But, Renesas is not able to distribute
> the firmware freely. So, we require converting the text file
> to a binary before the driver runs by using the following script:
>
> $ awk '/^\s*0x[0-9A-Fa-f]{4}\s+0x[0-9A-Fa-f]{4}/ \
> { print substr($2,5,2) substr($2,3,2) }' \
> 104_PCIe_fw_addr_data_ver1.05.txt | xxd -p -r > \
> rcar_gen4_pcie.bin
> $ sha1sum rcar_gen4_pcie.bin
> 1d0bd4b189b4eb009f5d564b1f93a79112994945 rcar_gen4_pcie.bin
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
> drivers/pci/controller/dwc/pcie-rcar-gen4.c | 207 +++++++++++++++++++-
> 1 file changed, 206 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/dwc/pcie-rcar-gen4.c b/drivers/pci/controller/dwc/pcie-rcar-gen4.c
> index dac78388975d..c67097e718d3 100644
> --- a/drivers/pci/controller/dwc/pcie-rcar-gen4.c
> +++ b/drivers/pci/controller/dwc/pcie-rcar-gen4.c
> @@ -5,8 +5,10 @@
> */
>
> #include <linux/delay.h>
> +#include <linux/firmware.h>
> #include <linux/interrupt.h>
> #include <linux/io.h>
> +#include <linux/iopoll.h>
> #include <linux/module.h>
> #include <linux/of.h>
> #include <linux/pci.h>
> @@ -20,9 +22,10 @@
> /* Renesas-specific */
> /* PCIe Mode Setting Register 0 */
> #define PCIEMSR0 0x0000
> -#define BIFUR_MOD_SET_ON BIT(0)
> +#define APP_SRIS_MODE BIT(6)
> #define DEVICE_TYPE_EP 0
> #define DEVICE_TYPE_RC BIT(4)
> +#define BIFUR_MOD_SET_ON BIT(0)
>
> /* PCIe Interrupt Status 0 */
> #define PCIEINTSTS0 0x0084
> @@ -37,19 +40,48 @@
> #define PCIEDMAINTSTSEN 0x0314
> #define PCIEDMAINTSTSEN_INIT GENMASK(15, 0)
>
> +/* Port Logic Registers 89 */
> +#define PRTLGC89 0x0b70
> +
> +/* Port Logic Registers 90 */
> +#define PRTLGC90 0x0b74
> +
> /* PCIe Reset Control Register 1 */
> #define PCIERSTCTRL1 0x0014
> #define APP_HOLD_PHY_RST BIT(16)
> #define APP_LTSSM_ENABLE BIT(0)
>
> +/* PCIe Power Management Control */
> +#define PCIEPWRMNGCTRL 0x0070
> +#define APP_CLK_REQ_N BIT(11)
> +#define APP_CLK_PM_EN BIT(10)
> +
> #define RCAR_NUM_SPEED_CHANGE_RETRIES 10
> #define RCAR_MAX_LINK_SPEED 4
>
> #define RCAR_GEN4_PCIE_EP_FUNC_DBI_OFFSET 0x1000
> #define RCAR_GEN4_PCIE_EP_FUNC_DBI2_OFFSET 0x800
>
> +/*
> + * The attached firmware file "104_PCIe_fw_addr_data_ver1.05.txt" in
> + * the datasheet is a text file. But, Renesas is not able to distribute
> + * the firmware freely. So, we require converting the text file
> + * to a binary before the driver runs by using the following script:
> + *
> + * $ awk '/^\s*0x[0-9A-Fa-f]{4}\s+0x[0-9A-Fa-f]{4}/ \
> + * { print substr($2,5,2) substr($2,3,2) }' \
> + * 104_PCIe_fw_addr_data_ver1.05.txt | xxd -p -r > \
> + * rcar_gen4_pcie.bin
> + * $ sha1sum rcar_gen4_pcie.bin
> + * 1d0bd4b189b4eb009f5d564b1f93a79112994945 rcar_gen4_pcie.bin
> + */
> +#define RCAR_GEN4_PCIE_FIRMWARE_NAME "rcar_gen4_pcie.bin"
> +#define RCAR_GEN4_PCIE_FIRMWARE_BASE_ADDR 0xc000
> +MODULE_FIRMWARE(RCAR_GEN4_PCIE_FIRMWARE_NAME);
> +
> struct rcar_gen4_pcie;
> struct rcar_gen4_pcie_drvdata {
> + void (*additional_common_init)(struct rcar_gen4_pcie *rcar);
> int (*ltssm_control)(struct rcar_gen4_pcie *rcar, bool enable);
> enum dw_pcie_device_mode mode;
> };
> @@ -57,6 +89,7 @@ struct rcar_gen4_pcie_drvdata {
> struct rcar_gen4_pcie {
> struct dw_pcie dw;
> void __iomem *base;
> + void __iomem *phy_base;
> struct platform_device *pdev;
> const struct rcar_gen4_pcie_drvdata *drvdata;
> };
> @@ -180,6 +213,9 @@ static int rcar_gen4_pcie_common_init(struct rcar_gen4_pcie *rcar)
> if (ret)
> goto err_unprepare;
>
> + if (rcar->drvdata->additional_common_init)
> + rcar->drvdata->additional_common_init(rcar);
> +
> return 0;
>
> err_unprepare:
> @@ -221,6 +257,10 @@ static void rcar_gen4_pcie_unprepare(struct rcar_gen4_pcie *rcar)
>
> static int rcar_gen4_pcie_get_resources(struct rcar_gen4_pcie *rcar)
> {
> + rcar->phy_base = devm_platform_ioremap_resource_byname(rcar->pdev, "phy");
> + if (IS_ERR(rcar->phy_base))
> + return PTR_ERR(rcar->phy_base);
> +
I failed to spot this in earlier reviews. Since this 'phy' region is only
applicable for r8a779g0, wouldn't this fail on other platforms?
- Mani
> /* Renesas-specific registers */
> rcar->base = devm_platform_ioremap_resource_byname(rcar->pdev, "app");
>
> @@ -528,6 +568,167 @@ static int r8a779f0_pcie_ltssm_control(struct rcar_gen4_pcie *rcar, bool enable)
> return 0;
> }
>
> +static void rcar_gen4_pcie_additional_common_init(struct rcar_gen4_pcie *rcar)
> +{
> + struct dw_pcie *dw = &rcar->dw;
> + u32 val;
> +
> + val = dw_pcie_readl_dbi(dw, PCIE_PORT_LANE_SKEW);
> + val &= ~PORT_LANE_SKEW_INSERT_MASK;
> + if (dw->num_lanes < 4)
> + val |= BIT(6);
> + dw_pcie_writel_dbi(dw, PCIE_PORT_LANE_SKEW, val);
> +
> + val = readl(rcar->base + PCIEPWRMNGCTRL);
> + val |= APP_CLK_REQ_N | APP_CLK_PM_EN;
> + writel(val, rcar->base + PCIEPWRMNGCTRL);
> +}
> +
> +static void rcar_gen4_pcie_phy_reg_update_bits(struct rcar_gen4_pcie *rcar,
> + u32 offset, u32 mask, u32 val)
> +{
> + u32 tmp;
> +
> + tmp = readl(rcar->phy_base + offset);
> + tmp &= ~mask;
> + tmp |= val;
> + writel(tmp, rcar->phy_base + offset);
> +}
> +
> +/*
> + * SoC datasheet suggests checking port logic register bits during firmware
> + * write. If read returns non-zero value, then this function returns -EAGAIN
> + * indicating that the write needs to be done again. If read returns zero,
> + * then return 0 to indicate success.
> + */
> +static int rcar_gen4_pcie_reg_test_bit(struct rcar_gen4_pcie *rcar,
> + u32 offset, u32 mask)
> +{
> + struct dw_pcie *dw = &rcar->dw;
> +
> + if (dw_pcie_readl_dbi(dw, offset) & mask)
> + return -EAGAIN;
> +
> + return 0;
> +}
> +
> +static int rcar_gen4_pcie_download_phy_firmware(struct rcar_gen4_pcie *rcar)
> +{
> + /* The check_addr values are magical numbers in the datasheet */
> + const u32 check_addr[] = { 0x00101018, 0x00101118, 0x00101021, 0x00101121};
> + struct dw_pcie *dw = &rcar->dw;
> + const struct firmware *fw;
> + unsigned int i, timeout;
> + u32 data;
> + int ret;
> +
> + ret = request_firmware(&fw, RCAR_GEN4_PCIE_FIRMWARE_NAME, dw->dev);
> + if (ret) {
> + dev_err(dw->dev, "Failed to load firmware (%s): %d\n",
> + RCAR_GEN4_PCIE_FIRMWARE_NAME, ret);
> + return ret;
> + }
> +
> + for (i = 0; i < (fw->size / 2); i++) {
> + data = fw->data[(i * 2) + 1] << 8 | fw->data[i * 2];
> + timeout = 100;
> + do {
> + dw_pcie_writel_dbi(dw, PRTLGC89, RCAR_GEN4_PCIE_FIRMWARE_BASE_ADDR + i);
> + dw_pcie_writel_dbi(dw, PRTLGC90, data);
> + if (!rcar_gen4_pcie_reg_test_bit(rcar, PRTLGC89, BIT(30)))
> + break;
> + if (!(--timeout)) {
> + ret = -ETIMEDOUT;
> + goto exit;
> + }
> + usleep_range(100, 200);
> + } while (1);
> + }
> +
> + rcar_gen4_pcie_phy_reg_update_bits(rcar, 0x0f8, BIT(17), BIT(17));
> +
> + for (i = 0; i < ARRAY_SIZE(check_addr); i++) {
> + timeout = 100;
> + do {
> + dw_pcie_writel_dbi(dw, PRTLGC89, check_addr[i]);
> + ret = rcar_gen4_pcie_reg_test_bit(rcar, PRTLGC89, BIT(30));
> + ret |= rcar_gen4_pcie_reg_test_bit(rcar, PRTLGC90, BIT(0));
> + if (!ret)
> + break;
> + if (!(--timeout)) {
> + ret = -ETIMEDOUT;
> + goto exit;
> + }
> + usleep_range(100, 200);
> + } while (1);
> + }
> +
> +exit:
> + release_firmware(fw);
> +
> + return ret;
> +}
> +
> +static int rcar_gen4_pcie_ltssm_control(struct rcar_gen4_pcie *rcar, bool enable)
> +{
> + struct dw_pcie *dw = &rcar->dw;
> + u32 val;
> + int ret;
> +
> + if (!enable) {
> + val = readl(rcar->base + PCIERSTCTRL1);
> + val &= ~APP_LTSSM_ENABLE;
> + writel(val, rcar->base + PCIERSTCTRL1);
> +
> + return 0;
> + }
> +
> + val = dw_pcie_readl_dbi(dw, PCIE_PORT_FORCE);
> + val |= PORT_FORCE_DO_DESKEW_FOR_SRIS;
> + dw_pcie_writel_dbi(dw, PCIE_PORT_FORCE, val);
> +
> + val = readl(rcar->base + PCIEMSR0);
> + val |= APP_SRIS_MODE;
> + writel(val, rcar->base + PCIEMSR0);
> +
> + /*
> + * The R-Car Gen4 datasheet doesn't describe the PHY registers' name.
> + * But, the initialization procedure describes these offsets. So,
> + * this driver has magical offset numbers.
> + */
> + rcar_gen4_pcie_phy_reg_update_bits(rcar, 0x700, BIT(28), 0);
> + rcar_gen4_pcie_phy_reg_update_bits(rcar, 0x700, BIT(20), 0);
> + rcar_gen4_pcie_phy_reg_update_bits(rcar, 0x700, BIT(12), 0);
> + rcar_gen4_pcie_phy_reg_update_bits(rcar, 0x700, BIT(4), 0);
> +
> + rcar_gen4_pcie_phy_reg_update_bits(rcar, 0x148, GENMASK(23, 22), BIT(22));
> + rcar_gen4_pcie_phy_reg_update_bits(rcar, 0x148, GENMASK(18, 16), GENMASK(17, 16));
> + rcar_gen4_pcie_phy_reg_update_bits(rcar, 0x148, GENMASK(7, 6), BIT(6));
> + rcar_gen4_pcie_phy_reg_update_bits(rcar, 0x148, GENMASK(2, 0), GENMASK(11, 0));
> + rcar_gen4_pcie_phy_reg_update_bits(rcar, 0x1d4, GENMASK(16, 15), GENMASK(16, 15));
> + rcar_gen4_pcie_phy_reg_update_bits(rcar, 0x514, BIT(26), BIT(26));
> + rcar_gen4_pcie_phy_reg_update_bits(rcar, 0x0f8, BIT(16), 0);
> + rcar_gen4_pcie_phy_reg_update_bits(rcar, 0x0f8, BIT(19), BIT(19));
> +
> + val = readl(rcar->base + PCIERSTCTRL1);
> + val &= ~APP_HOLD_PHY_RST;
> + writel(val, rcar->base + PCIERSTCTRL1);
> +
> + ret = readl_poll_timeout(rcar->phy_base + 0x0f8, val, !(val & BIT(18)), 100, 10000);
> + if (ret < 0)
> + return ret;
> +
> + ret = rcar_gen4_pcie_download_phy_firmware(rcar);
> + if (ret)
> + return ret;
> +
> + val = readl(rcar->base + PCIERSTCTRL1);
> + val |= APP_LTSSM_ENABLE;
> + writel(val, rcar->base + PCIERSTCTRL1);
> +
> + return 0;
> +}
> +
> static struct rcar_gen4_pcie_drvdata drvdata_r8a779f0_pcie = {
> .ltssm_control = r8a779f0_pcie_ltssm_control,
> .mode = DW_PCIE_RC_TYPE,
> @@ -539,10 +740,14 @@ static struct rcar_gen4_pcie_drvdata drvdata_r8a779f0_pcie_ep = {
> };
>
> static struct rcar_gen4_pcie_drvdata drvdata_rcar_gen4_pcie = {
> + .additional_common_init = rcar_gen4_pcie_additional_common_init,
> + .ltssm_control = rcar_gen4_pcie_ltssm_control,
> .mode = DW_PCIE_RC_TYPE,
> };
>
> static struct rcar_gen4_pcie_drvdata drvdata_rcar_gen4_pcie_ep = {
> + .additional_common_init = rcar_gen4_pcie_additional_common_init,
> + .ltssm_control = rcar_gen4_pcie_ltssm_control,
> .mode = DW_PCIE_EP_TYPE,
> };
>
> --
> 2.25.1
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 25+ messages in thread* RE: [PATCH v9 4/5] PCI: rcar-gen4: Add support for r8a779g0
2024-06-18 7:09 ` Manivannan Sadhasivam
@ 2024-06-18 8:10 ` Yoshihiro Shimoda
2024-06-19 8:52 ` Manivannan Sadhasivam
0 siblings, 1 reply; 25+ messages in thread
From: Yoshihiro Shimoda @ 2024-06-18 8:10 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: lpieralisi@kernel.org, kw@linux.com, robh@kernel.org,
bhelgaas@google.com, jingoohan1@gmail.com,
marek.vasut+renesas@gmail.com, linux-pci@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Hello Manivannan,
Thank you for your review!
> From: Manivannan Sadhasivam, Sent: Tuesday, June 18, 2024 4:09 PM
>
> On Tue, Jun 11, 2024 at 09:50:56PM +0900, Yoshihiro Shimoda wrote:
<snip>
> > @@ -221,6 +257,10 @@ static void rcar_gen4_pcie_unprepare(struct rcar_gen4_pcie *rcar)
> >
> > static int rcar_gen4_pcie_get_resources(struct rcar_gen4_pcie *rcar)
> > {
> > + rcar->phy_base = devm_platform_ioremap_resource_byname(rcar->pdev, "phy");
> > + if (IS_ERR(rcar->phy_base))
> > + return PTR_ERR(rcar->phy_base);
> > +
>
> I failed to spot this in earlier reviews. Since this 'phy' region is only
> applicable for r8a779g0, wouldn't this fail on other platforms?
This will not fail on other platforms because the dtsi file of the other platform (r8a779f0.dtsi)
already has the 'phy' region in the first commit which I added PCIe nodes:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch/arm64/boot/dts/renesas/r8a779f0.dtsi?h=v6.10-rc4&id=183a709d3719e5c9919a6f12c86c0a3e088b712d
Best regards,
Yoshihiro Shimoda
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH v9 4/5] PCI: rcar-gen4: Add support for r8a779g0
2024-06-18 8:10 ` Yoshihiro Shimoda
@ 2024-06-19 8:52 ` Manivannan Sadhasivam
0 siblings, 0 replies; 25+ messages in thread
From: Manivannan Sadhasivam @ 2024-06-19 8:52 UTC (permalink / raw)
To: Yoshihiro Shimoda
Cc: Manivannan Sadhasivam, lpieralisi@kernel.org, kw@linux.com,
robh@kernel.org, bhelgaas@google.com, jingoohan1@gmail.com,
marek.vasut+renesas@gmail.com, linux-pci@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
On Tue, Jun 18, 2024 at 08:10:43AM +0000, Yoshihiro Shimoda wrote:
> Hello Manivannan,
>
> Thank you for your review!
>
> > From: Manivannan Sadhasivam, Sent: Tuesday, June 18, 2024 4:09 PM
> >
> > On Tue, Jun 11, 2024 at 09:50:56PM +0900, Yoshihiro Shimoda wrote:
> <snip>
> > > @@ -221,6 +257,10 @@ static void rcar_gen4_pcie_unprepare(struct rcar_gen4_pcie *rcar)
> > >
> > > static int rcar_gen4_pcie_get_resources(struct rcar_gen4_pcie *rcar)
> > > {
> > > + rcar->phy_base = devm_platform_ioremap_resource_byname(rcar->pdev, "phy");
> > > + if (IS_ERR(rcar->phy_base))
> > > + return PTR_ERR(rcar->phy_base);
> > > +
> >
> > I failed to spot this in earlier reviews. Since this 'phy' region is only
> > applicable for r8a779g0, wouldn't this fail on other platforms?
>
> This will not fail on other platforms because the dtsi file of the other platform (r8a779f0.dtsi)
> already has the 'phy' region in the first commit which I added PCIe nodes:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch/arm64/boot/dts/renesas/r8a779f0.dtsi?h=v6.10-rc4&id=183a709d3719e5c9919a6f12c86c0a3e088b712d
>
Ah okay. I didn't check the dts/binding. This is fine.
- Mani
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v9 4/5] PCI: rcar-gen4: Add support for r8a779g0
2024-06-11 12:50 ` [PATCH v9 4/5] PCI: rcar-gen4: Add support for r8a779g0 Yoshihiro Shimoda
2024-06-18 7:09 ` Manivannan Sadhasivam
@ 2024-06-23 13:16 ` Manivannan Sadhasivam
2024-06-29 19:56 ` Krzysztof Wilczyński
2024-07-02 17:14 ` Bjorn Helgaas
3 siblings, 0 replies; 25+ messages in thread
From: Manivannan Sadhasivam @ 2024-06-23 13:16 UTC (permalink / raw)
To: Yoshihiro Shimoda
Cc: lpieralisi, kw, robh, bhelgaas, jingoohan1, mani,
marek.vasut+renesas, linux-pci, linux-renesas-soc
On Tue, Jun 11, 2024 at 09:50:56PM +0900, Yoshihiro Shimoda wrote:
> Add support for r8a779g0 (R-Car V4H).
>
> This driver previously supported r8a779f0 (R-Car S4-8). PCIe features
> of both r8a779f0 and r8a779g0 are almost all the same. For example:
> - PCI Express Base Specification Revision 4.0
> - Root complex mode and endpoint mode are supported
> However, r8a779g0 requires specific firmware downloading, to
> initialize the PHY. Otherwise, the PCIe controller cannot work.
>
> The attached firmware file "104_PCIe_fw_addr_data_ver1.05.txt" in
> the datasheet is a text file. But, Renesas is not able to distribute
> the firmware freely. So, we require converting the text file
> to a binary before the driver runs by using the following script:
>
> $ awk '/^\s*0x[0-9A-Fa-f]{4}\s+0x[0-9A-Fa-f]{4}/ \
> { print substr($2,5,2) substr($2,3,2) }' \
> 104_PCIe_fw_addr_data_ver1.05.txt | xxd -p -r > \
> rcar_gen4_pcie.bin
> $ sha1sum rcar_gen4_pcie.bin
> 1d0bd4b189b4eb009f5d564b1f93a79112994945 rcar_gen4_pcie.bin
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
- Mani
> ---
> drivers/pci/controller/dwc/pcie-rcar-gen4.c | 207 +++++++++++++++++++-
> 1 file changed, 206 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/dwc/pcie-rcar-gen4.c b/drivers/pci/controller/dwc/pcie-rcar-gen4.c
> index dac78388975d..c67097e718d3 100644
> --- a/drivers/pci/controller/dwc/pcie-rcar-gen4.c
> +++ b/drivers/pci/controller/dwc/pcie-rcar-gen4.c
> @@ -5,8 +5,10 @@
> */
>
> #include <linux/delay.h>
> +#include <linux/firmware.h>
> #include <linux/interrupt.h>
> #include <linux/io.h>
> +#include <linux/iopoll.h>
> #include <linux/module.h>
> #include <linux/of.h>
> #include <linux/pci.h>
> @@ -20,9 +22,10 @@
> /* Renesas-specific */
> /* PCIe Mode Setting Register 0 */
> #define PCIEMSR0 0x0000
> -#define BIFUR_MOD_SET_ON BIT(0)
> +#define APP_SRIS_MODE BIT(6)
> #define DEVICE_TYPE_EP 0
> #define DEVICE_TYPE_RC BIT(4)
> +#define BIFUR_MOD_SET_ON BIT(0)
>
> /* PCIe Interrupt Status 0 */
> #define PCIEINTSTS0 0x0084
> @@ -37,19 +40,48 @@
> #define PCIEDMAINTSTSEN 0x0314
> #define PCIEDMAINTSTSEN_INIT GENMASK(15, 0)
>
> +/* Port Logic Registers 89 */
> +#define PRTLGC89 0x0b70
> +
> +/* Port Logic Registers 90 */
> +#define PRTLGC90 0x0b74
> +
> /* PCIe Reset Control Register 1 */
> #define PCIERSTCTRL1 0x0014
> #define APP_HOLD_PHY_RST BIT(16)
> #define APP_LTSSM_ENABLE BIT(0)
>
> +/* PCIe Power Management Control */
> +#define PCIEPWRMNGCTRL 0x0070
> +#define APP_CLK_REQ_N BIT(11)
> +#define APP_CLK_PM_EN BIT(10)
> +
> #define RCAR_NUM_SPEED_CHANGE_RETRIES 10
> #define RCAR_MAX_LINK_SPEED 4
>
> #define RCAR_GEN4_PCIE_EP_FUNC_DBI_OFFSET 0x1000
> #define RCAR_GEN4_PCIE_EP_FUNC_DBI2_OFFSET 0x800
>
> +/*
> + * The attached firmware file "104_PCIe_fw_addr_data_ver1.05.txt" in
> + * the datasheet is a text file. But, Renesas is not able to distribute
> + * the firmware freely. So, we require converting the text file
> + * to a binary before the driver runs by using the following script:
> + *
> + * $ awk '/^\s*0x[0-9A-Fa-f]{4}\s+0x[0-9A-Fa-f]{4}/ \
> + * { print substr($2,5,2) substr($2,3,2) }' \
> + * 104_PCIe_fw_addr_data_ver1.05.txt | xxd -p -r > \
> + * rcar_gen4_pcie.bin
> + * $ sha1sum rcar_gen4_pcie.bin
> + * 1d0bd4b189b4eb009f5d564b1f93a79112994945 rcar_gen4_pcie.bin
> + */
> +#define RCAR_GEN4_PCIE_FIRMWARE_NAME "rcar_gen4_pcie.bin"
> +#define RCAR_GEN4_PCIE_FIRMWARE_BASE_ADDR 0xc000
> +MODULE_FIRMWARE(RCAR_GEN4_PCIE_FIRMWARE_NAME);
> +
> struct rcar_gen4_pcie;
> struct rcar_gen4_pcie_drvdata {
> + void (*additional_common_init)(struct rcar_gen4_pcie *rcar);
> int (*ltssm_control)(struct rcar_gen4_pcie *rcar, bool enable);
> enum dw_pcie_device_mode mode;
> };
> @@ -57,6 +89,7 @@ struct rcar_gen4_pcie_drvdata {
> struct rcar_gen4_pcie {
> struct dw_pcie dw;
> void __iomem *base;
> + void __iomem *phy_base;
> struct platform_device *pdev;
> const struct rcar_gen4_pcie_drvdata *drvdata;
> };
> @@ -180,6 +213,9 @@ static int rcar_gen4_pcie_common_init(struct rcar_gen4_pcie *rcar)
> if (ret)
> goto err_unprepare;
>
> + if (rcar->drvdata->additional_common_init)
> + rcar->drvdata->additional_common_init(rcar);
> +
> return 0;
>
> err_unprepare:
> @@ -221,6 +257,10 @@ static void rcar_gen4_pcie_unprepare(struct rcar_gen4_pcie *rcar)
>
> static int rcar_gen4_pcie_get_resources(struct rcar_gen4_pcie *rcar)
> {
> + rcar->phy_base = devm_platform_ioremap_resource_byname(rcar->pdev, "phy");
> + if (IS_ERR(rcar->phy_base))
> + return PTR_ERR(rcar->phy_base);
> +
> /* Renesas-specific registers */
> rcar->base = devm_platform_ioremap_resource_byname(rcar->pdev, "app");
>
> @@ -528,6 +568,167 @@ static int r8a779f0_pcie_ltssm_control(struct rcar_gen4_pcie *rcar, bool enable)
> return 0;
> }
>
> +static void rcar_gen4_pcie_additional_common_init(struct rcar_gen4_pcie *rcar)
> +{
> + struct dw_pcie *dw = &rcar->dw;
> + u32 val;
> +
> + val = dw_pcie_readl_dbi(dw, PCIE_PORT_LANE_SKEW);
> + val &= ~PORT_LANE_SKEW_INSERT_MASK;
> + if (dw->num_lanes < 4)
> + val |= BIT(6);
> + dw_pcie_writel_dbi(dw, PCIE_PORT_LANE_SKEW, val);
> +
> + val = readl(rcar->base + PCIEPWRMNGCTRL);
> + val |= APP_CLK_REQ_N | APP_CLK_PM_EN;
> + writel(val, rcar->base + PCIEPWRMNGCTRL);
> +}
> +
> +static void rcar_gen4_pcie_phy_reg_update_bits(struct rcar_gen4_pcie *rcar,
> + u32 offset, u32 mask, u32 val)
> +{
> + u32 tmp;
> +
> + tmp = readl(rcar->phy_base + offset);
> + tmp &= ~mask;
> + tmp |= val;
> + writel(tmp, rcar->phy_base + offset);
> +}
> +
> +/*
> + * SoC datasheet suggests checking port logic register bits during firmware
> + * write. If read returns non-zero value, then this function returns -EAGAIN
> + * indicating that the write needs to be done again. If read returns zero,
> + * then return 0 to indicate success.
> + */
> +static int rcar_gen4_pcie_reg_test_bit(struct rcar_gen4_pcie *rcar,
> + u32 offset, u32 mask)
> +{
> + struct dw_pcie *dw = &rcar->dw;
> +
> + if (dw_pcie_readl_dbi(dw, offset) & mask)
> + return -EAGAIN;
> +
> + return 0;
> +}
> +
> +static int rcar_gen4_pcie_download_phy_firmware(struct rcar_gen4_pcie *rcar)
> +{
> + /* The check_addr values are magical numbers in the datasheet */
> + const u32 check_addr[] = { 0x00101018, 0x00101118, 0x00101021, 0x00101121};
> + struct dw_pcie *dw = &rcar->dw;
> + const struct firmware *fw;
> + unsigned int i, timeout;
> + u32 data;
> + int ret;
> +
> + ret = request_firmware(&fw, RCAR_GEN4_PCIE_FIRMWARE_NAME, dw->dev);
> + if (ret) {
> + dev_err(dw->dev, "Failed to load firmware (%s): %d\n",
> + RCAR_GEN4_PCIE_FIRMWARE_NAME, ret);
> + return ret;
> + }
> +
> + for (i = 0; i < (fw->size / 2); i++) {
> + data = fw->data[(i * 2) + 1] << 8 | fw->data[i * 2];
> + timeout = 100;
> + do {
> + dw_pcie_writel_dbi(dw, PRTLGC89, RCAR_GEN4_PCIE_FIRMWARE_BASE_ADDR + i);
> + dw_pcie_writel_dbi(dw, PRTLGC90, data);
> + if (!rcar_gen4_pcie_reg_test_bit(rcar, PRTLGC89, BIT(30)))
> + break;
> + if (!(--timeout)) {
> + ret = -ETIMEDOUT;
> + goto exit;
> + }
> + usleep_range(100, 200);
> + } while (1);
> + }
> +
> + rcar_gen4_pcie_phy_reg_update_bits(rcar, 0x0f8, BIT(17), BIT(17));
> +
> + for (i = 0; i < ARRAY_SIZE(check_addr); i++) {
> + timeout = 100;
> + do {
> + dw_pcie_writel_dbi(dw, PRTLGC89, check_addr[i]);
> + ret = rcar_gen4_pcie_reg_test_bit(rcar, PRTLGC89, BIT(30));
> + ret |= rcar_gen4_pcie_reg_test_bit(rcar, PRTLGC90, BIT(0));
> + if (!ret)
> + break;
> + if (!(--timeout)) {
> + ret = -ETIMEDOUT;
> + goto exit;
> + }
> + usleep_range(100, 200);
> + } while (1);
> + }
> +
> +exit:
> + release_firmware(fw);
> +
> + return ret;
> +}
> +
> +static int rcar_gen4_pcie_ltssm_control(struct rcar_gen4_pcie *rcar, bool enable)
> +{
> + struct dw_pcie *dw = &rcar->dw;
> + u32 val;
> + int ret;
> +
> + if (!enable) {
> + val = readl(rcar->base + PCIERSTCTRL1);
> + val &= ~APP_LTSSM_ENABLE;
> + writel(val, rcar->base + PCIERSTCTRL1);
> +
> + return 0;
> + }
> +
> + val = dw_pcie_readl_dbi(dw, PCIE_PORT_FORCE);
> + val |= PORT_FORCE_DO_DESKEW_FOR_SRIS;
> + dw_pcie_writel_dbi(dw, PCIE_PORT_FORCE, val);
> +
> + val = readl(rcar->base + PCIEMSR0);
> + val |= APP_SRIS_MODE;
> + writel(val, rcar->base + PCIEMSR0);
> +
> + /*
> + * The R-Car Gen4 datasheet doesn't describe the PHY registers' name.
> + * But, the initialization procedure describes these offsets. So,
> + * this driver has magical offset numbers.
> + */
> + rcar_gen4_pcie_phy_reg_update_bits(rcar, 0x700, BIT(28), 0);
> + rcar_gen4_pcie_phy_reg_update_bits(rcar, 0x700, BIT(20), 0);
> + rcar_gen4_pcie_phy_reg_update_bits(rcar, 0x700, BIT(12), 0);
> + rcar_gen4_pcie_phy_reg_update_bits(rcar, 0x700, BIT(4), 0);
> +
> + rcar_gen4_pcie_phy_reg_update_bits(rcar, 0x148, GENMASK(23, 22), BIT(22));
> + rcar_gen4_pcie_phy_reg_update_bits(rcar, 0x148, GENMASK(18, 16), GENMASK(17, 16));
> + rcar_gen4_pcie_phy_reg_update_bits(rcar, 0x148, GENMASK(7, 6), BIT(6));
> + rcar_gen4_pcie_phy_reg_update_bits(rcar, 0x148, GENMASK(2, 0), GENMASK(11, 0));
> + rcar_gen4_pcie_phy_reg_update_bits(rcar, 0x1d4, GENMASK(16, 15), GENMASK(16, 15));
> + rcar_gen4_pcie_phy_reg_update_bits(rcar, 0x514, BIT(26), BIT(26));
> + rcar_gen4_pcie_phy_reg_update_bits(rcar, 0x0f8, BIT(16), 0);
> + rcar_gen4_pcie_phy_reg_update_bits(rcar, 0x0f8, BIT(19), BIT(19));
> +
> + val = readl(rcar->base + PCIERSTCTRL1);
> + val &= ~APP_HOLD_PHY_RST;
> + writel(val, rcar->base + PCIERSTCTRL1);
> +
> + ret = readl_poll_timeout(rcar->phy_base + 0x0f8, val, !(val & BIT(18)), 100, 10000);
> + if (ret < 0)
> + return ret;
> +
> + ret = rcar_gen4_pcie_download_phy_firmware(rcar);
> + if (ret)
> + return ret;
> +
> + val = readl(rcar->base + PCIERSTCTRL1);
> + val |= APP_LTSSM_ENABLE;
> + writel(val, rcar->base + PCIERSTCTRL1);
> +
> + return 0;
> +}
> +
> static struct rcar_gen4_pcie_drvdata drvdata_r8a779f0_pcie = {
> .ltssm_control = r8a779f0_pcie_ltssm_control,
> .mode = DW_PCIE_RC_TYPE,
> @@ -539,10 +740,14 @@ static struct rcar_gen4_pcie_drvdata drvdata_r8a779f0_pcie_ep = {
> };
>
> static struct rcar_gen4_pcie_drvdata drvdata_rcar_gen4_pcie = {
> + .additional_common_init = rcar_gen4_pcie_additional_common_init,
> + .ltssm_control = rcar_gen4_pcie_ltssm_control,
> .mode = DW_PCIE_RC_TYPE,
> };
>
> static struct rcar_gen4_pcie_drvdata drvdata_rcar_gen4_pcie_ep = {
> + .additional_common_init = rcar_gen4_pcie_additional_common_init,
> + .ltssm_control = rcar_gen4_pcie_ltssm_control,
> .mode = DW_PCIE_EP_TYPE,
> };
>
> --
> 2.25.1
>
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH v9 4/5] PCI: rcar-gen4: Add support for r8a779g0
2024-06-11 12:50 ` [PATCH v9 4/5] PCI: rcar-gen4: Add support for r8a779g0 Yoshihiro Shimoda
2024-06-18 7:09 ` Manivannan Sadhasivam
2024-06-23 13:16 ` Manivannan Sadhasivam
@ 2024-06-29 19:56 ` Krzysztof Wilczyński
2024-07-01 4:07 ` Yoshihiro Shimoda
2024-07-02 17:14 ` Bjorn Helgaas
3 siblings, 1 reply; 25+ messages in thread
From: Krzysztof Wilczyński @ 2024-06-29 19:56 UTC (permalink / raw)
To: Yoshihiro Shimoda
Cc: lpieralisi, robh, bhelgaas, jingoohan1, mani, marek.vasut+renesas,
linux-pci, linux-renesas-soc
Hello,
[...]
> +/*
> + * The attached firmware file "104_PCIe_fw_addr_data_ver1.05.txt" in
> + * the datasheet is a text file. But, Renesas is not able to distribute
> + * the firmware freely. So, we require converting the text file
> + * to a binary before the driver runs by using the following script:
> + *
> + * $ awk '/^\s*0x[0-9A-Fa-f]{4}\s+0x[0-9A-Fa-f]{4}/ \
> + * { print substr($2,5,2) substr($2,3,2) }' \
> + * 104_PCIe_fw_addr_data_ver1.05.txt | xxd -p -r > \
> + * rcar_gen4_pcie.bin
> + * $ sha1sum rcar_gen4_pcie.bin
> + * 1d0bd4b189b4eb009f5d564b1f93a79112994945 rcar_gen4_pcie.bin
> + */
I moved this comment to the top of the file, since it serves as more of
a documentation bit for the controller itself, and is not specific to the
function it was attached to, strictly speaking.
That said, I wonder if we should include this at all? The file name might
and most likely will eventually change, as the datasheet gets updated to
include new revisions and erratas, etc.
So, I wonder if this is simply better to be included in the datasheet
itself, or some product guide and such, where Renesas can keep this up to
date and the users appraised of what they need to do to convert the
firmware correctly.
Users who do not have the datasheet and are not licensed wouldn't care.
Krzysztof
^ permalink raw reply [flat|nested] 25+ messages in thread* RE: [PATCH v9 4/5] PCI: rcar-gen4: Add support for r8a779g0
2024-06-29 19:56 ` Krzysztof Wilczyński
@ 2024-07-01 4:07 ` Yoshihiro Shimoda
2024-07-01 20:43 ` Krzysztof Wilczyński
0 siblings, 1 reply; 25+ messages in thread
From: Yoshihiro Shimoda @ 2024-07-01 4:07 UTC (permalink / raw)
To: Krzysztof Wilczyński
Cc: lpieralisi@kernel.org, robh@kernel.org, bhelgaas@google.com,
jingoohan1@gmail.com, mani@kernel.org,
marek.vasut+renesas@gmail.com, linux-pci@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Hello Krzysztof-san,
> From: Krzysztof Wilczyński, Sent: Sunday, June 30, 2024 4:56 AM
>
> Hello,
>
> [...]
> > +/*
> > + * The attached firmware file "104_PCIe_fw_addr_data_ver1.05.txt" in
> > + * the datasheet is a text file. But, Renesas is not able to distribute
> > + * the firmware freely. So, we require converting the text file
> > + * to a binary before the driver runs by using the following script:
> > + *
> > + * $ awk '/^\s*0x[0-9A-Fa-f]{4}\s+0x[0-9A-Fa-f]{4}/ \
> > + * { print substr($2,5,2) substr($2,3,2) }' \
> > + * 104_PCIe_fw_addr_data_ver1.05.txt | xxd -p -r > \
> > + * rcar_gen4_pcie.bin
> > + * $ sha1sum rcar_gen4_pcie.bin
> > + * 1d0bd4b189b4eb009f5d564b1f93a79112994945 rcar_gen4_pcie.bin
> > + */
>
> I moved this comment to the top of the file, since it serves as more of
> a documentation bit for the controller itself, and is not specific to the
> function it was attached to, strictly speaking.
I got it. Thank you.
> That said, I wonder if we should include this at all? The file name might
> and most likely will eventually change, as the datasheet gets updated to
> include new revisions and erratas, etc.
>
> So, I wonder if this is simply better to be included in the datasheet
> itself, or some product guide and such, where Renesas can keep this up to
> date and the users appraised of what they need to do to convert the
> firmware correctly.
I understood it. I'll consider it somehow...
> Users who do not have the datasheet and are not licensed wouldn't care.
Yes. If so, it's convenient.
Best regards,
Yoshihiro Shimoda
> Krzysztof
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH v9 4/5] PCI: rcar-gen4: Add support for r8a779g0
2024-07-01 4:07 ` Yoshihiro Shimoda
@ 2024-07-01 20:43 ` Krzysztof Wilczyński
2024-07-02 12:22 ` Yoshihiro Shimoda
0 siblings, 1 reply; 25+ messages in thread
From: Krzysztof Wilczyński @ 2024-07-01 20:43 UTC (permalink / raw)
To: Yoshihiro Shimoda
Cc: lpieralisi@kernel.org, robh@kernel.org, bhelgaas@google.com,
jingoohan1@gmail.com, mani@kernel.org,
marek.vasut+renesas@gmail.com, linux-pci@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
> > > +/*
> > > + * The attached firmware file "104_PCIe_fw_addr_data_ver1.05.txt" in
> > > + * the datasheet is a text file. But, Renesas is not able to distribute
> > > + * the firmware freely. So, we require converting the text file
> > > + * to a binary before the driver runs by using the following script:
> > > + *
> > > + * $ awk '/^\s*0x[0-9A-Fa-f]{4}\s+0x[0-9A-Fa-f]{4}/ \
> > > + * { print substr($2,5,2) substr($2,3,2) }' \
> > > + * 104_PCIe_fw_addr_data_ver1.05.txt | xxd -p -r > \
> > > + * rcar_gen4_pcie.bin
> > > + * $ sha1sum rcar_gen4_pcie.bin
> > > + * 1d0bd4b189b4eb009f5d564b1f93a79112994945 rcar_gen4_pcie.bin
> > > + */
> >
> > I moved this comment to the top of the file, since it serves as more of
> > a documentation bit for the controller itself, and is not specific to the
> > function it was attached to, strictly speaking.
>
> I got it. Thank you.
I decided to drop this comment. See below.
> > That said, I wonder if we should include this at all? The file name might
> > and most likely will eventually change, as the datasheet gets updated to
> > include new revisions and erratas, etc.
> >
> > So, I wonder if this is simply better to be included in the datasheet
> > itself, or some product guide and such, where Renesas can keep this up to
> > date and the users appraised of what they need to do to convert the
> > firmware correctly.
>
> I understood it. I'll consider it somehow...
After thinking about this a little more, I believe that it might be better
to follow what some other drivers have done, and simply add this guide as
a text file under a dedicated ../Documentation/admin-guide directory.
We can then mention, or not, at the top of the file that there is a guide
available at this location for people to read on how to obtain and prepare
the firmware.
Thoughts?
Krzysztof
^ permalink raw reply [flat|nested] 25+ messages in thread* RE: [PATCH v9 4/5] PCI: rcar-gen4: Add support for r8a779g0
2024-07-01 20:43 ` Krzysztof Wilczyński
@ 2024-07-02 12:22 ` Yoshihiro Shimoda
2024-07-03 8:32 ` Krzysztof Wilczyński
0 siblings, 1 reply; 25+ messages in thread
From: Yoshihiro Shimoda @ 2024-07-02 12:22 UTC (permalink / raw)
To: Krzysztof Wilczyński
Cc: lpieralisi@kernel.org, robh@kernel.org, bhelgaas@google.com,
jingoohan1@gmail.com, mani@kernel.org,
marek.vasut+renesas@gmail.com, linux-pci@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Hello Krzysztof-san,
> From: Krzysztof Wilczyński, Sent: Tuesday, July 2, 2024 5:44 AM
> > > > +/*
> > > > + * The attached firmware file "104_PCIe_fw_addr_data_ver1.05.txt" in
> > > > + * the datasheet is a text file. But, Renesas is not able to distribute
> > > > + * the firmware freely. So, we require converting the text file
> > > > + * to a binary before the driver runs by using the following script:
> > > > + *
> > > > + * $ awk '/^\s*0x[0-9A-Fa-f]{4}\s+0x[0-9A-Fa-f]{4}/ \
> > > > + * { print substr($2,5,2) substr($2,3,2) }' \
> > > > + * 104_PCIe_fw_addr_data_ver1.05.txt | xxd -p -r > \
> > > > + * rcar_gen4_pcie.bin
> > > > + * $ sha1sum rcar_gen4_pcie.bin
> > > > + * 1d0bd4b189b4eb009f5d564b1f93a79112994945 rcar_gen4_pcie.bin
> > > > + */
> > >
> > > I moved this comment to the top of the file, since it serves as more of
> > > a documentation bit for the controller itself, and is not specific to the
> > > function it was attached to, strictly speaking.
> >
> > I got it. Thank you.
>
> I decided to drop this comment. See below.
I got it.
> > > That said, I wonder if we should include this at all? The file name might
> > > and most likely will eventually change, as the datasheet gets updated to
> > > include new revisions and erratas, etc.
> > >
> > > So, I wonder if this is simply better to be included in the datasheet
> > > itself, or some product guide and such, where Renesas can keep this up to
> > > date and the users appraised of what they need to do to convert the
> > > firmware correctly.
> >
> > I understood it. I'll consider it somehow...
>
> After thinking about this a little more, I believe that it might be better
> to follow what some other drivers have done, and simply add this guide as
> a text file under a dedicated ../Documentation/admin-guide directory.
>
> We can then mention, or not, at the top of the file that there is a guide
> available at this location for people to read on how to obtain and prepare
> the firmware.
>
> Thoughts?
Thank you for your comments. I agreed. So, may I send such a patch? Or, should
I send whole patches as v10?
Best regards,
Yoshihiro Shimoda
> Krzysztof
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH v9 4/5] PCI: rcar-gen4: Add support for r8a779g0
2024-07-02 12:22 ` Yoshihiro Shimoda
@ 2024-07-03 8:32 ` Krzysztof Wilczyński
2024-07-03 9:34 ` Yoshihiro Shimoda
0 siblings, 1 reply; 25+ messages in thread
From: Krzysztof Wilczyński @ 2024-07-03 8:32 UTC (permalink / raw)
To: Yoshihiro Shimoda
Cc: lpieralisi@kernel.org, robh@kernel.org, bhelgaas@google.com,
jingoohan1@gmail.com, mani@kernel.org,
marek.vasut+renesas@gmail.com, linux-pci@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
[...]
> > After thinking about this a little more, I believe that it might be better
> > to follow what some other drivers have done, and simply add this guide as
> > a text file under a dedicated ../Documentation/admin-guide directory.
> >
> > We can then mention, or not, at the top of the file that there is a guide
> > available at this location for people to read on how to obtain and prepare
> > the firmware.
> >
> > Thoughts?
>
> Thank you for your comments. I agreed. So, may I send such a patch? Or, should
> I send whole patches as v10?
No need to send a new series. A small patch that I can pick would be fine.
Thank you!
Krzysztof
^ permalink raw reply [flat|nested] 25+ messages in thread
* RE: [PATCH v9 4/5] PCI: rcar-gen4: Add support for r8a779g0
2024-07-03 8:32 ` Krzysztof Wilczyński
@ 2024-07-03 9:34 ` Yoshihiro Shimoda
0 siblings, 0 replies; 25+ messages in thread
From: Yoshihiro Shimoda @ 2024-07-03 9:34 UTC (permalink / raw)
To: Krzysztof Wilczyński
Cc: lpieralisi@kernel.org, robh@kernel.org, bhelgaas@google.com,
jingoohan1@gmail.com, mani@kernel.org,
marek.vasut+renesas@gmail.com, linux-pci@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Hello Krzysztof-san,
> From: Krzysztof Wilczyński, Sent: Wednesday, July 3, 2024 5:32 PM
> [...]
> > > After thinking about this a little more, I believe that it might be better
> > > to follow what some other drivers have done, and simply add this guide as
> > > a text file under a dedicated ../Documentation/admin-guide directory.
> > >
> > > We can then mention, or not, at the top of the file that there is a guide
> > > available at this location for people to read on how to obtain and prepare
> > > the firmware.
> > >
> > > Thoughts?
> >
> > Thank you for your comments. I agreed. So, may I send such a patch? Or, should
> > I send whole patches as v10?
>
> No need to send a new series. A small patch that I can pick would be fine.
I got it. I'll send such a small patch soon.
Best regards,
Yoshihiro Shimoda
> Thank you!
>
> Krzysztof
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v9 4/5] PCI: rcar-gen4: Add support for r8a779g0
2024-06-11 12:50 ` [PATCH v9 4/5] PCI: rcar-gen4: Add support for r8a779g0 Yoshihiro Shimoda
` (2 preceding siblings ...)
2024-06-29 19:56 ` Krzysztof Wilczyński
@ 2024-07-02 17:14 ` Bjorn Helgaas
2024-07-02 23:57 ` Yoshihiro Shimoda
3 siblings, 1 reply; 25+ messages in thread
From: Bjorn Helgaas @ 2024-07-02 17:14 UTC (permalink / raw)
To: Yoshihiro Shimoda
Cc: lpieralisi, kw, robh, bhelgaas, jingoohan1, mani,
marek.vasut+renesas, linux-pci, linux-renesas-soc
On Tue, Jun 11, 2024 at 09:50:56PM +0900, Yoshihiro Shimoda wrote:
> Add support for r8a779g0 (R-Car V4H).
>
> This driver previously supported r8a779f0 (R-Car S4-8). PCIe features
> of both r8a779f0 and r8a779g0 are almost all the same. For example:
> - PCI Express Base Specification Revision 4.0
This item is too general to be really useful. I don't think it means
the device supports every feature described in the r4.0 spec. I
suspect it means it supports the 16.0 GT/s transfer rate that was
added in r4.0? *That* would be useful information here. Perhaps also
the number of lanes it supports.
^ permalink raw reply [flat|nested] 25+ messages in thread* RE: [PATCH v9 4/5] PCI: rcar-gen4: Add support for r8a779g0
2024-07-02 17:14 ` Bjorn Helgaas
@ 2024-07-02 23:57 ` Yoshihiro Shimoda
0 siblings, 0 replies; 25+ messages in thread
From: Yoshihiro Shimoda @ 2024-07-02 23:57 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: lpieralisi@kernel.org, kw@linux.com, robh@kernel.org,
bhelgaas@google.com, jingoohan1@gmail.com, mani@kernel.org,
marek.vasut+renesas@gmail.com, linux-pci@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Hello Bjorn,
> From: Bjorn Helgaas, Sent: Wednesday, July 3, 2024 2:14 AM
>
> On Tue, Jun 11, 2024 at 09:50:56PM +0900, Yoshihiro Shimoda wrote:
> > Add support for r8a779g0 (R-Car V4H).
> >
> > This driver previously supported r8a779f0 (R-Car S4-8). PCIe features
> > of both r8a779f0 and r8a779g0 are almost all the same. For example:
> > - PCI Express Base Specification Revision 4.0
>
> This item is too general to be really useful. I don't think it means
> the device supports every feature described in the r4.0 spec. I
> suspect it means it supports the 16.0 GT/s transfer rate that was
> added in r4.0? *That* would be useful information here. Perhaps also
> the number of lanes it supports.
You're correct. The device doesn't support every feature described in the r4.0 spec.
The device supports the 16.0 GT/s transfer rate. Also, it supports up to 4 lanes.
Best regards,
Yoshihiro Shimoda
^ permalink raw reply [flat|nested] 25+ messages in thread