From: Matthew W Carlis <mattc@purestorage.com>
To: macro@orcam.me.uk
Cc: bhelgaas@google.com, ilpo.jarvinen@linux.intel.com,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
mattc@purestorage.com, mika.westerberg@linux.intel.com,
oohall@gmail.com
Subject: Re: [PATCH v2 2/4] PCI: Revert to the original speed after PCIe failed link retraining
Date: Wed, 14 Aug 2024 23:57:32 -0600 [thread overview]
Message-ID: <20240815055732.25252-1-mattc@purestorage.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2408091204580.61955@angie.orcam.me.uk>
Sorry past few days have been struggling to buy some time to look at these. Every
time I go into the store and ask for more time they try to give me phone cards.
Its an improvement to restore the "capable" link speed & in this case I think we're
also enabling a user to have over-ridden it if they were to write the register
by hand. Its nice to give every potentially "new" device a chance at achieving
its full potential.
A little outside of the scope of this patch, but I was wondering if the logline
should be a warn level logline? I don't honestly know what a "normal" level is
for the pci system. Also, instead of saying "retraining ... at 2.5GT/s\n",
would it be more clear if it said "forcing downstream link to 2.5GT/s". In my mind
its more clear that an action has been taken which produces a potentially less
than unexpected speed.
I can test this patch on a couple of systems, but I need a week or so to
get it done...
Reviewed-by: Matthew Carlis <mattc@purestorage.com>
next prev parent reply other threads:[~2024-08-15 5:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-09 13:24 [PATCH v2 0/4] PCI: Rework error reporting with PCIe failed link retraining Maciej W. Rozycki
2024-08-09 13:24 ` [PATCH v2 1/4] PCI: Clear the LBMS bit after a link retrain Maciej W. Rozycki
2024-08-12 10:35 ` Ilpo Järvinen
2024-08-12 14:21 ` Maciej W. Rozycki
2024-08-09 13:24 ` [PATCH v2 2/4] PCI: Revert to the original speed after PCIe failed link retraining Maciej W. Rozycki
2024-08-12 10:36 ` Ilpo Järvinen
2024-08-15 5:57 ` Matthew W Carlis [this message]
2024-08-22 9:13 ` Ilpo Järvinen
2024-08-25 13:48 ` Maciej W. Rozycki
2024-08-09 13:24 ` [PATCH v2 3/4] PCI: Correct error reporting with " Maciej W. Rozycki
2024-08-09 13:25 ` [PATCH v2 4/4] PCI: Use an error code " Maciej W. Rozycki
2024-08-09 19:57 ` [PATCH v2 0/4] PCI: Rework error reporting " Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240815055732.25252-1-mattc@purestorage.com \
--to=mattc@purestorage.com \
--cc=bhelgaas@google.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=macro@orcam.me.uk \
--cc=mika.westerberg@linux.intel.com \
--cc=oohall@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox