Linux PCI subsystem development
 help / color / mirror / Atom feed
* [pci:controller/rockchip] BUILD SUCCESS 592aac418ebdf451fe9b146bc2ca6dfc96921af0
@ 2024-11-17 16:01 kernel test robot
  2024-11-19 15:19 ` Bjorn Helgaas
  0 siblings, 1 reply; 6+ messages in thread
From: kernel test robot @ 2024-11-17 16:01 UTC (permalink / raw)
  To: Bjorn Helgaas; +Cc: linux-pci

tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git controller/rockchip
branch HEAD: 592aac418ebdf451fe9b146bc2ca6dfc96921af0  PCI: rockchip-ep: Handle PERST# signal in endpoint mode

elapsed time: 1460m

configs tested: 173
configs skipped: 4

The following configs have been built successfully.
More configs may be tested in the coming days.

tested configs:
alpha                            alldefconfig    gcc-13.2.0
alpha                             allnoconfig    gcc-14.2.0
alpha                               defconfig    gcc-14.2.0
arc                              allmodconfig    clang-20
arc                               allnoconfig    gcc-14.2.0
arc                              allyesconfig    clang-20
arc                                 defconfig    gcc-14.2.0
arc                     nsimosci_hs_defconfig    gcc-13.2.0
arc                   randconfig-001-20241117    clang-20
arc                   randconfig-002-20241117    clang-20
arm                              allmodconfig    clang-20
arm                               allnoconfig    gcc-14.2.0
arm                              allyesconfig    clang-20
arm                          collie_defconfig    clang-20
arm                                 defconfig    gcc-14.2.0
arm                          ixp4xx_defconfig    clang-20
arm                        multi_v7_defconfig    clang-20
arm                         nhk8815_defconfig    clang-20
arm                          pxa3xx_defconfig    clang-20
arm                             pxa_defconfig    clang-20
arm                   randconfig-001-20241117    clang-20
arm                   randconfig-002-20241117    clang-20
arm                   randconfig-003-20241117    clang-20
arm                   randconfig-004-20241117    clang-20
arm                         s5pv210_defconfig    clang-20
arm                           sama7_defconfig    clang-20
arm                           sunxi_defconfig    clang-20
arm                           u8500_defconfig    clang-20
arm                       versatile_defconfig    clang-20
arm64                            allmodconfig    clang-20
arm64                             allnoconfig    gcc-14.2.0
arm64                               defconfig    gcc-14.2.0
arm64                 randconfig-001-20241117    clang-20
arm64                 randconfig-002-20241117    clang-20
arm64                 randconfig-003-20241117    clang-20
arm64                 randconfig-004-20241117    clang-20
csky                              allnoconfig    gcc-14.2.0
csky                                defconfig    gcc-14.2.0
csky                  randconfig-001-20241117    clang-20
csky                  randconfig-002-20241117    clang-20
hexagon                           allnoconfig    gcc-14.2.0
hexagon                             defconfig    gcc-14.2.0
hexagon               randconfig-001-20241117    clang-20
hexagon               randconfig-002-20241117    clang-20
i386                             allmodconfig    clang-19
i386                              allnoconfig    clang-19
i386                             allyesconfig    clang-19
i386        buildonly-randconfig-001-20241117    clang-19
i386        buildonly-randconfig-002-20241117    clang-19
i386        buildonly-randconfig-003-20241117    clang-19
i386        buildonly-randconfig-004-20241117    clang-19
i386        buildonly-randconfig-005-20241117    clang-19
i386        buildonly-randconfig-006-20241117    clang-19
i386                                defconfig    clang-19
i386                  randconfig-001-20241117    clang-19
i386                  randconfig-002-20241117    clang-19
i386                  randconfig-003-20241117    clang-19
i386                  randconfig-004-20241117    clang-19
i386                  randconfig-005-20241117    clang-19
i386                  randconfig-006-20241117    clang-19
i386                  randconfig-011-20241117    clang-19
i386                  randconfig-012-20241117    clang-19
i386                  randconfig-013-20241117    clang-19
i386                  randconfig-014-20241117    clang-19
i386                  randconfig-015-20241117    clang-19
i386                  randconfig-016-20241117    clang-19
loongarch                        allmodconfig    gcc-14.2.0
loongarch                         allnoconfig    gcc-14.2.0
loongarch                           defconfig    gcc-14.2.0
loongarch             randconfig-001-20241117    clang-20
loongarch             randconfig-002-20241117    clang-20
m68k                             allmodconfig    gcc-14.2.0
m68k                              allnoconfig    gcc-14.2.0
m68k                             allyesconfig    gcc-14.2.0
m68k                                defconfig    gcc-14.2.0
microblaze                       allmodconfig    gcc-14.2.0
microblaze                        allnoconfig    gcc-14.2.0
microblaze                       allyesconfig    gcc-14.2.0
microblaze                          defconfig    gcc-14.2.0
mips                              allnoconfig    gcc-14.2.0
mips                           mtx1_defconfig    gcc-13.2.0
mips                   sb1250_swarm_defconfig    clang-20
nios2                             allnoconfig    gcc-14.2.0
nios2                               defconfig    gcc-14.2.0
nios2                 randconfig-001-20241117    clang-20
nios2                 randconfig-002-20241117    clang-20
openrisc                          allnoconfig    clang-20
openrisc                            defconfig    gcc-12
parisc                            allnoconfig    clang-20
parisc                              defconfig    gcc-12
parisc                generic-64bit_defconfig    gcc-13.2.0
parisc                randconfig-001-20241117    clang-20
parisc                randconfig-002-20241117    clang-20
parisc64                            defconfig    gcc-14.2.0
powerpc                           allnoconfig    clang-20
powerpc                     ksi8560_defconfig    gcc-13.2.0
powerpc                 mpc8313_rdb_defconfig    gcc-13.2.0
powerpc                     rainier_defconfig    gcc-13.2.0
powerpc               randconfig-001-20241117    clang-20
powerpc               randconfig-002-20241117    clang-20
powerpc               randconfig-003-20241117    clang-20
powerpc                     sequoia_defconfig    gcc-13.2.0
powerpc64                        alldefconfig    clang-20
powerpc64             randconfig-001-20241117    clang-20
powerpc64             randconfig-002-20241117    clang-20
powerpc64             randconfig-003-20241117    clang-20
riscv                             allnoconfig    clang-20
riscv                               defconfig    gcc-12
riscv                 randconfig-001-20241117    clang-20
riscv                 randconfig-002-20241117    clang-20
s390                             allmodconfig    gcc-14.2.0
s390                              allnoconfig    clang-20
s390                             allyesconfig    gcc-14.2.0
s390                                defconfig    gcc-12
s390                  randconfig-001-20241117    clang-20
s390                  randconfig-002-20241117    clang-20
s390                       zfcpdump_defconfig    gcc-13.2.0
sh                               allmodconfig    gcc-14.2.0
sh                                allnoconfig    gcc-14.2.0
sh                               allyesconfig    gcc-14.2.0
sh                                  defconfig    gcc-12
sh                               j2_defconfig    gcc-13.2.0
sh                    randconfig-001-20241117    clang-20
sh                    randconfig-002-20241117    clang-20
sh                           se7206_defconfig    gcc-13.2.0
sh                           se7750_defconfig    gcc-13.2.0
sh                        sh7785lcr_defconfig    gcc-13.2.0
sh                            shmin_defconfig    clang-20
sh                          urquell_defconfig    gcc-13.2.0
sparc                            allmodconfig    gcc-14.2.0
sparc64                             defconfig    gcc-12
sparc64               randconfig-001-20241117    clang-20
sparc64               randconfig-002-20241117    clang-20
um                                allnoconfig    clang-20
um                                  defconfig    gcc-12
um                             i386_defconfig    gcc-12
um                    randconfig-001-20241117    clang-20
um                    randconfig-002-20241117    clang-20
um                           x86_64_defconfig    gcc-12
x86_64                            allnoconfig    clang-19
x86_64                           allyesconfig    clang-19
x86_64      buildonly-randconfig-001-20241117    gcc-12
x86_64      buildonly-randconfig-002-20241117    gcc-12
x86_64      buildonly-randconfig-003-20241117    gcc-12
x86_64      buildonly-randconfig-004-20241117    gcc-12
x86_64      buildonly-randconfig-005-20241117    gcc-12
x86_64      buildonly-randconfig-006-20241117    gcc-12
x86_64                              defconfig    clang-19
x86_64                                  kexec    gcc-12
x86_64                randconfig-001-20241117    gcc-12
x86_64                randconfig-002-20241117    gcc-12
x86_64                randconfig-003-20241117    gcc-12
x86_64                randconfig-004-20241117    gcc-12
x86_64                randconfig-005-20241117    gcc-12
x86_64                randconfig-006-20241117    gcc-12
x86_64                randconfig-011-20241117    gcc-12
x86_64                randconfig-012-20241117    gcc-12
x86_64                randconfig-013-20241117    gcc-12
x86_64                randconfig-014-20241117    gcc-12
x86_64                randconfig-015-20241117    gcc-12
x86_64                randconfig-016-20241117    gcc-12
x86_64                randconfig-071-20241117    gcc-12
x86_64                randconfig-072-20241117    gcc-12
x86_64                randconfig-073-20241117    gcc-12
x86_64                randconfig-074-20241117    gcc-12
x86_64                randconfig-075-20241117    gcc-12
x86_64                randconfig-076-20241117    gcc-12
x86_64                               rhel-8.3    gcc-12
xtensa                            allnoconfig    gcc-14.2.0
xtensa                          iss_defconfig    clang-20
xtensa                randconfig-001-20241117    clang-20
xtensa                randconfig-002-20241117    clang-20
xtensa                    xip_kc705_defconfig    clang-20

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [pci:controller/rockchip] BUILD SUCCESS 592aac418ebdf451fe9b146bc2ca6dfc96921af0
  2024-11-17 16:01 [pci:controller/rockchip] BUILD SUCCESS 592aac418ebdf451fe9b146bc2ca6dfc96921af0 kernel test robot
@ 2024-11-19 15:19 ` Bjorn Helgaas
  2024-11-19 18:02   ` Krzysztof Wilczyński
                     ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Bjorn Helgaas @ 2024-11-19 15:19 UTC (permalink / raw)
  To: kernel test robot; +Cc: linux-pci, Krzysztof Wilczyński, Damien Le Moal

On Mon, Nov 18, 2024 at 12:01:12AM +0800, kernel test robot wrote:
> tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git controller/rockchip
> branch HEAD: 592aac418ebdf451fe9b146bc2ca6dfc96921af0  PCI: rockchip-ep: Handle PERST# signal in endpoint mode

> x86_64                           allyesconfig    clang-19

How can I reproduce this build?  Do you have a packaged clang-19
toolchain?

The x86_64 allyesconfig build succeeded for the robot, but when I
build on x86_64 with gcc-11.4.0, I get an error:

  $ gcc -v
  gcc version 11.4.0 (Ubuntu 11.4.0-1ubuntu1~22.04)
  $ git checkout 592aac418ebd
  $ make allyesconfig
  $ make drivers/pci/controller/pcie-rockchip-ep.o
    CC      drivers/pci/controller/pcie-rockchip-ep.o
  drivers/pci/controller/pcie-rockchip-ep.c:640:9: error: implicit declaration of function ‘irq_set_irq_type’

irq_set_irq_type() is declared in <linux/irq.h>.  On arm64, where this
driver is used, <linux/irq.h> is included via this path:

  linux/pci.h
    linux/interrupt.h
      linux/hardirq.h
	arch/arm64/include/asm/hardirq.h
	  asm-generic/hardirq.h
	    linux/irq.h

but on x86, arch/x86/include/asm/hardirq.h does not include
asm-generic/hardirq.h and therefore doesn't include <linux/irq.h>.

I'm confused about why the robot reported a successful build with
clang-19.  It seems like that should have the same problem I saw with
gcc, so I'd like to try it manually.

Bjorn

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [pci:controller/rockchip] BUILD SUCCESS 592aac418ebdf451fe9b146bc2ca6dfc96921af0
  2024-11-19 15:19 ` Bjorn Helgaas
@ 2024-11-19 18:02   ` Krzysztof Wilczyński
  2024-11-21  3:00   ` Damien Le Moal
  2024-11-21  4:37   ` Philip Li
  2 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Wilczyński @ 2024-11-19 18:02 UTC (permalink / raw)
  To: Bjorn Helgaas; +Cc: kernel test robot, linux-pci, Damien Le Moal

Hello,

[...]
> irq_set_irq_type() is declared in <linux/irq.h>.  On arm64, where this
> driver is used, <linux/irq.h> is included via this path:
> 
>   linux/pci.h
>     linux/interrupt.h
>       linux/hardirq.h
> 	arch/arm64/include/asm/hardirq.h
> 	  asm-generic/hardirq.h
> 	    linux/irq.h
> 
> but on x86, arch/x86/include/asm/hardirq.h does not include
> asm-generic/hardirq.h and therefore doesn't include <linux/irq.h>.
> 
> I'm confused about why the robot reported a successful build with
> clang-19.  It seems like that should have the same problem I saw with
> gcc, so I'd like to try it manually.

I am not sure how the bot built this, too.  I can't seem to successfully
built it either locally using LLVM 19, per:

  drivers/pci/controller/pcie-rockchip-ep.o
  # CC      drivers/pci/controller/pcie-rockchip-ep.o - due to target missing
    clang-19 -Wp,-MMD,drivers/pci/controller/.pcie-rockchip-ep.o.d -nostdinc -I./arch/x86/include -I./arch/x86/include/generated  -I./include -I./arch/x86/include/uapi -I./arch/x86/include/generated/uapi -I./include/uapi -I./include/generated/uapi -include ./include/linux/compiler-version.h -include ./include/linux/kconfig.h -include ./include/linux/compiler_types.h -D__KERNEL__ --target=x86_64-linux-gnu -fintegrated-as -Werror=unknown-warning-option -Werror=ignored-optimization-argument -Werror=option-ignored -Werror=unused-command-line-argument -fmacro-prefix-map=./= -std=gnu11 -fshort-wchar -funsigned-char -fno-common -fno-PIE -fno-strict-aliasing -mno-sse -mno-mmx -mno-sse2 -mno-3dnow -mno-avx -fcf-protection=branch -fno-jump-tables -m64 -falign-loops=1 -mno-80387 -mno-fp-ret-in-387 -mstack-alignment=8 -mskip-rax-setup -mtune=generic -mno-red-zone -mcmodel=kernel -Wno-sign-compare -fno-asynchronous-unwind-tables -mretpoline-external-thunk -mindirect-branch-cs-prefix -mfunction-return=thunk-extern -fpatchable-function-entry=16,16 -fno-delete-null-pointer-checks -O2 -fstack-protector-strong -fomit-frame-pointer -ftrivial-auto-var-init=zero -fno-stack-clash-protection -falign-functions=16 -fstrict-flex-arrays=3 -fno-strict-overflow -fno-stack-check -Wall -Wundef -Werror=implicit-function-declaration -Werror=implicit-int -Werror=return-type -Werror=strict-prototypes -Wno-format-security -Wno-trigraphs -Wno-frame-address -Wno-address-of-packed-member -Wmissing-declarations -Wmissing-prototypes -Wframe-larger-than=2048 -Wno-gnu -Wvla -Wno-pointer-sign -Wcast-function-type -Wimplicit-fallthrough -Werror=date-time -Werror=incompatible-pointer-types -Wenum-conversion -Wextra -Wunused -Wno-unused-but-set-variable -Wno-unused-const-variable -Wno-format-overflow -Wno-format-overflow-non-kprintf -Wno-format-truncation-non-kprintf -Wno-override-init -Wno-pointer-to-enum-cast -Wno-tautological-constant-out-of-range-compare -Wno-unaligned-access -Wno-enum-compare-conditional -Wno-enum-enum-conversion -Wno-missing-field-initializers -Wno-type-limits -Wno-shift-negative-value -Wno-sign-compare -Wno-unused-parameter    -DKBUILD_MODFILE='"drivers/pci/controller/pcie-rockchip-ep"' -DKBUILD_BASENAME='"pcie_rockchip_ep"' -DKBUILD_MODNAME='"pcie_rockchip_ep"' -D__KBUILD_MODNAME=kmod_pcie_rockchip_ep -c -o drivers/pci/controller/pcie-rockchip-ep.o drivers/pci/controller/pcie-rockchip-ep.c  
  drivers/pci/controller/pcie-rockchip-ep.c:640:2: error: call to undeclared function 'irq_set_irq_type'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    640 |         irq_set_irq_type(ep->perst_irq,
        |         ^
  drivers/pci/controller/pcie-rockchip-ep.c:640:2: note: did you mean 'irq_set_irq_wake'?
  ./include/linux/interrupt.h:489:12: note: 'irq_set_irq_wake' declared here
    489 | extern int irq_set_irq_wake(unsigned int irq, unsigned int on);
        |            ^
  drivers/pci/controller/pcie-rockchip-ep.c:672:2: error: call to undeclared function 'irq_set_status_flags'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    672 |         irq_set_status_flags(ep->perst_irq, IRQ_NOAUTOEN);
        |         ^
  drivers/pci/controller/pcie-rockchip-ep.c:672:38: error: use of undeclared identifier 'IRQ_NOAUTOEN'
    672 |         irq_set_status_flags(ep->perst_irq, IRQ_NOAUTOEN);
        |                                             ^
  3 errors generated.
  make[5]: *** [scripts/Makefile.build:229: drivers/pci/controller/pcie-rockchip-ep.o] Error 1
  make[4]: *** [scripts/Makefile.build:478: drivers/pci/controller] Error 2
  make[3]: *** [scripts/Makefile.build:478: drivers/pci] Error 2
  make[2]: *** [scripts/Makefile.build:478: drivers] Error 2
  make[1]: *** [/home/kwilczynski/Development/Pr

Of course, adding the missing header fixes the build issue.  This is how
I also fixed it on the branch itself, for reference.

	Krzysztof

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [pci:controller/rockchip] BUILD SUCCESS 592aac418ebdf451fe9b146bc2ca6dfc96921af0
  2024-11-19 15:19 ` Bjorn Helgaas
  2024-11-19 18:02   ` Krzysztof Wilczyński
@ 2024-11-21  3:00   ` Damien Le Moal
  2024-11-21  4:37   ` Philip Li
  2 siblings, 0 replies; 6+ messages in thread
From: Damien Le Moal @ 2024-11-21  3:00 UTC (permalink / raw)
  To: Bjorn Helgaas, kernel test robot; +Cc: linux-pci, Krzysztof Wilczyński

On 11/20/24 00:19, Bjorn Helgaas wrote:
> On Mon, Nov 18, 2024 at 12:01:12AM +0800, kernel test robot wrote:
>> tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git controller/rockchip
>> branch HEAD: 592aac418ebdf451fe9b146bc2ca6dfc96921af0  PCI: rockchip-ep: Handle PERST# signal in endpoint mode
> 
>> x86_64                           allyesconfig    clang-19
> 
> How can I reproduce this build?  Do you have a packaged clang-19
> toolchain?
> 
> The x86_64 allyesconfig build succeeded for the robot, but when I
> build on x86_64 with gcc-11.4.0, I get an error:
> 
>   $ gcc -v
>   gcc version 11.4.0 (Ubuntu 11.4.0-1ubuntu1~22.04)
>   $ git checkout 592aac418ebd
>   $ make allyesconfig
>   $ make drivers/pci/controller/pcie-rockchip-ep.o
>     CC      drivers/pci/controller/pcie-rockchip-ep.o
>   drivers/pci/controller/pcie-rockchip-ep.c:640:9: error: implicit declaration of function ‘irq_set_irq_type’

Using gcc v14.2 here (Fedora 40/41) and never saw this compilation error. Weird.

> 
> irq_set_irq_type() is declared in <linux/irq.h>.  On arm64, where this
> driver is used, <linux/irq.h> is included via this path:
> 
>   linux/pci.h
>     linux/interrupt.h
>       linux/hardirq.h
> 	arch/arm64/include/asm/hardirq.h
> 	  asm-generic/hardirq.h
> 	    linux/irq.h
> 
> but on x86, arch/x86/include/asm/hardirq.h does not include
> asm-generic/hardirq.h and therefore doesn't include <linux/irq.h>.
> 
> I'm confused about why the robot reported a successful build with
> clang-19.  It seems like that should have the same problem I saw with
> gcc, so I'd like to try it manually.
> 
> Bjorn


-- 
Damien Le Moal
Western Digital Research

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [pci:controller/rockchip] BUILD SUCCESS 592aac418ebdf451fe9b146bc2ca6dfc96921af0
  2024-11-19 15:19 ` Bjorn Helgaas
  2024-11-19 18:02   ` Krzysztof Wilczyński
  2024-11-21  3:00   ` Damien Le Moal
@ 2024-11-21  4:37   ` Philip Li
  2024-11-21  7:59     ` Philip Li
  2 siblings, 1 reply; 6+ messages in thread
From: Philip Li @ 2024-11-21  4:37 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: kernel test robot, linux-pci, Krzysztof Wilczyński,
	Damien Le Moal

On Tue, Nov 19, 2024 at 09:19:25AM -0600, Bjorn Helgaas wrote:
> On Mon, Nov 18, 2024 at 12:01:12AM +0800, kernel test robot wrote:
> > tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git controller/rockchip
> > branch HEAD: 592aac418ebdf451fe9b146bc2ca6dfc96921af0  PCI: rockchip-ep: Handle PERST# signal in endpoint mode
> 
> > x86_64                           allyesconfig    clang-19

Let me double check this why it is success.

Actually, the bot report "implicit declaration of function 'irq_set_status_flags'" at [1]
with sparc64-linux-gcc and sparc-allmodconfig, when the head is 337657a3c24c92befb3ed11d6f15402faa09f7dd.

[1] https://lore.kernel.org/oe-kbuild-all/202411141621.uwFAKZb2-lkp@intel.com/

> 
> How can I reproduce this build?  Do you have a packaged clang-19
> toolchain?

The clang package can be found at https://cdn.kernel.org/pub/tools/llvm/files.

> 
> The x86_64 allyesconfig build succeeded for the robot, but when I
> build on x86_64 with gcc-11.4.0, I get an error:
> 
>   $ gcc -v
>   gcc version 11.4.0 (Ubuntu 11.4.0-1ubuntu1~22.04)
>   $ git checkout 592aac418ebd
>   $ make allyesconfig
>   $ make drivers/pci/controller/pcie-rockchip-ep.o
>     CC      drivers/pci/controller/pcie-rockchip-ep.o
>   drivers/pci/controller/pcie-rockchip-ep.c:640:9: error: implicit declaration of function ‘irq_set_irq_type’
> 
> irq_set_irq_type() is declared in <linux/irq.h>.  On arm64, where this
> driver is used, <linux/irq.h> is included via this path:
> 
>   linux/pci.h
>     linux/interrupt.h
>       linux/hardirq.h
> 	arch/arm64/include/asm/hardirq.h
> 	  asm-generic/hardirq.h
> 	    linux/irq.h
> 
> but on x86, arch/x86/include/asm/hardirq.h does not include
> asm-generic/hardirq.h and therefore doesn't include <linux/irq.h>.
> 
> I'm confused about why the robot reported a successful build with
> clang-19.  It seems like that should have the same problem I saw with
> gcc, so I'd like to try it manually.
> 
> Bjorn
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [pci:controller/rockchip] BUILD SUCCESS 592aac418ebdf451fe9b146bc2ca6dfc96921af0
  2024-11-21  4:37   ` Philip Li
@ 2024-11-21  7:59     ` Philip Li
  0 siblings, 0 replies; 6+ messages in thread
From: Philip Li @ 2024-11-21  7:59 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: kernel test robot, linux-pci, Krzysztof Wilczyński,
	Damien Le Moal

On Thu, Nov 21, 2024 at 12:37:41PM +0800, Philip Li wrote:
> On Tue, Nov 19, 2024 at 09:19:25AM -0600, Bjorn Helgaas wrote:
> > On Mon, Nov 18, 2024 at 12:01:12AM +0800, kernel test robot wrote:
> > > tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git controller/rockchip
> > > branch HEAD: 592aac418ebdf451fe9b146bc2ca6dfc96921af0  PCI: rockchip-ep: Handle PERST# signal in endpoint mode
> > 
> > > x86_64                           allyesconfig    clang-19
> 
> Let me double check this why it is success.

Sorry about the confusing PASS info here, i have confirmed the error is
there for head 592aac41.

Below is the explanation

Early on around "Date: Thu, 14 Nov 2024 17:57:46 +0800", the bot sends
out mail "[pci:controller/rockchip] BUILD REGRESSION 337657a3c24c92befb3ed11d6f15402faa09f7dd"
with 2 bisected reports

    https://lore.kernel.org/oe-kbuild-all/202411141106.4hI5VqIa-lkp@intel.com
    https://lore.kernel.org/oe-kbuild-all/202411141621.uwFAKZb2-lkp@intel.com

Later for the new series with head 592aac41, it considers the bug is already
there (reported before), thus is not newly introduced by 592aac41. So it marks
build success.

This tries to mean that the success is no new issues are introduced, though there's
build failure when building the head.

For example, when a branch is based on another branch, that base branch could contain
build failure, but the newly added commits doesn't add new failures/warnings. Under
this situation, the bot sends out "BUILD SUCCESS" mail.

Hope this is helpful, and let me think of whether we can expose more info for situation
like this to avoid confusion.

Thanks

> 
> Actually, the bot report "implicit declaration of function 'irq_set_status_flags'" at [1]
> with sparc64-linux-gcc and sparc-allmodconfig, when the head is 337657a3c24c92befb3ed11d6f15402faa09f7dd.
> 
> [1] https://lore.kernel.org/oe-kbuild-all/202411141621.uwFAKZb2-lkp@intel.com/
> 
> > 
> > How can I reproduce this build?  Do you have a packaged clang-19
> > toolchain?
> 
> The clang package can be found at https://cdn.kernel.org/pub/tools/llvm/files.
> 
> > 
> > The x86_64 allyesconfig build succeeded for the robot, but when I
> > build on x86_64 with gcc-11.4.0, I get an error:
> > 
> >   $ gcc -v
> >   gcc version 11.4.0 (Ubuntu 11.4.0-1ubuntu1~22.04)
> >   $ git checkout 592aac418ebd
> >   $ make allyesconfig
> >   $ make drivers/pci/controller/pcie-rockchip-ep.o
> >     CC      drivers/pci/controller/pcie-rockchip-ep.o
> >   drivers/pci/controller/pcie-rockchip-ep.c:640:9: error: implicit declaration of function ‘irq_set_irq_type’
> > 
> > irq_set_irq_type() is declared in <linux/irq.h>.  On arm64, where this
> > driver is used, <linux/irq.h> is included via this path:
> > 
> >   linux/pci.h
> >     linux/interrupt.h
> >       linux/hardirq.h
> > 	arch/arm64/include/asm/hardirq.h
> > 	  asm-generic/hardirq.h
> > 	    linux/irq.h
> > 
> > but on x86, arch/x86/include/asm/hardirq.h does not include
> > asm-generic/hardirq.h and therefore doesn't include <linux/irq.h>.
> > 
> > I'm confused about why the robot reported a successful build with
> > clang-19.  It seems like that should have the same problem I saw with
> > gcc, so I'd like to try it manually.
> > 
> > Bjorn
> > 

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2024-11-21  7:59 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-17 16:01 [pci:controller/rockchip] BUILD SUCCESS 592aac418ebdf451fe9b146bc2ca6dfc96921af0 kernel test robot
2024-11-19 15:19 ` Bjorn Helgaas
2024-11-19 18:02   ` Krzysztof Wilczyński
2024-11-21  3:00   ` Damien Le Moal
2024-11-21  4:37   ` Philip Li
2024-11-21  7:59     ` Philip Li

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox