[pci:controller/dwc 6/8] drivers/pci/controller/dwc/pcie-designware-debugfs.c:561:undefined reference to `dw_ltssm_sts_string'

[pci:controller/dwc 6/8] drivers/pci/controller/dwc/pcie-designware-debugfs.c:561:undefined reference to `dw_ltssm_sts_string'

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git controller/dwc
head:   b9d6619b0c3ef6ac25764ff29b08e8c1953ea83f
commit: d4dc748566221bfdd0345c282ec82d3eee457f39 [6/8] PCI: dwc: Add debugfs property to provide LTSSM status of the PCIe link
config: sparc64-randconfig-001-20250227 (https://download.01.org/0day-ci/archive/20250227/202502270336.4xpaTVPE-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250227/202502270336.4xpaTVPE-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502270336.4xpaTVPE-lkp@intel.com/

All errors (new ones prefixed by >>):

   sparc64-linux-ld: drivers/pci/controller/dwc/pcie-designware-debugfs.o: in function `dwc_pcie_ltssm_status_show':
>> drivers/pci/controller/dwc/pcie-designware-debugfs.c:561:(.text+0x125c): undefined reference to `dw_ltssm_sts_string'
>> sparc64-linux-ld: drivers/pci/controller/dwc/pcie-designware-debugfs.c:561:(.text+0x12c4): undefined reference to `dw_ltssm_sts_string'


vim +561 drivers/pci/controller/dwc/pcie-designware-debugfs.c

   554	
   555	static int dwc_pcie_ltssm_status_show(struct seq_file *s, void *v)
   556	{
   557		struct dw_pcie *pci = s->private;
   558		enum dw_pcie_ltssm val;
   559	
   560		val = dw_pcie_get_ltssm(pci);
 > 561		seq_printf(s, "%s (0x%02x)\n", dw_ltssm_sts_string(val), val);
   562	
   563		return 0;
   564	}
   565	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [pci:controller/dwc 6/8] drivers/pci/controller/dwc/pcie-designware-debugfs.c:561:undefined reference to `dw_ltssm_sts_string'

[Hans Zhang]

On 2025/2/27 04:09, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git controller/dwc
> head:   b9d6619b0c3ef6ac25764ff29b08e8c1953ea83f
> commit: d4dc748566221bfdd0345c282ec82d3eee457f39 [6/8] PCI: dwc: Add debugfs property to provide LTSSM status of the PCIe link
> config: sparc64-randconfig-001-20250227 (https://download.01.org/0day-ci/archive/20250227/202502270336.4xpaTVPE-lkp@intel.com/config)

Hi Krzysztof,

sparc64-randconfig-001-20250227:

#
# DesignWare-based PCIe controllers
#
CONFIG_PCIE_DW=y
CONFIG_PCIE_DW_DEBUGFS=y
CONFIG_PCIE_DW_EP=y


Since this config is not configured with CONFIG_PCIE_DW_HOST, and the 
dw_ltssm_sts_string function is in the pci-designware-host.c, the 
following compilation error occurs.

Can you help move the dw_ltssm_sts_string function to pci-designware.c 
or pci-designware-debugfs.c?

Or should I resubmit v6 patch?

Best regards
Hans


> compiler: sparc64-linux-gcc (GCC) 14.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250227/202502270336.4xpaTVPE-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202502270336.4xpaTVPE-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>     sparc64-linux-ld: drivers/pci/controller/dwc/pcie-designware-debugfs.o: in function `dwc_pcie_ltssm_status_show':
>>> drivers/pci/controller/dwc/pcie-designware-debugfs.c:561:(.text+0x125c): undefined reference to `dw_ltssm_sts_string'
>>> sparc64-linux-ld: drivers/pci/controller/dwc/pcie-designware-debugfs.c:561:(.text+0x12c4): undefined reference to `dw_ltssm_sts_string'
> 
> 
> vim +561 drivers/pci/controller/dwc/pcie-designware-debugfs.c
> 
>     554	
>     555	static int dwc_pcie_ltssm_status_show(struct seq_file *s, void *v)
>     556	{
>     557		struct dw_pcie *pci = s->private;
>     558		enum dw_pcie_ltssm val;
>     559	
>     560		val = dw_pcie_get_ltssm(pci);
>   > 561		seq_printf(s, "%s (0x%02x)\n", dw_ltssm_sts_string(val), val);
>     562	
>     563		return 0;
>     564	}
>     565	
> 

Re: [pci:controller/dwc 6/8] drivers/pci/controller/dwc/pcie-designware-debugfs.c:561:undefined reference to `dw_ltssm_sts_string'

[Krzysztof Wilczyński]

Hello,

> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git controller/dwc
> > head:   b9d6619b0c3ef6ac25764ff29b08e8c1953ea83f
> > commit: d4dc748566221bfdd0345c282ec82d3eee457f39 [6/8] PCI: dwc: Add debugfs property to provide LTSSM status of the PCIe link
> > config: sparc64-randconfig-001-20250227 (https://download.01.org/0day-ci/archive/20250227/202502270336.4xpaTVPE-lkp@intel.com/config)
[...]
> sparc64-randconfig-001-20250227:
> 
> #
> # DesignWare-based PCIe controllers
> #
> CONFIG_PCIE_DW=y
> CONFIG_PCIE_DW_DEBUGFS=y
> CONFIG_PCIE_DW_EP=y
> 
> 
> Since this config is not configured with CONFIG_PCIE_DW_HOST, and the
> dw_ltssm_sts_string function is in the pci-designware-host.c, the following
> compilation error occurs.

No worries.  Thank you for having a look!

> Can you help move the dw_ltssm_sts_string function to pci-designware.c or
> pci-designware-debugfs.c?

Have a look at the following:

  https://web.git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?h=controller/dwc&id=02001ce4ff42bd85be3ed8b4a0a2580156f032a0

And let me know if this is OK with you.
 
> Or should I resubmit v6 patch?

No, need.  Thank you anyway, though.

	Krzysztof

Re: [pci:controller/dwc 6/8] drivers/pci/controller/dwc/pcie-designware-debugfs.c:561:undefined reference to `dw_ltssm_sts_string'

[Hans Zhang]

On 2025/2/27 18:43, Krzysztof Wilczyński wrote:
> Hello,
> 
>>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git controller/dwc
>>> head:   b9d6619b0c3ef6ac25764ff29b08e8c1953ea83f
>>> commit: d4dc748566221bfdd0345c282ec82d3eee457f39 [6/8] PCI: dwc: Add debugfs property to provide LTSSM status of the PCIe link
>>> config: sparc64-randconfig-001-20250227 (https://download.01.org/0day-ci/archive/20250227/202502270336.4xpaTVPE-lkp@intel.com/config)
> [...]
>> sparc64-randconfig-001-20250227:
>>
>> #
>> # DesignWare-based PCIe controllers
>> #
>> CONFIG_PCIE_DW=y
>> CONFIG_PCIE_DW_DEBUGFS=y
>> CONFIG_PCIE_DW_EP=y
>>
>>
>> Since this config is not configured with CONFIG_PCIE_DW_HOST, and the
>> dw_ltssm_sts_string function is in the pci-designware-host.c, the following
>> compilation error occurs.
> 
> No worries.  Thank you for having a look!
> 
>> Can you help move the dw_ltssm_sts_string function to pci-designware.c or
>> pci-designware-debugfs.c?
> 
> Have a look at the following:
> 
>    https://web.git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?h=controller/dwc&id=02001ce4ff42bd85be3ed8b4a0a2580156f032a0
> 
> And let me know if this is OK with you.

I couldn't agree more. Thank you very much Krzysztof.

Best regards
Hans

>   
>> Or should I resubmit v6 patch?
> 
> No, need.  Thank you anyway, though.
> 
> 	Krzysztof