[PATCH] PCI: hotplug: Drop superfluous #include directives

[PATCH] PCI: hotplug: Drop superfluous #include directives

[Lukas Wunner]

In February 2003, historic commit

  https://git.kernel.org/tglx/history/c/280c1c9a0ea4
  ("[PATCH] PCI Hotplug: Replace pcihpfs with sysfs.")

removed all invocations of __get_free_page() and free_page() from the
PCI hotplug core without also removing the #include <linux/pagemap.h>
directive.

It removed all invocations of kern_mount(), mntget() and mntput()
without also removing the #include <linux/mount.h> directive.

It removed all invocations of lookup_hash()
without also removing the #include <linux/namei.h> directive.

It removed all invocations of copy_to_user() and copy_from_user()
without also removing the #include <linux/uaccess.h> directive.

These #include directives are still unnecessary today, so drop them.

Signed-off-by: Lukas Wunner <lukas@wunner.de>
---
 drivers/pci/hotplug/pci_hotplug_core.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/pci/hotplug/pci_hotplug_core.c b/drivers/pci/hotplug/pci_hotplug_core.c
index d8c5856..210f93d 100644
--- a/drivers/pci/hotplug/pci_hotplug_core.c
+++ b/drivers/pci/hotplug/pci_hotplug_core.c
@@ -20,13 +20,9 @@
 #include <linux/types.h>
 #include <linux/kobject.h>
 #include <linux/sysfs.h>
-#include <linux/pagemap.h>
 #include <linux/init.h>
-#include <linux/mount.h>
-#include <linux/namei.h>
 #include <linux/pci.h>
 #include <linux/pci_hotplug.h>
-#include <linux/uaccess.h>
 #include "../pci.h"
 #include "cpci_hotplug.h"
 
-- 
2.43.0

Re: [PATCH] PCI: hotplug: Drop superfluous #include directives

[Bjorn Helgaas]

On Mon, Apr 14, 2025 at 04:25:21PM +0200, Lukas Wunner wrote:
> In February 2003, historic commit
> 
>   https://git.kernel.org/tglx/history/c/280c1c9a0ea4
>   ("[PATCH] PCI Hotplug: Replace pcihpfs with sysfs.")
> 
> removed all invocations of __get_free_page() and free_page() from the
> PCI hotplug core without also removing the #include <linux/pagemap.h>
> directive.
> 
> It removed all invocations of kern_mount(), mntget() and mntput()
> without also removing the #include <linux/mount.h> directive.
> 
> It removed all invocations of lookup_hash()
> without also removing the #include <linux/namei.h> directive.
> 
> It removed all invocations of copy_to_user() and copy_from_user()
> without also removing the #include <linux/uaccess.h> directive.
> 
> These #include directives are still unnecessary today, so drop them.
> 
> Signed-off-by: Lukas Wunner <lukas@wunner.de>

Applied to pci/hotplug for v6.16, thanks!

> ---
>  drivers/pci/hotplug/pci_hotplug_core.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/pci/hotplug/pci_hotplug_core.c b/drivers/pci/hotplug/pci_hotplug_core.c
> index d8c5856..210f93d 100644
> --- a/drivers/pci/hotplug/pci_hotplug_core.c
> +++ b/drivers/pci/hotplug/pci_hotplug_core.c
> @@ -20,13 +20,9 @@
>  #include <linux/types.h>
>  #include <linux/kobject.h>
>  #include <linux/sysfs.h>
> -#include <linux/pagemap.h>
>  #include <linux/init.h>
> -#include <linux/mount.h>
> -#include <linux/namei.h>
>  #include <linux/pci.h>
>  #include <linux/pci_hotplug.h>
> -#include <linux/uaccess.h>
>  #include "../pci.h"
>  #include "cpci_hotplug.h"
>  
> -- 
> 2.43.0
> 

Re: [PATCH] PCI: hotplug: Drop superfluous #include directives

[Lukas Wunner]

On Tue, Apr 15, 2025 at 03:33:54PM -0500, Bjorn Helgaas wrote:
> On Mon, Apr 14, 2025 at 04:25:21PM +0200, Lukas Wunner wrote:
> > In February 2003, historic commit
> > 
> >   https://git.kernel.org/tglx/history/c/280c1c9a0ea4
> >   ("[PATCH] PCI Hotplug: Replace pcihpfs with sysfs.")
> > 
> > removed all invocations of __get_free_page() and free_page() from the
> > PCI hotplug core without also removing the #include <linux/pagemap.h>
> > directive.
> > 
> > It removed all invocations of kern_mount(), mntget() and mntput()
> > without also removing the #include <linux/mount.h> directive.
> > 
> > It removed all invocations of lookup_hash()
> > without also removing the #include <linux/namei.h> directive.
> > 
> > It removed all invocations of copy_to_user() and copy_from_user()
> > without also removing the #include <linux/uaccess.h> directive.
> > 
> > These #include directives are still unnecessary today, so drop them.
> > 
> > Signed-off-by: Lukas Wunner <lukas@wunner.de>
> 
> Applied to pci/hotplug for v6.16, thanks!

A small issue snuck into the commit message while applying:

There's a sentence which ends abruptly:

    It removed all invocations of lookup_hash() without also removing the

The remainder of the sentence should have been:

    #include <linux/namei.h> directive.

While rewrapping the paragraph, the word "#ifdef" ended up at the
beginning of the line and "git commit" interpreted that as a comment
and stripped the line from the commit message.

I think just prepending a blank to the line may stop git from doing that.

Thanks,

Lukas

Re: [PATCH] PCI: hotplug: Drop superfluous #include directives

[Bjorn Helgaas]

On Thu, Apr 17, 2025 at 09:30:40PM +0200, Lukas Wunner wrote:
> On Tue, Apr 15, 2025 at 03:33:54PM -0500, Bjorn Helgaas wrote:
> > On Mon, Apr 14, 2025 at 04:25:21PM +0200, Lukas Wunner wrote:
> > > In February 2003, historic commit
> > > 
> > >   https://git.kernel.org/tglx/history/c/280c1c9a0ea4
> > >   ("[PATCH] PCI Hotplug: Replace pcihpfs with sysfs.")
> > > 
> > > removed all invocations of __get_free_page() and free_page() from the
> > > PCI hotplug core without also removing the #include <linux/pagemap.h>
> > > directive.
> > > 
> > > It removed all invocations of kern_mount(), mntget() and mntput()
> > > without also removing the #include <linux/mount.h> directive.
> > > 
> > > It removed all invocations of lookup_hash()
> > > without also removing the #include <linux/namei.h> directive.
> > > 
> > > It removed all invocations of copy_to_user() and copy_from_user()
> > > without also removing the #include <linux/uaccess.h> directive.
> > > 
> > > These #include directives are still unnecessary today, so drop them.
> > > 
> > > Signed-off-by: Lukas Wunner <lukas@wunner.de>
> > 
> > Applied to pci/hotplug for v6.16, thanks!
> 
> A small issue snuck into the commit message while applying:
> 
> There's a sentence which ends abruptly:
> 
>     It removed all invocations of lookup_hash() without also removing the
> 
> The remainder of the sentence should have been:
> 
>     #include <linux/namei.h> directive.
> 
> While rewrapping the paragraph, the word "#ifdef" ended up at the
> beginning of the line and "git commit" interpreted that as a comment
> and stripped the line from the commit message.

Wow, thanks for noticing that.  That's new to me.  I this I restored
it.