Re: 回复: [pci:slot-reset 1/1] drivers/pci/controller/dwc/pcie-dw-rockchip.c:721:58: error: use of undeclared identifier 'PCIE_CLIENT_GENERAL_CON'

["Krzysztof Wilczy��ski" <kwilczynski@kernel.org>]

Hello,

[...]
> Comparing the commit that landed on the branch, with Wilfred's patch on the
> mailing list, I did notice this diff:

[...]
> Reviewing the diff, the changes looks fine to me, but I strongly think
> that if the actual code is modified from the submission (rather than
> just fixing some minor grammar in the commit message), the (unwritten?)
> rule is that the person should add a:
> 
> [person: describe modifications from the original submission]

Sorry about that.  I did forgot to add this.  Good catch.

That said, a single single line with a nudge or a reminder would suffice.

There is no need for a condescending tone and the lecturing and such.

You have been doing this for a while now, and if you continue doing this,
I will have no choice but to start to ignore submissions from you, I do not
have the time to deal with any forms of such passive-aggressive attitude.

Thank you!

	Krzysztof