Re: 回复: [pci:slot-reset 1/1] drivers/pci/controller/dwc/pcie-dw-rockchip.c:721:58: error: use of undeclared identifier 'PCIE_CLIENT_GENERAL_CON'

[Niklas Cassel <cassel@kernel.org>]

Hello Krzysztof,

On Fri, May 16, 2025 at 07:36:33PM +0900, Krzysztof Wilczy��ski wrote:
> Hello,
> 
> [...]
> > Comparing the commit that landed on the branch, with Wilfred's patch on the
> > mailing list, I did notice this diff:
> 
> [...]
> > Reviewing the diff, the changes looks fine to me, but I strongly think
> > that if the actual code is modified from the submission (rather than
> > just fixing some minor grammar in the commit message), the (unwritten?)
> > rule is that the person should add a:
> > 
> > [person: describe modifications from the original submission]
> 
> Sorry about that.  I did forgot to add this.  Good catch.
> 
> That said, a single single line with a nudge or a reminder would suffice.
> 
> There is no need for a condescending tone and the lecturing and such.

I've been reading my reply multiple times, and I honestly don't understand
where this is coming from.

I was simply saying that, if the actual code is changed when applying,
then I think that it is important to either:
1) Write something in the thread (e.g. in the 'Applied' message), or
2) Add a [user: ] line after the SoB

When it comes to simply modifying the commit log, then, my personal
opinion is that 1) and/or 2) is of magnitudes less importance.

I wasn't trying to lecture, I was simply trying to explain the logic of
my opinion.


> 
> You have been doing this for a while now, and if you continue doing this,
> I will have no choice but to start to ignore submissions from you, I do not
> have the time to deal with any forms of such passive-aggressive attitude.

This is surprising to me, our only other discussion recently was about
RESEND tags, were I also stated my personal opinion.

But that was also a sensible discussion IMO.

Not being allowed to pick up tags, e.g. Reviewed-by and Tested-by, when
doing a RESEND (as long as code and commit log is unchanged) seems
counterproductive to me, as the time spent by the Tester/Reviewer would
have been for nought.


Kind regards,
Niklas