From: Bjorn Helgaas <helgaas@kernel.org>
To: Inochi Amaoto <inochiama@gmail.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Marc Zyngier <maz@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Shradha Gupta <shradhagupta@linux.microsoft.com>,
Nathan Chancellor <nathan@kernel.org>,
Anders Roxell <anders.roxell@linaro.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Longbin Li <looong.bin@gmail.com>,
Linux Kernel Functional Testing <lkft@linaro.org>
Subject: Re: [PATCH] PCI/MSI: Check MSI_FLAG_PCI_MSI_MASK_PARENT in cond_[startup|shutdown]_parent()
Date: Wed, 27 Aug 2025 17:58:18 -0500 [thread overview]
Message-ID: <20250827225818.GA916741@bhelgaas> (raw)
In-Reply-To: <zlhxt6zqvweklyknmmrlheg3ojy4lildosfjoginliggdtdf5x@zent5qnnawvb>
On Thu, Aug 28, 2025 at 06:52:39AM +0800, Inochi Amaoto wrote:
> On Wed, Aug 27, 2025 at 01:32:02PM -0500, Bjorn Helgaas wrote:
> > On Wed, Aug 27, 2025 at 02:29:07PM +0800, Inochi Amaoto wrote:
> > > For msi controller that only supports MSI_FLAG_PCI_MSI_MASK_PARENT,
> > > the newly added callback irq_startup() and irq_shutdown() for
> > > pci_msi[x]_templete will not unmask/mask the interrupt when startup/
> > > shutdown the interrupt. This will prevent the interrupt from being
> > > enabled/disabled normally.
> >
> > s/templete/template/
>
> > AFAICS cond_startup_parent() is used by pci_irq_startup_msi() and
> > pci_irq_startup_msix() in pci_msi_template; cond_shutdown_parent() is
> > used by pci_irq_shutdown_msi() and pci_irq_shutdown_msix() in
> > pci_msix_template.
>
> cond_startup_parent() is used by pci_irq_startup_msi() in
> pci_msi_template and pci_irq_startup_msix() in pci_msix_template;
> cond_shutdown_parent() is used by pci_irq_shutdown_msi() in
> pci_msi_template and pci_irq_shutdown_msix() in pci_msix_template.
Right, I really screwed that up when I noticed the "*_template"
structure names and added them to my description.
next prev parent reply other threads:[~2025-08-27 22:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-27 6:29 [PATCH] PCI/MSI: Check MSI_FLAG_PCI_MSI_MASK_PARENT in cond_[startup|shutdown]_parent() Inochi Amaoto
2025-08-27 10:04 ` Jon Hunter
2025-08-27 18:32 ` Bjorn Helgaas
2025-08-27 22:52 ` Inochi Amaoto
2025-08-27 22:58 ` Bjorn Helgaas [this message]
2025-08-29 7:41 ` Naresh Kamboju
2025-09-01 12:35 ` Mark Brown
2025-09-01 15:24 ` Bjorn Helgaas
2025-09-01 15:26 ` Bjorn Helgaas
-- strict thread matches above, loose matches on Subject: below --
2025-08-27 23:03 Inochi Amaoto
2025-08-27 23:07 ` Inochi Amaoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250827225818.GA916741@bhelgaas \
--to=helgaas@kernel.org \
--cc=anders.roxell@linaro.org \
--cc=bhelgaas@google.com \
--cc=inochiama@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lkft@linaro.org \
--cc=looong.bin@gmail.com \
--cc=lpieralisi@kernel.org \
--cc=maz@kernel.org \
--cc=nathan@kernel.org \
--cc=shradhagupta@linux.microsoft.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox