Re: [PATCH] PCI/MSI: Check MSI_FLAG_PCI_MSI_MASK_PARENT in cond_[startup|shutdown]_parent()

[Bjorn Helgaas <helgaas@kernel.org>]

[cc->to: Thomas]

On Mon, Sep 01, 2025 at 01:35:17PM +0100, Mark Brown wrote:
> On Wed, Aug 27, 2025 at 02:29:07PM +0800, Inochi Amaoto wrote:
> > For msi controller that only supports MSI_FLAG_PCI_MSI_MASK_PARENT,
> > the newly added callback irq_startup() and irq_shutdown() for
> > pci_msi[x]_templete will not unmask/mask the interrupt when startup/
> > shutdown the interrupt. This will prevent the interrupt from being
> > enabled/disabled normally.
> > 
> > Add the missing check for MSI_FLAG_PCI_MSI_MASK_PARENT in the
> > cond_[startup|shutdown]_parent(). So the interrupt can be normally
> > unmasked/masked if it does not support MSI_FLAG_PCI_MSI_MASK_PARENT.
> 
> Tested-by: Mark Brown <broonie@kernel.org>
> 
> This is causing multiple platforms to fail to boot in -next, it'd be
> great if we could get it merged to fix them.

It looks like you merged 54f45a30c0d0 ("PCI/MSI: Add startup/shutdown
for per device domains"), Thomas.  I assume you'll merge this fix too?

Let me know if you'd prefer that I take it.  Looks like a candidate
for v6.17.

Bjorn