From: Bjorn Helgaas <helgaas@kernel.org>
To: Mark Brown <broonie@kernel.org>, Thomas Gleixner <tglx@linutronix.de>
Cc: Inochi Amaoto <inochiama@gmail.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Marc Zyngier <maz@kernel.org>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Shradha Gupta <shradhagupta@linux.microsoft.com>,
Nathan Chancellor <nathan@kernel.org>,
Anders Roxell <anders.roxell@linaro.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Longbin Li <looong.bin@gmail.com>,
Linux Kernel Functional Testing <lkft@linaro.org>
Subject: Re: [PATCH] PCI/MSI: Check MSI_FLAG_PCI_MSI_MASK_PARENT in cond_[startup|shutdown]_parent()
Date: Mon, 1 Sep 2025 10:26:09 -0500 [thread overview]
Message-ID: <20250901152609.GA1114913@bhelgaas> (raw)
In-Reply-To: <20250901152452.GA1114741@bhelgaas>
On Mon, Sep 01, 2025 at 10:24:54AM -0500, Bjorn Helgaas wrote:
> [cc->to: Thomas]
>
> On Mon, Sep 01, 2025 at 01:35:17PM +0100, Mark Brown wrote:
> > On Wed, Aug 27, 2025 at 02:29:07PM +0800, Inochi Amaoto wrote:
> > > For msi controller that only supports MSI_FLAG_PCI_MSI_MASK_PARENT,
> > > the newly added callback irq_startup() and irq_shutdown() for
> > > pci_msi[x]_templete will not unmask/mask the interrupt when startup/
> > > shutdown the interrupt. This will prevent the interrupt from being
> > > enabled/disabled normally.
> > >
> > > Add the missing check for MSI_FLAG_PCI_MSI_MASK_PARENT in the
> > > cond_[startup|shutdown]_parent(). So the interrupt can be normally
> > > unmasked/masked if it does not support MSI_FLAG_PCI_MSI_MASK_PARENT.
> >
> > Tested-by: Mark Brown <broonie@kernel.org>
> >
> > This is causing multiple platforms to fail to boot in -next, it'd be
> > great if we could get it merged to fix them.
>
> It looks like you merged 54f45a30c0d0 ("PCI/MSI: Add startup/shutdown
> for per device domains"), Thomas. I assume you'll merge this fix too?
>
> Let me know if you'd prefer that I take it. Looks like a candidate
> for v6.17.
Oops, looks like there's a v2:
https://lore.kernel.org/r/20250827230943.17829-1-inochiama@gmail.com
next prev parent reply other threads:[~2025-09-01 15:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-27 6:29 [PATCH] PCI/MSI: Check MSI_FLAG_PCI_MSI_MASK_PARENT in cond_[startup|shutdown]_parent() Inochi Amaoto
2025-08-27 10:04 ` Jon Hunter
2025-08-27 18:32 ` Bjorn Helgaas
2025-08-27 22:52 ` Inochi Amaoto
2025-08-27 22:58 ` Bjorn Helgaas
2025-08-29 7:41 ` Naresh Kamboju
2025-09-01 12:35 ` Mark Brown
2025-09-01 15:24 ` Bjorn Helgaas
2025-09-01 15:26 ` Bjorn Helgaas [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-08-27 23:03 Inochi Amaoto
2025-08-27 23:07 ` Inochi Amaoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250901152609.GA1114913@bhelgaas \
--to=helgaas@kernel.org \
--cc=anders.roxell@linaro.org \
--cc=bhelgaas@google.com \
--cc=broonie@kernel.org \
--cc=inochiama@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lkft@linaro.org \
--cc=looong.bin@gmail.com \
--cc=lpieralisi@kernel.org \
--cc=maz@kernel.org \
--cc=nathan@kernel.org \
--cc=shradhagupta@linux.microsoft.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox