Re: [PATCH v2 1/2] PCI: dw-rockchip: Add L1sub support

[Bjorn Helgaas <helgaas@kernel.org>]

On Wed, Oct 22, 2025 at 08:22:39PM +0800, Shawn Lin wrote:
> 在 2025/10/22 星期三 19:52, Hans Zhang 写道:
> > On 10/22/2025 7:35 PM, Shawn Lin wrote:
> > > The driver should set app_clk_req_n(clkreq ready) of
> > > PCIE_CLIENT_POWER reg
> > > to support L1sub. Otherwise, unset app_clk_req_n and pull down CLKREQ#.

> > > @@ -412,6 +446,8 @@ static int rockchip_pcie_resource_get(struct
> > > platform_device *pdev,
> > >                  return dev_err_probe(&pdev->dev, PTR_ERR(rockchip->rst),
> > >                                       "failed to get reset lines\n");
> > > 
> > > +       rockchip->supports_clkreq = of_property_read_bool(pdev-
> > > >dev.of_node, "supports-clkreq");
> > 
> > This line exceeds 80 characters. Can it be like this?
> 
> Thanks for the reivew.
> 
> I think we've been drop this rule[1] for quite a long time :)
> 
> [1]https://www.phoronix.com/news/Linux-Kernel-Deprecates-80-Col
> 
> > rockchip->supports_clkreq = of_property_read_bool(pdev->dev.of_node,
> >                            "supports-clkreq");

Yes, but that doesn't mean it's OK for the file to be a mishmash where
most of it fits in 80 but random lines go to 100.  That just makes it
a pain to read.

If going past 80 makes something significantly easier to read, that's
fine, and this file does that occasionally for #defines and the like.
But in this case, wrapping to fit in 80 really doesn't hurt anything.

Bjorn