Re: [PATCH v2 2/2] arm64: dts: rockchip: Add PCIe clkreq stuff for RK3588 EVB1

[Hans Zhang <hans.zhang@cixtech.com>]

On 10/22/2025 7:35 PM, Shawn Lin wrote:
> EXTERNAL EMAIL
> 
> Add supports-clkreq and pinmux for PCIe ASPM L1 substates.
> 
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>

Reviewed-by: Hans Zhang <hans.zhang@cixtech.com>

Best regards,
Hans

> ---
> 
> Changes in v2: None
> 
>   arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
> index ff1ba5e..c9d284c 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
> @@ -522,6 +522,7 @@
>          pinctrl-names = "default";
>          pinctrl-0 = <&pcie2_0_rst>, <&pcie2_0_wake>, <&pcie2_0_clkreq>, <&wifi_host_wake_irq>;
>          reset-gpios = <&gpio4 RK_PA5 GPIO_ACTIVE_HIGH>;
> +       supports-clkreq;
>          vpcie3v3-supply = <&vcc3v3_wlan>;
>          status = "okay";
> 
> @@ -545,7 +546,8 @@
>   &pcie2x1l1 {
>          reset-gpios = <&gpio4 RK_PA2 GPIO_ACTIVE_HIGH>;
>          pinctrl-names = "default";
> -       pinctrl-0 = <&pcie2_1_rst>, <&rtl8111_isolate>;
> +       pinctrl-0 = <&pcie2_1_rst>, <&rtl8111_isolate>, <&pcie30x1m1_1_clkreqn>;
> +       supports-clkreq;
>          status = "okay";
>   };
> 
> @@ -555,7 +557,8 @@
> 
>   &pcie3x4 {
>          pinctrl-names = "default";
> -       pinctrl-0 = <&pcie3_reset>;
> +       pinctrl-0 = <&pcie3_reset>, <&pcie30x4m1_clkreqn>;
> +       supports-clkreq;
>          reset-gpios = <&gpio4 RK_PB6 GPIO_ACTIVE_HIGH>;
>          vpcie3v3-supply = <&vcc3v3_pcie30>;
>          status = "okay";
> --
> 2.7.4
> 
>