Re: [PATCH V4 2/7] arm: dts: imx6sx-sdb: Move power supply property to Root Port node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] Removing `vpcie-supply` from the host controller node breaks DT backward compatibility, as older kernels will fail to enable the regulator and initialize PCIe.
- [Low] Adding `vpcie3v3-supply` to the Root Port node without updating the corresponding binding schema causes `dtbs_check` validation failures.
--

commit 9019771c92c02473e9f2657166c7dc76a65b606d
Author: Sherry Sun <sherry.sun@nxp.com>

arm: dts: imx6sx-sdb: Move power supply property to Root Port node

Move the power supply property from the PCIe controller node to the Root
Port child node to support the new PCI pwrctrl framework.

> diff --git a/arch/arm/boot/dts/nxp/imx/imx6sx-sdb.dtsi b/arch/arm/boot/dts/nxp/imx/imx6sx-sdb.dtsi
> index 338de4d144b2a..41a69fe83be85 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6sx-sdb.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/imx6sx-sdb.dtsi
> @@ -284,12 +284,12 @@ &pcie {
>  	pinctrl-0 = <&pinctrl_pcie>;
>  	/* This property is deprecated, use reset-gpios from the Root Port node. */
>  	reset-gpio = <&gpio2 0 GPIO_ACTIVE_LOW>;
> -	vpcie-supply = <&reg_pcie_gpio>;

[Severity: High]
Does removing this property break device tree backward compatibility for
older kernels?

Older kernels using the pci-imx6.c driver expect the vpcie-supply property
in the host controller node to find and enable the regulator. If this is
removed instead of being left as a deprecated fallback (similar to the
reset-gpio property above), will PCIe initialization fail on older kernels
booted with this new device tree?

>  	status = "okay";
>  };
>  
>  &pcie_port0 {
>  	reset-gpios = <&gpio2 0 GPIO_ACTIVE_LOW>;
> +	vpcie3v3-supply = <&reg_pcie_gpio>;

[Severity: Low]
Does adding this property to the Root Port node without a corresponding
schema update cause dtbs_check validation failures?

The fsl,imx6q-pcie.yaml binding schema defines the root port node with
unevaluatedProperties: false, but it does not appear to document the newly
added vpcie3v3-supply property.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260630060710.3294811-1-sherry.sun@oss.nxp.com?part=2