From: sashiko-bot@kernel.org
To: "Lin Wang" <wanglin@open-hieco.net>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH v4 2/5] x86/hygon: Add Family 0x18 DF node enumeration
Date: Tue, 01 Sep 2026 07:29:17 +0000 [thread overview]
Message-ID: <20260901072918.6C2A11F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260901071700.3255382-3-wanglin@open-hieco.net>
> The AMD node code locates function 3 for node N at PCI slot 0x18 + N.
> Hygon has no equivalent node-index-to-slot mapping: DF F3 devices are
> discovered by PCI ID and the PCI BDF is only an access point.
>
> F1x200 provides the socket ID, SocketPresent mask and, on Models 0x04
> and 0x05, the DFID. Models 0x06 through 0x08 provide the DFID in
> F5x180. The resulting (socket ID, DFID) pair identifies a DF node, while
> SocketPresent verifies that enumeration covers every populated socket.
>
> Order CDDs by socket and DFID, followed by IODs, and assign dense node
> indices. Expose node counts, identity, F3/F4 lookup and PCI-device
> lookup through <asm/hygon/node.h>.
>
> Signed-off-by: Lin Wang <wanglin@open-hieco.net>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260901071700.3255382-1-wanglin@open-hieco.net?part=2
next prev parent reply other threads:[~2026-09-01 7:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 7:16 [PATCH v4 0/5] x86/hygon: Add Family 0x18 DF node enumeration and SMN access Lin Wang
2026-09-01 7:16 ` [PATCH v4 1/5] pci_ids: Add Hygon Family 0x18 DF F3/F4 device IDs Lin Wang
2026-09-01 7:34 ` sashiko-bot
2026-09-03 22:10 ` Bjorn Helgaas
2026-09-04 3:18 ` Lin Wang
2026-09-01 7:16 ` [PATCH v4 2/5] x86/hygon: Add Family 0x18 DF node enumeration Lin Wang
2026-09-01 7:29 ` sashiko-bot [this message]
2026-09-01 7:16 ` [PATCH v4 3/5] x86/hygon: Map CPU NodeIds to DF nodes Lin Wang
2026-09-01 7:32 ` sashiko-bot
2026-09-01 7:16 ` [PATCH v4 4/5] x86/amd_node: Skip SMN setup on Hygon Fam18h models 0x04-0x08 Lin Wang
2026-09-01 7:34 ` sashiko-bot
2026-09-02 2:48 ` Borislav Petkov
2026-09-02 6:22 ` Lin Wang
2026-09-02 15:13 ` Borislav Petkov
2026-09-03 1:49 ` Lin Wang
2026-09-03 17:34 ` Yazen Ghannam
2026-09-04 2:43 ` Lin Wang
2026-09-04 5:36 ` Borislav Petkov
2026-09-04 6:26 ` Lin Wang
2026-09-01 7:17 ` [PATCH v4 5/5] x86/hygon: Add Family 0x18 SMN access Lin Wang
2026-09-01 7:28 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260901072918.6C2A11F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=wanglin@open-hieco.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox