Re: [PATCH v4 1/5] pci_ids: Add Hygon Family 0x18 DF F3/F4 device IDs

[Lin Wang <wanglin@open-hieco.net>]

On 9/4/2026 6:10 AM, Bjorn Helgaas wrote:
>> +#define PCI_DEVICE_ID_HYGON_18H_M04H_DF_F3	0x1463
>> +#define PCI_DEVICE_ID_HYGON_18H_M04H_DF_F4	0x1464
>> +#define PCI_DEVICE_ID_HYGON_18H_M04H_DF_F3B	0x1493
>> +#define PCI_DEVICE_ID_HYGON_18H_M04H_DF_F4B	0x1494
>> +#define PCI_DEVICE_ID_HYGON_18H_M05H_DF_F3	0x14b3
>> +#define PCI_DEVICE_ID_HYGON_18H_M05H_DF_F4	0x14b4
> It looks like these are only needed in one place, so per the note:
> 
>   *      Do not add new entries to this file unless the definitions
>   *      are shared between multiple drivers.
> 
> the #defines should probably be added in the
> arch/x86/kernel/hygon_node.c (or just use the raw hex values).
> 
> This helps reduce conflicts when backporting changes like this.

Hi Bjorn,

Thanks for pointing this out.

These IDs are only used by the Hygon node code in this series. I will
move the definitions to arch/x86/kernel/hygon_node.c. They can be added 
to pci_ids.h later when needed by in-tree users.

Thanks & Br;

Lin