From: Borislav Petkov <bp@alien8.de>
To: Lin Wang <wanglin@open-hieco.net>
Cc: yazen.ghannam@amd.com, mario.limonciello@amd.com,
tglx@linutronix.de, mingo@redhat.com,
dave.hansen@linux.intel.com, "H. Peter Anvin" <hpa@zytor.com>,
bhelgaas@google.com, x86@kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 4/5] x86/amd_node: Skip SMN setup on Hygon Fam18h models 0x04-0x08
Date: Wed, 2 Sep 2026 08:13:40 -0700 [thread overview]
Message-ID: <20260902151340.GAapg9JDQMt2WTkjLM@fat_crate.local> (raw)
In-Reply-To: <5c6ebbf5-3b3c-47e7-800d-adb4049cd636@open-hieco.net>
On Wed, Sep 02, 2026 at 02:22:13PM +0800, Lin Wang wrote:
> Please let me know how you would prefer this to be handled.
Well, X86_FEATURE_ZEN isn't Hygon apparently. Otherwise, we wouldn't be having
this conversation. And we wouldn't need ugly workarounds like that.
Which means, you cannot set it on Hygon. Instead, you should check vendor or
define your own X86_FEATURE_HYGON if you think it would be useful to denote
common set of features between all Hygon cores.
Reusing an AMD-specific flag but then having different hardware which needs
hacks and workarounds to the code is not what you do. Hygon is a different
vendor and it should be treated as such - not piggyback on AMD code.
Unless you wanna piggyback. But then you have to extract it properly and make
it generic so that it can be shared. I have been asking all people submitting
Hygon code to do that and you are starting to do it but then you need to stick
to it and do only that.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2026-09-02 15:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 7:16 [PATCH v4 0/5] x86/hygon: Add Family 0x18 DF node enumeration and SMN access Lin Wang
2026-09-01 7:16 ` [PATCH v4 1/5] pci_ids: Add Hygon Family 0x18 DF F3/F4 device IDs Lin Wang
2026-09-01 7:34 ` sashiko-bot
2026-09-03 22:10 ` Bjorn Helgaas
2026-09-04 3:18 ` Lin Wang
2026-09-01 7:16 ` [PATCH v4 2/5] x86/hygon: Add Family 0x18 DF node enumeration Lin Wang
2026-09-01 7:29 ` sashiko-bot
2026-09-01 7:16 ` [PATCH v4 3/5] x86/hygon: Map CPU NodeIds to DF nodes Lin Wang
2026-09-01 7:32 ` sashiko-bot
2026-09-01 7:16 ` [PATCH v4 4/5] x86/amd_node: Skip SMN setup on Hygon Fam18h models 0x04-0x08 Lin Wang
2026-09-01 7:34 ` sashiko-bot
2026-09-02 2:48 ` Borislav Petkov
2026-09-02 6:22 ` Lin Wang
2026-09-02 15:13 ` Borislav Petkov [this message]
2026-09-03 1:49 ` Lin Wang
2026-09-03 17:34 ` Yazen Ghannam
2026-09-04 2:43 ` Lin Wang
2026-09-04 5:36 ` Borislav Petkov
2026-09-04 6:26 ` Lin Wang
2026-09-01 7:17 ` [PATCH v4 5/5] x86/hygon: Add Family 0x18 SMN access Lin Wang
2026-09-01 7:28 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260902151340.GAapg9JDQMt2WTkjLM@fat_crate.local \
--to=bp@alien8.de \
--cc=bhelgaas@google.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=wanglin@open-hieco.net \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox