Re: [PATCH 01/15] PCI/DPC: Allocate the DPC save buffer during device setup

[sashiko-bot@kernel.org]

> Allocate the DPC capability's save buffer in pci_dpc_init() rather than
> in dpc_probe().
> 
> dpc_probe() runs when the portdrv DPC service binds to a port, which is
> long after the device has been added, and does not happen at all if the
> service is not enabled. Until then pci_save_dpc_state() silently saves
> nothing, so a reset in that window loses the DPC Control register.
> 
> Allocating during device setup makes buffer existence depend only on the
> capability being present, which is what the save and restore paths
> already assume. It also puts every capability save buffer in one phase
> of a device's life, which a later patch relies on.
> 
> The size is a compile-time constant, so nothing about the allocation
> itself has to move with it.
> 
> Assisted-by: LLM
> Signed-off-by: David Matlack <dmatlack@google.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260924173501.856380-1-dmatlack@google.com?part=1