From: sashiko-bot@kernel.org
To: "Shawn Lin" <shawn.lin@rock-chips.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH 2/2] PCI: dwc: Rename pp->irq_domain to pp->msi_irq_domain
Date: Wed, 30 Sep 2026 09:17:06 +0000 [thread overview]
Message-ID: <20260930091707.2995E1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <1790734930-217000-3-git-send-email-shawn.lin@rock-chips.com>
> pp->irq_domain is exclusively the MSI parent irq domain: it is created
> by dw_pcie_allocate_msi_domains() with msi_create_parent_irq_domain()
> and is only used to resolve the MSI child virqs in dw_handle_msi_irq()
> and in the keystone and dra7xx MSI handlers. The name gives no hint
> about that, in the same way dw_pcie_allocate_domains() did not say that
> it was only about MSI.
>
> Rename it to pp->msi_irq_domain, matching the previous rename.
>
> Cc: Vignesh Raghavendra <vigneshr@ti.com>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/1790734930-217000-1-git-send-email-shawn.lin@rock-chips.com?part=2
prev parent reply other threads:[~2026-09-30 9:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 2:22 [PATCH 0/2] PCI: dwc: Make the MSI domain naming explicit Shawn Lin
2026-09-30 2:22 ` [PATCH 1/2] PCI: dwc: Rename dw_pcie_allocate_domains to dw_pcie_allocate_msi_domains Shawn Lin
2026-09-30 9:16 ` sashiko-bot
2026-09-30 2:22 ` [PATCH 2/2] PCI: dwc: Rename pp->irq_domain to pp->msi_irq_domain Shawn Lin
2026-09-30 4:10 ` Vignesh Raghavendra
2026-09-30 9:17 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260930091707.2995E1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox