From: Vignesh Raghavendra <vigneshr@ti.com>
To: Shawn Lin <shawn.lin@rock-chips.com>,
Manivannan Sadhasivam <mani@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>
Cc: <linux-pci@vger.kernel.org>
Subject: Re: [PATCH 2/2] PCI: dwc: Rename pp->irq_domain to pp->msi_irq_domain
Date: Wed, 30 Sep 2026 09:40:15 +0530 [thread overview]
Message-ID: <c29cd5cf-6646-4f20-b5a1-cfa73f679d02@ti.com> (raw)
In-Reply-To: <1790734930-217000-3-git-send-email-shawn.lin@rock-chips.com>
On 30/09/26 07:52, Shawn Lin wrote:
> pp->irq_domain is exclusively the MSI parent irq domain: it is created
> by dw_pcie_allocate_msi_domains() with msi_create_parent_irq_domain()
> and is only used to resolve the MSI child virqs in dw_handle_msi_irq()
> and in the keystone and dra7xx MSI handlers. The name gives no hint
> about that, in the same way dw_pcie_allocate_domains() did not say that
> it was only about MSI.
>
> Rename it to pp->msi_irq_domain, matching the previous rename.
>
> Cc: Vignesh Raghavendra <vigneshr@ti.com>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
> ---
>
Hmm for some reason I dont see this on the lore:
https://lore.kernel.org/all/1790734930-217000-1-git-send-email-shawn.lin@rock-chips.com/
Reviewed-by: Vignesh Raghavendra <vigneshr@ti.com>
> drivers/pci/controller/dwc/pci-dra7xx.c | 2 +-
> drivers/pci/controller/dwc/pci-keystone.c | 2 +-
> drivers/pci/controller/dwc/pcie-designware-host.c | 8 ++++----
> drivers/pci/controller/dwc/pcie-designware.h | 2 +-
> 4 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controller/dwc/pci-dra7xx.c
> index 3460a83..0d56fd5 100644
> --- a/drivers/pci/controller/dwc/pci-dra7xx.c
> +++ b/drivers/pci/controller/dwc/pci-dra7xx.c
> @@ -213,7 +213,7 @@ static int dra7xx_pcie_handle_msi(struct dw_pcie_rp *pp, int index)
>
> pos = find_first_bit(&val, MAX_MSI_IRQS_PER_CTRL);
> while (pos != MAX_MSI_IRQS_PER_CTRL) {
> - generic_handle_domain_irq(pp->irq_domain,
> + generic_handle_domain_irq(pp->msi_irq_domain,
> (index * MAX_MSI_IRQS_PER_CTRL) + pos);
> pos++;
> pos = find_next_bit(&val, MAX_MSI_IRQS_PER_CTRL, pos);
> diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c
> index c35f3f4..388a97c 100644
> --- a/drivers/pci/controller/dwc/pci-keystone.c
> +++ b/drivers/pci/controller/dwc/pci-keystone.c
> @@ -633,7 +633,7 @@ static void ks_pcie_msi_irq_handler(struct irq_desc *desc)
>
> vector = offset + (pos << 3);
> dev_dbg(dev, "irq: bit %d, vector %d\n", pos, vector);
> - generic_handle_domain_irq(pp->irq_domain, vector);
> + generic_handle_domain_irq(pp->msi_irq_domain, vector);
> }
>
> chained_irq_exit(chip, desc);
> diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c
> index 7fb165c..0bf9a59 100644
> --- a/drivers/pci/controller/dwc/pcie-designware-host.c
> +++ b/drivers/pci/controller/dwc/pcie-designware-host.c
> @@ -82,7 +82,7 @@ void dw_handle_msi_irq(struct dw_pcie_rp *pp)
> continue;
>
> for_each_set_bit(pos, &status, MAX_MSI_IRQS_PER_CTRL)
> - generic_handle_demux_domain_irq(pp->irq_domain, irq_off + pos);
> + generic_handle_demux_domain_irq(pp->msi_irq_domain, irq_off + pos);
> }
> }
>
> @@ -217,8 +217,8 @@ int dw_pcie_allocate_msi_domains(struct dw_pcie_rp *pp)
> .host_data = pp,
> };
>
> - pp->irq_domain = msi_create_parent_irq_domain(&info, &dw_pcie_msi_parent_ops);
> - if (!pp->irq_domain) {
> + pp->msi_irq_domain = msi_create_parent_irq_domain(&info, &dw_pcie_msi_parent_ops);
> + if (!pp->msi_irq_domain) {
> dev_err(pci->dev, "Failed to create IRQ domain\n");
> return -ENOMEM;
> }
> @@ -236,7 +236,7 @@ void dw_pcie_free_msi(struct dw_pcie_rp *pp)
> irq_set_chained_handler_and_data(pp->msi_irq[ctrl], NULL, NULL);
> }
>
> - irq_domain_remove(pp->irq_domain);
> + irq_domain_remove(pp->msi_irq_domain);
> }
> EXPORT_SYMBOL_GPL(dw_pcie_free_msi);
>
> diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/controller/dwc/pcie-designware.h
> index 22e8f95..f2fdc29 100644
> --- a/drivers/pci/controller/dwc/pcie-designware.h
> +++ b/drivers/pci/controller/dwc/pcie-designware.h
> @@ -454,7 +454,7 @@ struct dw_pcie_rp {
> int irq;
> const struct dw_pcie_host_ops *ops;
> int msi_irq[MAX_MSI_CTRLS];
> - struct irq_domain *irq_domain;
> + struct irq_domain *msi_irq_domain;
> dma_addr_t msi_data;
> struct irq_chip *msi_irq_chip;
> u32 num_vectors;
--
Regards
Vignesh
https://ti.com/opensource
next prev parent reply other threads:[~2026-09-30 4:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 2:22 [PATCH 0/2] PCI: dwc: Make the MSI domain naming explicit Shawn Lin
2026-09-30 2:22 ` [PATCH 1/2] PCI: dwc: Rename dw_pcie_allocate_domains to dw_pcie_allocate_msi_domains Shawn Lin
2026-09-30 9:16 ` sashiko-bot
2026-09-30 2:22 ` [PATCH 2/2] PCI: dwc: Rename pp->irq_domain to pp->msi_irq_domain Shawn Lin
2026-09-30 4:10 ` Vignesh Raghavendra [this message]
2026-09-30 9:17 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c29cd5cf-6646-4f20-b5a1-cfa73f679d02@ti.com \
--to=vigneshr@ti.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=mani@kernel.org \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox